From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 498A9C63705 for ; Thu, 8 Dec 2022 10:23:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbiLHKXh (ORCPT ); Thu, 8 Dec 2022 05:23:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbiLHKXV (ORCPT ); Thu, 8 Dec 2022 05:23:21 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8E496723F for ; Thu, 8 Dec 2022 02:23:20 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id q7so1056765ljp.9 for ; Thu, 08 Dec 2022 02:23:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g+B5X/siBQMDNHW++d/NVJYttMcaz1xev1asS50hTk8=; b=EQQ3NvJkl389D4dVGmRkI7rzjjmUgb9H1rWNL3+YePkOU2G367ojIHLfsHdsAo1Bpt G8l05jUG/3HYadgZuEumI+wyElNcaHx0FTeW3EXRgyLJB3MsJDUrSpy1Qu7UVEHod6uE 0plq1iyITpsNdTa28xmpRQrpVUrPbz7zsFSDPDGzH3HVK8HZo4KJ71Cm5bN+BJQvTyYG p5ncQxRrourn1artoxlR0ljkaBPNd+H5KlODWDHbtTqsrUb53GZKzamVFz5/ZLYx9qzj TIXikXWtokZESio2ssV8bENWplx9E5VuQRJAiHFfGOgCcASMVlryfcxnCDLoL9WSR/cD WZiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g+B5X/siBQMDNHW++d/NVJYttMcaz1xev1asS50hTk8=; b=zGeyFbm7tZB0HfFH5aD8qMhlBpScwSjmqoYvrqeXxfOJYtMSOzEdOI7VeN6+KjjkLe xUfpvNGcTnICJ2NF46b3A/LgprJcdhBn3P+4cDRXqCgkwto8mnFm4FZvqJrs7+e0cvny pwuJNderK5wIlPhGhzCaThGEeOz5YfuH7mWjHZg4/pGo5w5v7EsgjELkj1qywdCsGb25 BfCYMU2nyPXDFBlEBN7uL5o6V3WWhDFhNWqW/bzTio8hBLL1iaJtZE5K9OLlyILTwEdb 8R0go3RNYS3KkftCgGHbb8LXBv2Cri7xjSVz/19kc6PCKHMQYpJUdBnp7LMpQGJgteBh kwcw== X-Gm-Message-State: ANoB5pmKD3+8QcNZyGMrMDaJ0hmryJ9sdkSzKN3E93Gs1rLXvp9MkEW3 zjQW2WHkad1LAoRFdGplQrY95Q== X-Google-Smtp-Source: AA0mqf4yZqf8tgWsUV7vtH0t1c6GV/jQbn+tgZj2f773cilX6ivTWQ5qvmx4rfBe7VjJ9RNWCqRjkQ== X-Received: by 2002:a05:651c:1c7:b0:27a:267b:f33f with SMTP id d7-20020a05651c01c700b0027a267bf33fmr339228ljn.260.1670494999039; Thu, 08 Dec 2022 02:23:19 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id e1-20020a195001000000b0048aee825e2esm3276489lfb.282.2022.12.08.02.23.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 02:23:18 -0800 (PST) Message-ID: <36eb03e8-aace-f7ce-edc8-53715021c0ea@linaro.org> Date: Thu, 8 Dec 2022 11:23:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add configuration for PMI8950 peripheral Content-Language: en-US To: Marijn Suijten , Luca Weiss Cc: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron References: <20221101161801.1058969-1-luca@z3ntu.xyz> <20221106193722.j64xrhitdencrjxy@SoMainline.org> <20221202093658.vg6t2ptar2arh7hn@SoMainline.org> <2656622.mvXUDI8C0e@g550jk> <20221208101232.536i3cmjf4uk2z52@SoMainline.org> From: Krzysztof Kozlowski In-Reply-To: <20221208101232.536i3cmjf4uk2z52@SoMainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 08/12/2022 11:12, Marijn Suijten wrote: > On 2022-12-04 17:19:05, Luca Weiss wrote: >> On Freitag, 2. Dezember 2022 10:36:58 CET Marijn Suijten wrote: >> [..] >> >> So the way this patch does it is good or does it need changes? > > Except the typo(s?) pointed out in my first reply, this is good to go. > > If we stick with generic adc-chan node names that should be documented > in the bindings IMO, as it is currently only captured implicitly in the > examples. Krzysztof, what is your thought on this? If I understand correctly, the outcome of other discussion [1] was to use labels and generic node names. In such case the patch was correct (except other comments). [1] https://lore.kernel.org/linux-arm-msm/20221112162719.0ac87998@jic23-huawei/ Best regards, Krzysztof