From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965376AbcIFTSa (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Sep 2016 15:18:30 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:53256 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933347AbcIFTS1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Sep 2016 15:18:27 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
        Kefeng Wang <wangkefeng.wang@huawei.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling
Date: Tue, 06 Sep 2016 21:18:50 +0200
Message-ID: <37073907.KMu7rEfE59@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20160906163910.GC7012@localhost.localdomain>
References: <20160906142849.3297250-1-arnd@arndb.de> <20160906163910.GC7012@localhost.localdomain>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:W6DFFkQKsZpUmnGffF7iToc0ge2fWwtheDJ/dE77L9/6mfvWbyY
 dCnxPl/X/1uaJNeFMV9JR6oz7mG3sMsKLeSfsiBZ26SlrV8nMNJqYlCCj168T4GlWLU/Toq
 TE1+UiqTJytUzPDKUv61mVSjP9ft9WpxuBcAnjja1c2EFt4ipJSGZSpJ1TRXdfb2UoFw4Kk
 PaZbmAvnhf3eGMBjFx8fw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:X/pxb30yA2A=:y1VcCvd5pivgc46mA3vkc6
 YAWoaGkIZZzwuUwixCHTkibi2U2AgOMXQrLJLddHeDkduj3Z8NcRSXEdHHgkHEk4ZxTmTkp2D
 buuCbUmHvzOeJrG+3yjuMUlyhwCaj8xY1qov/3Gk0jALmlfVjSbRlRu+y8z8izjzgVh9gqrF5
 LAzV531Ysr/7K4hobyLpX6bTQ2/PHuYnYgrrZrwX+ZSOVQUshRrKlabt+rI2u4zsnX6Y3t5Bt
 uRUeDKdoBd+uowIFsC7tdUjQUiEXKuh4fNPdBT907JS5TET4XJPyFYpreFTQ29HT4wgdL8IR3
 tmj7eTjifedVk47wf4T4chaq2Ht4l1RloozKChxfcra55DwLp9FJf51rK2QJ9K9HgeAiow5JD
 CqUH//jOe+9gWl61Ub9Uv1Dg+oZgbSsx5EiGq2P8cyeiTST3br93GNAx6fskpYhGR2fkwk/20
 MVVmXxYRzQ6sl6X5decIwFkflzBULKPfgvBMtUpTpVC8S+yt6OnpPjNnoljJFTQ4ecKMGM8kN
 jrsNYbhznD9zHa6zyuJPaocNXQYJwFMKWoSt/sfi5MqnEvyqQJ9v6xjC8SceBYiKhco/DfS/E
 pEf6WSnpdRLr05F8hUJB2NEaKbAVIE8SSUbnUGEjGL76Oef14KitkPbi8dEYQbU3jd6V7oQyp
 ZY6hxSPwU0LQQ3cxkvqBeUSheIqkDh3I5zoB5ooWhMtdNkFnpFK5Wy2rs2aMuwSfh0wUqt3+2
 DNPtt/FhxHJ7FGd8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, September 6, 2016 6:39:10 PM CEST Richard Cochran wrote:
> On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote:
> > gpio_to_irq does not return NO_IRQ but instead returns a negative
> > error code on failure. Returning NO_IRQ from the function has no
> > negative effects as we only compare the result to the expected
> > interrupt number, but it's better to return a proper failure
> > code for consistency, and we should remove NO_IRQ from the kernel
> > entirely.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Richard Cochran <richardcochran@gmail.com>

Thanks!

I just realized that the randconfig builder had not picked up this
one and there was a typo. I'll send a replacement patch with your
Ack added in.

	Arnd