From: David Howells <dhowells@redhat.com>
To: Dave Wysochanski <dwysocha@redhat.com>
Cc: dhowells@redhat.com, Daire Byrne <daire.byrne@gmail.com>,
Benjamin Maynard <benmaynard@google.com>,
linux-cachefs@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] fscache: Fix oops due to race with cookie_lru and use_cookie
Date: Thu, 17 Nov 2022 13:52:47 +0000 [thread overview]
Message-ID: <3716830.1668693167@warthog.procyon.org.uk> (raw)
In-Reply-To: <20221117115023.1350181-2-dwysocha@redhat.com>
Dave Wysochanski <dwysocha@redhat.com> wrote:
> + clear_bit(FSCACHE_COOKIE_DO_LRU_DISCARD, &cookie->flags);
Actually, can you do test_and_clear_bit() and then log a trace point, say:
fscache_see_cookie(cookie, fscache_cookie_see_lru_discard_cancel);
if the bit was set.
David
next prev parent reply other threads:[~2022-11-17 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 11:50 [PATCH 0/1] Fix oops in cachefiles_prepare_write due to cookie_lru and use_cookie race Dave Wysochanski
2022-11-17 11:50 ` [PATCH 1/1] fscache: Fix oops due to race with cookie_lru and use_cookie Dave Wysochanski
2022-11-17 13:30 ` David Howells
2022-11-17 13:36 ` David Howells
2022-11-17 13:52 ` David Howells [this message]
2022-11-17 14:10 ` David Wysochanski
2022-11-22 8:00 ` [PATCH 0/1] Fix oops in cachefiles_prepare_write due to cookie_lru and use_cookie race Daire Byrne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3716830.1668693167@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=benmaynard@google.com \
--cc=daire.byrne@gmail.com \
--cc=dwysocha@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.