From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADB9C433DB for ; Wed, 20 Jan 2021 23:49:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76329223DB for ; Wed, 20 Jan 2021 23:49:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76329223DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=matj8We4uRXXusFJc9LTOsXrnUWgBLPAe3fxbFxwkw0=; b=Rv2Kt0vtj5Knb0zmBLjnd2rM/ xKJSmwDLuk6QytGBrjOYdnsT5dAsu+X9imLlx0p7X+hEqJQSdTlo/uNwRq3Rd3PSQo+w78pO27+ko OyJcI1LO5ICNc2moPFajgcmsa2KKdo8tbn5+3JNE48KZrdLHV8ADlfcYg21sNfCoPnLkWnmFDiTWO pT/1gI51mc7HQOX51spu6NSXo3NJzPnPn51+9O3N131G0RopUmzBCJATexyFtAr3VGNhOo6dg1MWJ m5rLo7n0xQY02dsGl0XRbnGeJ4UCDm4vyqfMuqoOwq8l4SlwWieJD7jLjfs95lUtehYF5uqB5RH9w 7EI0eeLWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2NCw-0007H5-FT; Wed, 20 Jan 2021 23:48:14 +0000 Received: from mailoutvs35.siol.net ([185.57.226.226] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2NCt-0007F9-9u for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 23:48:12 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 2D14F5226BB; Thu, 21 Jan 2021 00:48:06 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8D556PpCTud9; Thu, 21 Jan 2021 00:48:05 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id D8092522872; Thu, 21 Jan 2021 00:48:05 +0100 (CET) Received: from kista.localnet (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 514235226BB; Thu, 21 Jan 2021 00:48:04 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-arm-kernel@lists.infradead.org, Hermann.Lauer@uni-heidelberg.de Subject: Re: ARM: dts: sun7i: a20: bananapro: Fix ethernet node Date: Thu, 21 Jan 2021 00:48:04 +0100 Message-ID: <3722018.ZAFEQt6F9G@kista> In-Reply-To: <20210120114026.GA3045@lemon.iwr.uni-heidelberg.de> References: <20210120114026.GA3045@lemon.iwr.uni-heidelberg.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_184811_541965_A54F4516 X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wens@csie.org, mripard@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Change itself it's fine, just few comments on your commit message and e-mail recipients. Dne sreda, 20. januar 2021 ob 12:40:26 CET je Hermann.Lauer@uni-heidelberg.de napisal(a): > BananaPro 1GB works only reliable with the patch for M2 Ultra applied to > it's devicetree, too. Without this patch you will get high packet loss rates. M2 Ultra has nothing to do with BananaPro, it's better to explain real reason why this change fixes ethernet. > > Tested-by: Hermann Lauer Tested-by tag from the patch author is not very useful, it's already expected that you (or person you know) tested it, when sending fixes. > > From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001 > From: Jernej Skrabec > Date: Sun, 25 Oct 2020 09:19:49 +0100 > Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node As I said, referencing fix for another, unrelated board is not really meaningful. > > Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix > ethernet node to reflect that fact. > > Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC ethernet controller") Fixes tag is for M2 Ultra and completely irrelevant here. Please provide proper Fixes tag for this file. You are missing Signed-of-by tag at the end of the message. You missed few maintainers and mailing lists in "to" and "cc" field. Run "scripts/get_maintainer.pl" on this patch to get full list of recipients. Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel