Re: [PATCH v3 2/2] ethdev: add hierarchical scheduler API

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2017-03-04 01:10, Cristian Dumitrescu:
> This patch introduces the generic ethdev API for the traffic manager
> capability, which includes: hierarchical scheduling, traffic shaping,
> congestion management, packet marking.
> 
> Main features:
> - Exposed as ethdev plugin capability (similar to rte_flow approach)
> - Capability query API per port, per hierarchy level and per hierarchy node
> - Scheduling algorithms: Strict Priority (SP), Weighed Fair Queuing (WFQ),
>   Weighted Round Robin (WRR)
> - Traffic shaping: single/dual rate, private (per node) and shared (by multiple
>   nodes) shapers
> - Congestion management for hierarchy leaf nodes: algorithms of tail drop,
>   head drop, WRED; private (per node) and shared (by multiple nodes) WRED
>   contexts
> - Packet marking: IEEE 802.1q (VLAN DEI), IETF RFC 3168 (IPv4/IPv6 ECN for
>   TCP and SCTP), IETF RFC 2597 (IPv4 / IPv6 DSCP)

Please could you split some parts of this API in separate patches?
And it would be nice to add some text in the programmer's guide as part
of the API patches. It will help the review.
It could provide you the opportunity to explain the rationale in the
commit messages of each part and save it in the git history.

Last detail, please Cristian, try to be concise when writing such
explanations ;)

Thanks