From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fi1fB-0005NL-2C for qemu-devel@nongnu.org; Tue, 24 Jul 2018 14:03:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fi1fA-00052x-5c for qemu-devel@nongnu.org; Tue, 24 Jul 2018 14:03:57 -0400 References: <20180724084739.580-1-famz@redhat.com> From: John Snow Message-ID: <37287746-8350-6b01-76dd-47a380eb9ed2@redhat.com> Date: Tue, 24 Jul 2018 14:03:40 -0400 MIME-Version: 1.0 In-Reply-To: <20180724084739.580-1-famz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] iotests: Fix 226 on _my_ system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz On 07/24/2018 04:47 AM, Fam Zheng wrote: > Something has locked /dev/null on my system (I still don't know what to do with > the annoying incapability of lslocks, or more precisely /proc/locks, on > inspecting OFD lock information), and as a result 226 cannot pass due to the > unexpected image locking error. > > Fix the test case by disabling locking, and add a doc text about using test > images. > > Fam Zheng (2): > docs: Describe using images in writing iotests > iotests: Don't lock /dev/null in 226 > > docs/devel/testing.rst | 11 +++++++++++ > tests/qemu-iotests/226 | 4 ++-- > 2 files changed, 13 insertions(+), 2 deletions(-) > I think this is the better approach for now, yeah. Sorry my test caused so many problems... :[ Reviewed-by: John Snow