All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>, Can Guo <cang@codeaurora.org>,
	Stanley Chu <stanley.chu@mediatek.com>
Subject: Re: [PATCH 3/4] scsi: ufs-debugfs: Add user-defined exception_event_mask
Date: Thu, 04 Feb 2021 15:58:31 +0100	[thread overview]
Message-ID: <372c6dbbda18cccdcf2b053ee87f2ada9640e2b8.camel@gmail.com> (raw)
In-Reply-To: <b7a812ed-8965-76cf-3d05-be2486fcaed2@intel.com>

On Wed, 2021-02-03 at 11:56 +0200, Adrian Hunter wrote:
> > 
> > Hallo Adrian
> 
> Hi Bean
> 
> Thanks for the review
> 
> > 
> > Would you like sharing the advantage of this debugfs node comparing
> > to
> > sysfs node "attributes/exception_event_control(if it is writable)"?
> 
> Primarily this is being done as a debug interface, but the user's
> exception
> events also need to be kept separate from the driver's ones.
> 
> > what is the value of this?
> 
> To be able to determine if the UFS device is being affected by
> exception events.
> 
> > Also, now I can disable/enable UFS event over ufs-bsg.
> 
> That will be overwritten by the driver when it updates the e.g. bkops
> control, or sometimes also suspend/resume.

Hi Adrian
yes, I saw that, they are not tracked by driver.

I have one question that why "exception_event_mask" cannot represent
the current QUERY_ATTR_IDN_EE_CONTROL value? only after writing it.


thanks,
Bean





  reply	other threads:[~2021-02-04 15:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 14:15 [PATCH 0/4] scsi: ufs-debugfs: Add UFS Exception Event reporting Adrian Hunter
2021-01-19 14:15 ` [PATCH 1/4] scsi: ufs: Add exception event tracepoint Adrian Hunter
2021-02-03  8:37   ` Bean Huo
2021-01-19 14:15 ` [PATCH 2/4] scsi: ufs: Add exception event definitions Adrian Hunter
2021-02-03  8:25   ` Bean Huo
2021-01-19 14:15 ` [PATCH 3/4] scsi: ufs-debugfs: Add user-defined exception_event_mask Adrian Hunter
2021-02-03  9:45   ` Bean Huo
2021-02-03  9:56     ` Adrian Hunter
2021-02-04 14:58       ` Bean Huo [this message]
2021-02-04 15:25         ` Adrian Hunter
2021-01-19 14:15 ` [PATCH 4/4] scsi: ufs-debugfs: Add user-defined exception event rate limiting Adrian Hunter
2021-02-03  7:51 ` [PATCH 0/4] scsi: ufs-debugfs: Add UFS Exception Event reporting Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=372c6dbbda18cccdcf2b053ee87f2ada9640e2b8.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=cang@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.