[U-Boot] [PATCH v2 02/15] zynq: kconfig: move board select menu and commonsettings

From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 02/15] zynq: kconfig: move board select menu and commonsettings
Date: Wed, 6 Aug 2014 09:57:46 +0200	[thread overview]
Message-ID: <3737a9be-d03c-4828-be81-b33045b685ea@BN1BFFO11FD038.protection.gbl> (raw)
In-Reply-To: <20140806154928.D5B5.AA925319@jp.panasonic.com>

On 08/06/2014 08:49 AM, Masahiro Yamada wrote:
> Hi Michal,
> 
> 
> On Wed, 6 Aug 2014 08:39:47 +0200
> Michal Simek <michal.simek@xilinx.com> wrote:
> 
>> Hi Masahiro,
>>
>> On 08/06/2014 05:17 AM, Masahiro Yamada wrote:
>>> Becuase the board select menu in arch/arm/Kconfig is too big,
>>> move the Zynq board select menu to zynq/Kconfig.
>>>
>>> Consolidate also common settings (CONFIG_SYS_CPU="armv7" and
>>> CONFIG_SYS_SOC="zynq").
>>>
>>> Refactor board/xilinx/zynq/MAINTAINERS too.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>>> Cc: Michal Simek <michal.simek@xilinx.com>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>>  arch/arm/Kconfig                   | 15 ++----
>>>  arch/arm/cpu/armv7/zynq/Kconfig    | 43 +++++++++++++++++
>>>  board/xilinx/zynq/Kconfig          | 95 --------------------------------------
>>>  board/xilinx/zynq/MAINTAINERS      | 12 +----
>>>  configs/zynq_microzed_defconfig    |  1 +
>>>  configs/zynq_zc70x_defconfig       |  1 +
>>>  configs/zynq_zc770_xm010_defconfig |  1 +
>>>  configs/zynq_zc770_xm012_defconfig |  1 +
>>>  configs/zynq_zc770_xm013_defconfig |  1 +
>>>  configs/zynq_zed_defconfig         |  1 +
>>>  include/configs/zynq-common.h      |  1 -
>>>  11 files changed, 54 insertions(+), 118 deletions(-)
>>>  create mode 100644 arch/arm/cpu/armv7/zynq/Kconfig
>>>  delete mode 100644 board/xilinx/zynq/Kconfig
>> One
>> One thing I have noticed was that when I run
>> [u-boot]$ make zynq_zc70x_defconfig
>> ...
>>
>> there is incorrect CONFIG_DEFCONFIG_LIST setup
>>
>> [u-boot]$ head .config
>> #
>> # Automatically generated file; DO NOT EDIT.
>> # U-Boot 2014.07 Configuration
>> #
>> CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig"
> 
> I assume you thought having sandbox_defconfig in ARM .config
> is weird.

Not exactly this. My expectation was that when I use
zynq_zc70x_defconfig that it will be listed there instead of sandbox one.
Or just CONFIG_DEFCONFIG_LIST not there.

> But I think this is correct.
> 
> Unlike Linux,  defconfig has a flat structure in U-Boot
> because ARCH=arm is not given from the command line.

Even if ARCH=arm is passed behavior is the same

[u-boot]$ make ARCH=arm zynq_zc70x_defconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
#
# configuration written to spl/.config
#
[u-boot]$ head .config
#
# Automatically generated file; DO NOT EDIT.
# U-Boot 2014.07 Configuration
#
CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig"

#
# General setup
#
CONFIG_SPL=y

Is DEFCONFIG_LIST used anywhere?
I just want to know what is this for.

> 
> Sandbox is the default when no defconfig is specified
> although this is not related to this series at all.

yes it is not related that's why I have given you
Tested-by for that patch.

Thanks,
Michal