From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXYns-00022L-En for qemu-devel@nongnu.org; Wed, 10 Aug 2016 15:04:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXYnq-0000b1-A8 for qemu-devel@nongnu.org; Wed, 10 Aug 2016 15:04:35 -0400 References: <1470679640-18366-1-git-send-email-clord@redhat.com> <1470679640-18366-5-git-send-email-clord@redhat.com> From: Max Reitz Message-ID: <373902e2-bd93-941d-1b91-6f4f0d451dba@redhat.com> Date: Wed, 10 Aug 2016 21:04:24 +0200 MIME-Version: 1.0 In-Reply-To: <1470679640-18366-5-git-send-email-clord@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ikedm52bmkSUfvuFb5ukiXhLlceRf7hPA" Subject: Re: [Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ikedm52bmkSUfvuFb5ukiXhLlceRf7hPA From: Max Reitz To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org Message-ID: <373902e2-bd93-941d-1b91-6f4f0d451dba@redhat.com> Subject: Re: [PATCH v7 4/4] blockdev: Modularize nfs block driver References: <1470679640-18366-1-git-send-email-clord@redhat.com> <1470679640-18366-5-git-send-email-clord@redhat.com> In-Reply-To: <1470679640-18366-5-git-send-email-clord@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 08.08.2016 20:07, Colin Lord wrote: > Modularizes the nfs block driver so that it gets dynamically loaded. >=20 > Signed-off-by: Colin Lord > Reviewed-by: Stefan Hajnoczi > --- > block/Makefile.objs | 1 + > configure | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) I'm not quite sure what this achieves. From what I can see, the NFS block driver is still linked hard into qemu and it is unconditionally registered at qemu startup. (The output from a printf() in nfs_block_init() is visible even when just starting qemu-img or qemu-io without any arguments; most notably without bdrv_find_protocol() having been invoked at all.) Max --ikedm52bmkSUfvuFb5ukiXhLlceRf7hPA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXq3q4EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrT5n B/9vepBaHABG0WtYlQK7kY8HvGLp0/PlZZRYR2kZS97kJOVYisFobQzQYC72gqkE nT7lAsDHbEv8S2S6qKKWCyolRZNnxLcPKam0wR6MpeyJnM/ASPsKasgQz2ZW+ro6 9uLzvMgx8KmG6gWkyAUWvS1zywpphsktjVi27yiU/JgMipCVu9l2bc+dY9rh/yXT T/jntjDVx8DWDouFxYndDzyD1yejQ5SVXMYDeknlaDo1+jvs6XYiMVdnvF6BVIRW GlHYPjuxylWkMY1iPLiM4LBM0YXvRWMZ7o0pi1mlo6AXBwOgqfrdhYTx4UZykHzB gP7j3hfPkTpN00jKAXmqpWsL =onOC -----END PGP SIGNATURE----- --ikedm52bmkSUfvuFb5ukiXhLlceRf7hPA--