All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Agner <stefan.agner@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] IMX6 NAND boot regression
Date: Sat, 2 Feb 2019 07:49:37 +0000	[thread overview]
Message-ID: <373ab899-ed9f-d5b7-cae4-910d4666125e@toradex.com> (raw)
In-Reply-To: <CAJ+vNU2qsFccyvZsM30Ao-5Cbr995U2r=KUTrHLFfW9RRfHQDA@mail.gmail.com>

Hi Tim,

On 02.02.19 03:32, Tim Harvey wrote:
> Stefan,
> 
> I'm trying to track down an IMX6 SPL NAND boot regression that started
> in v2018.07 with your patch series to mxs_nand.

I am sorry about that. Unfortunately I did not had a design at hand where I was able to test the NAND driver in SPL...

> 
> I bisected it back to '5346c31e305a37d39f535cc0d5ae87d8b7e81230 mtd:
> nand: mxs_nand: use self init'. With this particular patch nand bbt
> scanning would crash the board because of nand_chip.scan_btt not being
> assigned. This was later fixed in
> '96d0be07e7498e7174daa6f3b56fc807b9feb71d MTD: nand: mxs_nand_spl: Fix
> empty function pointer for BBT' but cherry-picking that on top of
> 5346c31 fixes the immediate crash while scanning but then I find that
> mxs_read_page_ecc() hangs on the 4th page of reading u-boot.img from
> the NAND. This gets worse 2 patches later where in
> '28897e8d21f8e197e259a91c693de09cd81f2d5a: mtd: nand: mxs_nand: use
> structure for BCH geometry' I find that the first byte of every page
> read is wrong because mxs_nand_swap_block_mark() is getting called on
> the page which swaps the first bytes with oob.
> 
> There are several IMX6 boards out there using both NAND and SPL I
> believe that I would assume were broken by this series. Any ideas on
> the proper resolution?

Adam Ford sent another patch just recently with the title: "MTD: nand: mxs_nand: Allow driver to auto setup ECC in SPL". Maybe this helps?

--
Stefan

> 
> Regards,
> 
> Tim
> 

  reply	other threads:[~2019-02-02  7:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02  2:32 [U-Boot] IMX6 NAND boot regression Tim Harvey
2019-02-02  7:49 ` Stefan Agner [this message]
2019-02-02  8:28   ` Jagan Teki
2019-02-02 13:30     ` Adam Ford
2019-02-02 19:22       ` Jörg Krause
2019-02-04 18:14       ` Tim Harvey
2019-03-05 16:41         ` Michael Nazzareno Trimarchi
2019-03-05 16:54           ` Tim Harvey
2019-03-05 16:59             ` Michael Nazzareno Trimarchi
2019-03-05 17:19               ` Michael Nazzareno Trimarchi
2019-03-05 17:20               ` Tim Harvey
2019-03-05 18:26                 ` Michael Nazzareno Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=373ab899-ed9f-d5b7-cae4-910d4666125e@toradex.com \
    --to=stefan.agner@toradex.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.