[PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

The block core requests modules with the "-iosched" name suffix, but
bfq no longer has that suffix.  Add an alias.

Fixes: ea25da48086d ("block, bfq: split bfq-iosched.c into multiple ...")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 block/bfq-iosched.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 436b6ca6b175..3a01563bd564 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -4998,6 +4998,7 @@ static struct elevator_type iosched_bfq_mq = {
 	.elevator_name =	"bfq",
 	.elevator_owner =	THIS_MODULE,
 };
+MODULE_ALIAS("bfq-iosched");
 
 static int __init bfq_init(void)
 {


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

[PATCH 2/2] mq-deadline: Enable auto-loading when built as module

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

The block core requests modules with the "-iosched" name suffix, but
mq-deadline does not have that suffix.  Add an alias.

Fixes: 945ffb60c11d ("mq-deadline: add blk-mq adaptation of the deadline ...")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 block/mq-deadline.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/mq-deadline.c b/block/mq-deadline.c
index 1b964a387afe..78e7698fa4ed 100644
--- a/block/mq-deadline.c
+++ b/block/mq-deadline.c
@@ -660,6 +660,7 @@ static struct elevator_type mq_deadline = {
 	.elevator_name = "mq-deadline",
 	.elevator_owner = THIS_MODULE,
 };
+MODULE_ALIAS("mq-deadline-iosched");
 
 static int __init deadline_init(void)
 {

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

Re: [PATCH 2/2] mq-deadline: Enable auto-loading when built as module

[Ming Lei]

On Sun, Aug 13, 2017 at 06:03:15PM +0100, Ben Hutchings wrote:
> The block core requests modules with the "-iosched" name suffix, but
> mq-deadline does not have that suffix.  Add an alias.
> 
> Fixes: 945ffb60c11d ("mq-deadline: add blk-mq adaptation of the deadline ...")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
>  block/mq-deadline.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/mq-deadline.c b/block/mq-deadline.c
> index 1b964a387afe..78e7698fa4ed 100644
> --- a/block/mq-deadline.c
> +++ b/block/mq-deadline.c
> @@ -660,6 +660,7 @@ static struct elevator_type mq_deadline = {
>  	.elevator_name = "mq-deadline",
>  	.elevator_owner = THIS_MODULE,
>  };
> +MODULE_ALIAS("mq-deadline-iosched");
>  
>  static int __init deadline_init(void)
>  {

Reviewed-by: Ming Lei <ming.lei@redhat.com>

-- 
Ming

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Ming Lei]

On Sun, Aug 13, 2017 at 06:02:19PM +0100, Ben Hutchings wrote:
> The block core requests modules with the "-iosched" name suffix, but
> bfq no longer has that suffix.  Add an alias.
> 
> Fixes: ea25da48086d ("block, bfq: split bfq-iosched.c into multiple ...")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
>  block/bfq-iosched.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 436b6ca6b175..3a01563bd564 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -4998,6 +4998,7 @@ static struct elevator_type iosched_bfq_mq = {
>  	.elevator_name =	"bfq",
>  	.elevator_owner =	THIS_MODULE,
>  };
> +MODULE_ALIAS("bfq-iosched");
>  
>  static int __init bfq_init(void)
>  {
> 

Reviewed-by: Ming Lei <ming.lei@redhat.com>


-- 
Ming

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Jens Axboe]

On Sun, Aug 13 2017, Ben Hutchings wrote:
> The block core requests modules with the "-iosched" name suffix, but
> bfq no longer has that suffix.  Add an alias.

I'd apply these two, but both patches are mangled when saved. It's
turning == into =3D and so forth.

Care to check your settings and resend?

-- 
Jens Axboe

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
> On Sun, Aug 13 2017, Ben Hutchings wrote:
> > The block core requests modules with the "-iosched" name suffix, but
> > bfq no longer has that suffix.  Add an alias.
> 
> I'd apply these two, but both patches are mangled when saved. It's
> turning == into =3D and so forth.
> 
> Care to check your settings and resend?

Just tried saving and applying with 'git am' successfully.  I think the
problem is at your end.

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Jens Axboe]

On 08/29/2017 09:28 AM, Ben Hutchings wrote:
> On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
>> On Sun, Aug 13 2017, Ben Hutchings wrote:
>>> The block core requests modules with the "-iosched" name suffix, but
>>> bfq no longer has that suffix.  Add an alias.
>>
>> I'd apply these two, but both patches are mangled when saved. It's
>> turning == into =3D and so forth.
>>
>> Care to check your settings and resend?
> 
> Just tried saving and applying with 'git am' successfully.  I think the
> problem is at your end.

Then yours is the only one, I apply patches people send me all day long.
Was the case both in tbird and mutt, both of them showed the diffs
as mangled, and they showed up mangled when saved.

-- 
Jens Axboe

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Jens Axboe]

On 08/29/2017 09:48 AM, Jens Axboe wrote:
> On 08/29/2017 09:28 AM, Ben Hutchings wrote:
>> On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
>>> On Sun, Aug 13 2017, Ben Hutchings wrote:
>>>> The block core requests modules with the "-iosched" name suffix, but
>>>> bfq no longer has that suffix.  Add an alias.
>>>
>>> I'd apply these two, but both patches are mangled when saved. It's
>>> turning == into =3D and so forth.
>>>
>>> Care to check your settings and resend?
>>
>> Just tried saving and applying with 'git am' successfully.  I think the
>> problem is at your end.
> 
> Then yours is the only one, I apply patches people send me all day long.
> Was the case both in tbird and mutt, both of them showed the diffs
> as mangled, and they showed up mangled when saved.

Here's your email in the archive:

https://marc.info/?l=linux-block&m=150264374920778&q=raw

Note this part:

Content-Transfer-Encoding: quoted-printable

Problem is definitely at your end.

-- 
Jens Axboe

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Ben Hutchings]

[-- Attachment #1.1: Type: text/plain, Size: 1458 bytes --]

On Tue, 2017-08-29 at 09:53 -0600, Jens Axboe wrote:
> On 08/29/2017 09:48 AM, Jens Axboe wrote:
> > On 08/29/2017 09:28 AM, Ben Hutchings wrote:
> > > On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
> > > > On Sun, Aug 13 2017, Ben Hutchings wrote:
> > > > > The block core requests modules with the "-iosched" name
> > > > > suffix, but
> > > > > bfq no longer has that suffix.  Add an alias.
> > > > 
> > > > I'd apply these two, but both patches are mangled when saved.
> > > > It's
> > > > turning == into =3D and so forth.
> > > > 
> > > > Care to check your settings and resend?
> > > 
> > > Just tried saving and applying with 'git am' successfully.  I
> > > think the
> > > problem is at your end.
> > 
> > Then yours is the only one, I apply patches people send me all day
> > long.
> > Was the case both in tbird and mutt, both of them showed the diffs
> > as mangled, and they showed up mangled when saved.
> 
> Here's your email in the archive:
> 
> https://marc.info/?l=linux-block&m=150264374920778&q=raw
> 
> Note this part:
> 
> Content-Transfer-Encoding: quoted-printable

What about it?  This is used for every mail with a non-ASCII name in
it, for example.  'git am' understands it.

> Problem is definitely at your end.

Or perhaps in the middle?  Anyway, here are the patches again as an
mbox.

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.


[-- Attachment #1.2: block-sched-module-aliases.mbox --]
[-- Type: application/mbox, Size: 1787 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Jens Axboe]

On 08/29/2017 10:34 AM, Ben Hutchings wrote:
> On Tue, 2017-08-29 at 09:53 -0600, Jens Axboe wrote:
>> On 08/29/2017 09:48 AM, Jens Axboe wrote:
>>> On 08/29/2017 09:28 AM, Ben Hutchings wrote:
>>>> On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
>>>>> On Sun, Aug 13 2017, Ben Hutchings wrote:
>>>>>> The block core requests modules with the "-iosched" name
>>>>>> suffix, but
>>>>>> bfq no longer has that suffix.  Add an alias.
>>>>>
>>>>> I'd apply these two, but both patches are mangled when saved.
>>>>> It's
>>>>> turning == into =3D and so forth.
>>>>>
>>>>> Care to check your settings and resend?
>>>>
>>>> Just tried saving and applying with 'git am' successfully.  I
>>>> think the
>>>> problem is at your end.
>>>
>>> Then yours is the only one, I apply patches people send me all day
>>> long.
>>> Was the case both in tbird and mutt, both of them showed the diffs
>>> as mangled, and they showed up mangled when saved.
>>
>> Here's your email in the archive:
>>
>> https://marc.info/?l=linux-block&m=150264374920778&q=raw
>>
>> Note this part:
>>
>> Content-Transfer-Encoding: quoted-printable
> 
> What about it?  This is used for every mail with a non-ASCII name in
> it, for example.  'git am' understands it.

What about it? It screws up the patch. Maybe git am understands it, but
it's hard/impossible to read manually. I'm not going to apply anything
that I can't personally read/review easily. Fix your setup, if you are
going to be sending patches.

>> Problem is definitely at your end.
> 
> Or perhaps in the middle?  Anyway, here are the patches again as an
> mbox.

Feel free to browse other patches on the list, I don't see any that
are quoted-printable. And I'd know, since I generally end up applying
(or at least reviewing) most of them.

-- 
Jens Axboe

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2339 bytes --]

On Tue, 2017-08-29 at 10:46 -0600, Jens Axboe wrote:
> On 08/29/2017 10:34 AM, Ben Hutchings wrote:
> > On Tue, 2017-08-29 at 09:53 -0600, Jens Axboe wrote:
> > > On 08/29/2017 09:48 AM, Jens Axboe wrote:
> > > > On 08/29/2017 09:28 AM, Ben Hutchings wrote:
> > > > > On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
> > > > > > On Sun, Aug 13 2017, Ben Hutchings wrote:
> > > > > > > The block core requests modules with the "-iosched" name
> > > > > > > suffix, but
> > > > > > > bfq no longer has that suffix.  Add an alias.
> > > > > > 
> > > > > > I'd apply these two, but both patches are mangled when saved.
> > > > > > It's
> > > > > > turning == into =3D and so forth.
> > > > > > 
> > > > > > Care to check your settings and resend?
> > > > > 
> > > > > Just tried saving and applying with 'git am' successfully.  I
> > > > > think the
> > > > > problem is at your end.
> > > > 
> > > > Then yours is the only one, I apply patches people send me all day
> > > > long.
> > > > Was the case both in tbird and mutt, both of them showed the diffs
> > > > as mangled, and they showed up mangled when saved.
> > > 
> > > Here's your email in the archive:
> > > 
> > > https://marc.info/?l=linux-block&m=150264374920778&q=raw
> > > 
> > > Note this part:
> > > 
> > > Content-Transfer-Encoding: quoted-printable
> > 
> > What about it?  This is used for every mail with a non-ASCII name in
> > it, for example.  'git am' understands it.
> 
> What about it? It screws up the patch. Maybe git am understands it, but
> it's hard/impossible to read manually.

Where, other than the 'raw' link above, are you seeing the patch with
q-p encoding not decoded?

> I'm not going to apply anything
> that I can't personally read/review easily. Fix your setup, if you are
> going to be sending patches.

So you won't accept patches from anyone with a non-ASCII name?

Ben.

> > > Problem is definitely at your end.
> > 
> > Or perhaps in the middle?  Anyway, here are the patches again as an
> > mbox.
> 
> Feel free to browse other patches on the list, I don't see any that
> are quoted-printable. And I'd know, since I generally end up applying
> (or at least reviewing) most of them.
> 
-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Jens Axboe]

On 08/29/2017 01:49 PM, Ben Hutchings wrote:
> On Tue, 2017-08-29 at 10:46 -0600, Jens Axboe wrote:
>> On 08/29/2017 10:34 AM, Ben Hutchings wrote:
>>> On Tue, 2017-08-29 at 09:53 -0600, Jens Axboe wrote:
>>>> On 08/29/2017 09:48 AM, Jens Axboe wrote:
>>>>> On 08/29/2017 09:28 AM, Ben Hutchings wrote:
>>>>>> On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
>>>>>>> On Sun, Aug 13 2017, Ben Hutchings wrote:
>>>>>>>> The block core requests modules with the "-iosched" name
>>>>>>>> suffix, but
>>>>>>>> bfq no longer has that suffix.  Add an alias.
>>>>>>>
>>>>>>> I'd apply these two, but both patches are mangled when saved.
>>>>>>> It's
>>>>>>> turning == into =3D and so forth.
>>>>>>>
>>>>>>> Care to check your settings and resend?
>>>>>>
>>>>>> Just tried saving and applying with 'git am' successfully.  I
>>>>>> think the
>>>>>> problem is at your end.
>>>>>
>>>>> Then yours is the only one, I apply patches people send me all day
>>>>> long.
>>>>> Was the case both in tbird and mutt, both of them showed the diffs
>>>>> as mangled, and they showed up mangled when saved.
>>>>
>>>> Here's your email in the archive:
>>>>
>>>> https://marc.info/?l=linux-block&m=150264374920778&q=raw
>>>>
>>>> Note this part:
>>>>
>>>> Content-Transfer-Encoding: quoted-printable
>>>
>>> What about it?  This is used for every mail with a non-ASCII name in
>>> it, for example.  'git am' understands it.
>>
>> What about it? It screws up the patch. Maybe git am understands it, but
>> it's hard/impossible to read manually.
> 
> Where, other than the 'raw' link above, are you seeing the patch with
> q-p encoding not decoded?

When I save it and view it.

>> I'm not going to apply anything
>> that I can't personally read/review easily. Fix your setup, if you are
>> going to be sending patches.
> 
> So you won't accept patches from anyone with a non-ASCII name?

You're being ridiculous.

-- 
Jens Axboe

Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2702 bytes --]

On Tue, 2017-08-29 at 13:57 -0600, Jens Axboe wrote:
> On 08/29/2017 01:49 PM, Ben Hutchings wrote:
> > On Tue, 2017-08-29 at 10:46 -0600, Jens Axboe wrote:
> > > On 08/29/2017 10:34 AM, Ben Hutchings wrote:
> > > > On Tue, 2017-08-29 at 09:53 -0600, Jens Axboe wrote:
> > > > > On 08/29/2017 09:48 AM, Jens Axboe wrote:
> > > > > > On 08/29/2017 09:28 AM, Ben Hutchings wrote:
> > > > > > > On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
> > > > > > > > On Sun, Aug 13 2017, Ben Hutchings wrote:
> > > > > > > > > The block core requests modules with the "-iosched" name
> > > > > > > > > suffix, but
> > > > > > > > > bfq no longer has that suffix.  Add an alias.
> > > > > > > > 
> > > > > > > > I'd apply these two, but both patches are mangled when saved.
> > > > > > > > It's
> > > > > > > > turning == into =3D and so forth.
> > > > > > > > 
> > > > > > > > Care to check your settings and resend?
> > > > > > > 
> > > > > > > Just tried saving and applying with 'git am' successfully.  I
> > > > > > > think the
> > > > > > > problem is at your end.
> > > > > > 
> > > > > > Then yours is the only one, I apply patches people send me all day
> > > > > > long.
> > > > > > Was the case both in tbird and mutt, both of them showed the diffs
> > > > > > as mangled, and they showed up mangled when saved.
> > > > > 
> > > > > Here's your email in the archive:
> > > > > 
> > > > > https://marc.info/?l=linux-block&m=150264374920778&q=raw
> > > > > 
> > > > > Note this part:
> > > > > 
> > > > > Content-Transfer-Encoding: quoted-printable
> > > > 
> > > > What about it?  This is used for every mail with a non-ASCII name in
> > > > it, for example.  'git am' understands it.
> > > 
> > > What about it? It screws up the patch. Maybe git am understands it, but
> > > it's hard/impossible to read manually.
> > 
> > Where, other than the 'raw' link above, are you seeing the patch with
> > q-p encoding not decoded?
> 
> When I save it and view it.

I don't understand why you wouldn't do that in your mailer.  You're
going to need to switch back to the mailer when you reply, after all.
But if you want to display a quoted-printable file in a terminal, you
can use 'qprint -d' to do that.

> > > I'm not going to apply anything
> > > that I can't personally read/review easily. Fix your setup, if you are
> > > going to be sending patches.
> > 
> > So you won't accept patches from anyone with a non-ASCII name?
> 
> You're being ridiculous.

Am I?  It seems like they would trigger the same problem in your
current workflow.

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]