From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B1BC433F5 for ; Fri, 17 Sep 2021 09:44:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC530611C3 for ; Fri, 17 Sep 2021 09:44:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC530611C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRAQA-0001S7-MT for qemu-devel@archiver.kernel.org; Fri, 17 Sep 2021 05:44:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRAPP-0000dQ-0K for qemu-devel@nongnu.org; Fri, 17 Sep 2021 05:43:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRAPM-0007tv-EN for qemu-devel@nongnu.org; Fri, 17 Sep 2021 05:43:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631871826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pMG6BvdsI94ASYIychChwyQH5ZG2MYzPRo4cgvtR2AQ=; b=Z1B4u/HbHQsJEBjnj3H+DyTQnsfD0FL0RMoaHT+MXbljcohSmkNHuGyaUsb+wrIEbEu4zd +SGiKgw9PyRhs+V/7BnHIcfoR5/Ze6WWh610gLTB/0k3JqiIDJ7AuXLxI62TzOpDXrlbLA zLsN7OQ/sWtPjswjsJZtFeFIKVs7Hkc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-9TzeMNtVODuExveOKPlDPA-1; Fri, 17 Sep 2021 05:43:45 -0400 X-MC-Unique: 9TzeMNtVODuExveOKPlDPA-1 Received: by mail-wr1-f69.google.com with SMTP id v15-20020adff68f000000b0015df51efa18so3502989wrp.16 for ; Fri, 17 Sep 2021 02:43:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=pMG6BvdsI94ASYIychChwyQH5ZG2MYzPRo4cgvtR2AQ=; b=jfT9XofWxLajzsJsj1V/PddLVX/i+FUPHGJE7auVTvM1n6N2tzWTglih1jz59f0NMv TYECogeQoMoE8MXDDjiR00rHx6iX20AVW7vvwpTNrbZaALvyYxLYCeMpuev/28imB9pW 7mhJNqDAx2GUENlAVRBlyAsdyHQ1CKLTSE8T7AAVjhRMJXStXwe/IAMFBzof/FWQ4vbz cB52VTtV+pRyUleeXnMYH/k+PsosBsa++y3FI0glckpPRnIOUjhqJXSrvbQn9DjED/dg c7VQBY0d3AoZkQjQsABJMxQzJi/MxeRn7csjok/vcTViEMTA93Iamr5y2MCwNyDlO24a qiLw== X-Gm-Message-State: AOAM533kSsNGuPO8x2FKNrwUv4OMEDQGmUhlUclF2FwIPnYD3pIIn16U 8uQNLk+wDFrwuW92xyE9jM/obCQohkiO1FnIgWtwbzBaPBGiVHpzJn6s3Q9bR2g5wpx+SsTy4u6 QVBbjkkJxF8tb3ZQ= X-Received: by 2002:adf:eb4c:: with SMTP id u12mr11143140wrn.111.1631871824576; Fri, 17 Sep 2021 02:43:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhTWndQhoz3e47iQP5qZHeeJ06Gviri1d+gGoi0S+vy1wC8YBknbppCIw03dCrwVTXjPbwSw== X-Received: by 2002:adf:eb4c:: with SMTP id u12mr11143121wrn.111.1631871824396; Fri, 17 Sep 2021 02:43:44 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e48:3780:4451:9a65:d4e9:9bb6]) by smtp.gmail.com with ESMTPSA id h8sm9778568wmb.35.2021.09.17.02.43.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 02:43:44 -0700 (PDT) Subject: Re: [PATCH v3 07/16] iotests/297: Don't rely on distro-specific linter binaries To: John Snow , qemu-devel@nongnu.org References: <20210916040955.628560-1-jsnow@redhat.com> <20210916040955.628560-8-jsnow@redhat.com> From: Hanna Reitz Message-ID: <374eff9f-0e9e-a2da-19ab-1c39a63191b0@redhat.com> Date: Fri, 17 Sep 2021 11:43:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210916040955.628560-8-jsnow@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.488, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, Markus Armbruster , Cleber Rosa , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16.09.21 06:09, John Snow wrote: > 'pylint-3' is another Fedora-ism. Use "python3 -m pylint" or "python3 -m > mypy" to access these scripts instead. This style of invocation will > prefer the "correct" tool when run in a virtual environment. > > Note that we still check for "pylint-3" before the test begins -- this > check is now "overly strict", but shouldn't cause anything that was > already running correctly to start failing. > > Signed-off-by: John Snow > Reviewed-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Philippe Mathieu-Daudé > --- > tests/qemu-iotests/297 | 45 ++++++++++++++++++++++++------------------ > 1 file changed, 26 insertions(+), 19 deletions(-) I know it sounds silly, but to be honest I have no idea if replacing `mypy` by `python3 -m mypy` is correct, because no mypy documentation seems to suggest it. From what I understand, that’s generally how Python “binaries” work, though (i.e., installed as a module invokable with `python -m`, and then providing some stub binary that, well, effectively does this, but kind of in a weird way, I just don’t understand it), and none of the parameters seem to be hurt in this conversion, so: Reviewed-by: Hanna Reitz