All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: David Brazdil <dbrazdil@google.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Marc Zyngier <maz@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe
Date: Mon, 7 Sep 2020 15:29:40 +0200	[thread overview]
Message-ID: <3750C774-62A4-4D02-8C07-6C98304F32F3@goldelico.com> (raw)

Hi,
it seems as if your patch

34f379956e9d7 ("KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe")
[ Upstream commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 ]

fails to compile in v5.8.7 for me (using an aarch64 gcc 4.9 cross-toolchain to try
to build a kernel for the PinePhone):

  CC      arch/arm64/kvm/hyp/switch.o - due to target missing
arch/arm64/kvm/hyp/switch.c: In function 'hyp_panic':
arch/arm64/kvm/hyp/switch.c:904:2: error: impossible constraint in 'asm'
  asm volatile("ldr %0, =%1" : "=r" (str_va) : "S" (__hyp_panic_string));
  ^

I can find the commit b38b298aa4397e2dc74a89b4dd3eac9e59b64c96 in upstream
but not the affected file. There is also "KVM: arm64: Split hyp/switch.c to VHE/nVHE"
which does a cleanup and rename and v5.9-rc4 compiles fine.

With a git revert 34f379956e9d7 on v5.8.7 I can compile without problems.

So something seems to be incomplete or premature with the backport.

BR and thanks,
Nikolaus Schaller



             reply	other threads:[~2020-09-07 17:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 13:29 H. Nikolaus Schaller [this message]
2020-09-07 14:22 ` [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe Sasha Levin
2020-09-07 14:42   ` H. Nikolaus Schaller
2020-09-14 13:36     ` David Brazdil
2021-01-25 20:07       ` Oliver Upton
2021-01-25 20:56         ` Marc Zyngier
2021-01-26 18:23           ` Oliver Upton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3750C774-62A4-4D02-8C07-6C98304F32F3@goldelico.com \
    --to=hns@goldelico.com \
    --cc=dbrazdil@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.