All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, "Yao, Lei A" <lei.a.yao@intel.com>, stable@dpdk.org
Subject: Re: [PATCH] examples/l3fwd-power: fix Rx descriptor size
Date: Mon, 01 May 2017 18:01:29 +0200	[thread overview]
Message-ID: <3754229.ISIS8DmyvR@xps> (raw)
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A19C09D@shsmsx102.ccr.corp.intel.com>

28/04/2017 09:47, Yao, Lei A:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > 
> > L3fwd power app monitors the RX queues to see if the polling frequency
> > should be adjusted (the busier the queue, the higher the frequency).
> > The app uses several thresholds in the ring to determine the frequency,
> > being 96 the highest one, when frequency should be highest.
> > 
> > The problem is that the difference between this value and the ring size
> > is not big enough (128 - 96 = 32 descriptors), which means that
> > if the descriptors are not replenished quick enough, queue might
> > not be busy, but the app would think that it is, because 96th descriptor
> > is set.
> > 
> > Therefore, by increasing this gap (increasing the RX ring size),
> > we make sure that this false measurement will not happen.
> > 
> > Fixes: b451aa39db31 ("examples/l3fwd-power: use DD bit rather than RX
> > queue count")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

> I have test this patch based on 17.05-rc2 , issue is fixed. Host frequency can 
> be changed according to the data throughput. 
> Tested-by: Lei Yao (lei.a.yao@intel.com)

Applied, thanks

      reply	other threads:[~2017-05-01 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 11:29 [PATCH] examples/l3fwd-power: fix Rx descriptor size Pablo de Lara
2017-04-28  7:47 ` Yao, Lei A
2017-05-01 16:01   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3754229.ISIS8DmyvR@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=lei.a.yao@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.