From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sameer Pujar Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Date: Fri, 24 Jan 2020 08:57:40 +0530 Message-ID: <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <743d6d7d-f29c-191a-853b-414250ca38df-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 1/24/2020 6:58 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 20.01.2020 17:23, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > [snip] >> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg) >> +{ >> + struct tegra_admaif *admaif =3D dev_get_drvdata(dev); >> + unsigned int ch_stride =3D TEGRA_ADMAIF_CHANNEL_REG_STRIDE; >> + unsigned int num_ch =3D admaif->soc_data->num_ch; >> + unsigned int rx_base =3D admaif->soc_data->rx_base; >> + unsigned int tx_base =3D admaif->soc_data->tx_base; >> + unsigned int global_base =3D admaif->soc_data->global_base; >> + unsigned int reg_max =3D admaif->soc_data->regmap_conf->max_regist= er; >> + unsigned int rx_max =3D rx_base + (num_ch * ch_stride); >> + unsigned int tx_max =3D tx_base + (num_ch * ch_stride); >> + >> + if ((reg >=3D rx_base) && (reg < rx_max)) { > The braces are not needed around the comparisons because they precede > the AND. Same for all other similar occurrences in the code. While that is true, some prefer to use explicit braces to make it more=20 readable. In the past I was told to use explicitly in such cases. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CEFC35241 for ; Fri, 24 Jan 2020 03:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9F0022522 for ; Fri, 24 Jan 2020 03:27:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="sEiQb0pL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730778AbgAXD1u (ORCPT ); Thu, 23 Jan 2020 22:27:50 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:11201 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbgAXD1t (ORCPT ); Thu, 23 Jan 2020 22:27:49 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 23 Jan 2020 19:27:34 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 23 Jan 2020 19:27:48 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 23 Jan 2020 19:27:48 -0800 Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 24 Jan 2020 03:27:43 +0000 CC: , , , , , , , , , , , , , , Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver To: Dmitry Osipenko , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> From: Sameer Pujar Message-ID: <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> Date: Fri, 24 Jan 2020 08:57:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579836454; bh=/uQyjMlog0EEeGCpQdgZ8NEtOXVI02tvF1e/kfKTnrw=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=sEiQb0pLX+BpSOAzxH6fhgVWwQCGYaac7UNqj2/iT9KWSfL/lLbL1cYKxNTL5Su9n jVnzqfyD6BquPKUbyt4eZ7xEputbu/V7DM1DeQ1i6ykizK10qMSqOxkZ7KkL5lqu7M Sqw0nIvrhGI/XI1tXO2GiPKi1zISexdF2jjSTXml4uUXTLF+BLRzd9bBnYi9uhGkRR qJJwgZD6APTXzj85AbJdM0AYs0HrmHihgX41l+nBo78QynBQ2l1qo/UmlLgkwbIce8 ww3E5qS1uL9MZftcDu8ys4OqM20tt0exJN9WxhL97EvKsEdQ4G3bLtddszOHmyHQSQ gDnIoar7Q+G8Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/2020 6:58 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 20.01.2020 17:23, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > [snip] >> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg) >> +{ >> + struct tegra_admaif *admaif =3D dev_get_drvdata(dev); >> + unsigned int ch_stride =3D TEGRA_ADMAIF_CHANNEL_REG_STRIDE; >> + unsigned int num_ch =3D admaif->soc_data->num_ch; >> + unsigned int rx_base =3D admaif->soc_data->rx_base; >> + unsigned int tx_base =3D admaif->soc_data->tx_base; >> + unsigned int global_base =3D admaif->soc_data->global_base; >> + unsigned int reg_max =3D admaif->soc_data->regmap_conf->max_regist= er; >> + unsigned int rx_max =3D rx_base + (num_ch * ch_stride); >> + unsigned int tx_max =3D tx_base + (num_ch * ch_stride); >> + >> + if ((reg >=3D rx_base) && (reg < rx_max)) { > The braces are not needed around the comparisons because they precede > the AND. Same for all other similar occurrences in the code. While that is true, some prefer to use explicit braces to make it more=20 readable. In the past I was told to use explicitly in such cases. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC418C35240 for ; Fri, 24 Jan 2020 03:28:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D08222522 for ; Fri, 24 Jan 2020 03:28:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="eIkP+Reu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="sEiQb0pL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D08222522 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8F2DD166B; Fri, 24 Jan 2020 04:27:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8F2DD166B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579836527; bh=/2iAp/ccV87HE2ncWuKyc841R5PBajv4gQ9EyAaxrQc=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eIkP+Reu5ZkQOBpTnF/eBcV0P73rSYjz0DhjgVniJ4s8bLega15sfjs1gkEd+lcic Zmj2WCcoLk4wcXWkVCYadfdual2jOoQL1YZgF122T2/8GgL81QCLn61vDjR6ixuw5f YCDcSPObs/Y3IJKxpJJ239TpbW6NdB93kBG0vOBM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0D42DF801D8; Fri, 24 Jan 2020 04:27:57 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 28D2BF8020C; Fri, 24 Jan 2020 04:27:55 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 29C02F800BA for ; Fri, 24 Jan 2020 04:27:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 29C02F800BA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="sEiQb0pL" Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 23 Jan 2020 19:27:34 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 23 Jan 2020 19:27:48 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 23 Jan 2020 19:27:48 -0800 Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 24 Jan 2020 03:27:43 +0000 To: Dmitry Osipenko , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> From: Sameer Pujar Message-ID: <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> Date: Fri, 24 Jan 2020 08:57:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579836454; bh=/uQyjMlog0EEeGCpQdgZ8NEtOXVI02tvF1e/kfKTnrw=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=sEiQb0pLX+BpSOAzxH6fhgVWwQCGYaac7UNqj2/iT9KWSfL/lLbL1cYKxNTL5Su9n jVnzqfyD6BquPKUbyt4eZ7xEputbu/V7DM1DeQ1i6ykizK10qMSqOxkZ7KkL5lqu7M Sqw0nIvrhGI/XI1tXO2GiPKi1zISexdF2jjSTXml4uUXTLF+BLRzd9bBnYi9uhGkRR qJJwgZD6APTXzj85AbJdM0AYs0HrmHihgX41l+nBo78QynBQ2l1qo/UmlLgkwbIce8 ww3E5qS1uL9MZftcDu8ys4OqM20tt0exJN9WxhL97EvKsEdQ4G3bLtddszOHmyHQSQ gDnIoar7Q+G8Q== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, spujar@nvidia.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" CgpPbiAxLzI0LzIwMjAgNjo1OCBBTSwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IEV4dGVybmFs IGVtYWlsOiBVc2UgY2F1dGlvbiBvcGVuaW5nIGxpbmtzIG9yIGF0dGFjaG1lbnRzCj4KPgo+IDIw LjAxLjIwMjAgMTc6MjMsIFNhbWVlciBQdWphciDQv9C40YjQtdGCOgo+IFtzbmlwXQo+PiArc3Rh dGljIGJvb2wgdGVncmFfYWRtYWlmX3dyX3JlZyhzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVk IGludCByZWcpCj4+ICt7Cj4+ICsgICAgIHN0cnVjdCB0ZWdyYV9hZG1haWYgKmFkbWFpZiA9IGRl dl9nZXRfZHJ2ZGF0YShkZXYpOwo+PiArICAgICB1bnNpZ25lZCBpbnQgY2hfc3RyaWRlID0gVEVH UkFfQURNQUlGX0NIQU5ORUxfUkVHX1NUUklERTsKPj4gKyAgICAgdW5zaWduZWQgaW50IG51bV9j aCA9IGFkbWFpZi0+c29jX2RhdGEtPm51bV9jaDsKPj4gKyAgICAgdW5zaWduZWQgaW50IHJ4X2Jh c2UgPSBhZG1haWYtPnNvY19kYXRhLT5yeF9iYXNlOwo+PiArICAgICB1bnNpZ25lZCBpbnQgdHhf YmFzZSA9IGFkbWFpZi0+c29jX2RhdGEtPnR4X2Jhc2U7Cj4+ICsgICAgIHVuc2lnbmVkIGludCBn bG9iYWxfYmFzZSA9IGFkbWFpZi0+c29jX2RhdGEtPmdsb2JhbF9iYXNlOwo+PiArICAgICB1bnNp Z25lZCBpbnQgcmVnX21heCA9IGFkbWFpZi0+c29jX2RhdGEtPnJlZ21hcF9jb25mLT5tYXhfcmVn aXN0ZXI7Cj4+ICsgICAgIHVuc2lnbmVkIGludCByeF9tYXggPSByeF9iYXNlICsgKG51bV9jaCAq IGNoX3N0cmlkZSk7Cj4+ICsgICAgIHVuc2lnbmVkIGludCB0eF9tYXggPSB0eF9iYXNlICsgKG51 bV9jaCAqIGNoX3N0cmlkZSk7Cj4+ICsKPj4gKyAgICAgaWYgKChyZWcgPj0gcnhfYmFzZSkgJiYg KHJlZyA8IHJ4X21heCkpIHsKPiBUaGUgYnJhY2VzIGFyZSBub3QgbmVlZGVkIGFyb3VuZCB0aGUg Y29tcGFyaXNvbnMgYmVjYXVzZSB0aGV5IHByZWNlZGUKPiB0aGUgQU5ELiBTYW1lIGZvciBhbGwg b3RoZXIgc2ltaWxhciBvY2N1cnJlbmNlcyBpbiB0aGUgY29kZS4KCldoaWxlIHRoYXQgaXMgdHJ1 ZSwgc29tZSBwcmVmZXIgdG8gdXNlIGV4cGxpY2l0IGJyYWNlcyB0byBtYWtlIGl0IG1vcmUgCnJl YWRhYmxlLgpJbiB0aGUgcGFzdCBJIHdhcyB0b2xkIHRvIHVzZSBleHBsaWNpdGx5IGluIHN1Y2gg Y2FzZXMuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpB bHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cHM6 Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg==