All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: "Huang, Ying" <ying.huang@intel.com>,
	Weizhao Ouyang <o451686892@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>,
	Michal Hocko <mhocko@suse.com>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	Yang Shi <yang.shi@linux.alibaba.com>, Zi Yan <ziy@nvidia.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Minchan Kim <minchan@kernel.org>,
	Mina Almasry <almasrymina@google.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Oscar Salvador <osalvador@suse.de>, Wei Xu <weixugc@google.com>
Subject: Re: [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to migrate_reason_names
Date: Tue, 21 Sep 2021 14:53:34 -0700	[thread overview]
Message-ID: <375b4cb9-b031-964f-7e37-f5639254742e@nvidia.com> (raw)
In-Reply-To: <384b551e-28f0-ca7a-61b5-78f238de6e4d@nvidia.com>

On 9/21/21 11:00, John Hubbard wrote:
> On 9/21/21 07:06, Huang, Ying wrote:
> ...
>>>> Can we add BUILD_BUG_ON() somewhere to capture at least some
>>>> synchronization issue?
>>>
>>> Hi Huang, we discussed this in the v1 thread with you and John, seems you
>>> missed it. Now we just add a comment to do the synchronization, and we can
>>> figure out a more general way to use strings which in trace_events straight.
>>
>> Got it!  And I think we can add the BUILD_BUG_ON() now and delete it
>> when we have a better solution to deal with that.  But if you can work
>> out a better solution quickly, that's fine to ignore this.
>>
> 
> I have a solution now, it's basically what I sent earlier. There appears to be
> some confusion about it. I'll send it out as a patch that builds on top of
> these two, hopefully in a few hours, if no problems pop up during testing.
> 

Oh OK, I think the confusion was on my end: you are hoping to integrate the
TRACE_DEFINE_ENUM in with this. Let me take a peek there, because otherwise,
we can only reduce, but not fully remove the duplication.

thanks,
-- 
John Hubbard
NVIDIA

  reply	other threads:[~2021-09-21 21:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21  6:45 [PATCH v2 0/2] mm/debug: sync up latest migrate_reason to migrate_reason_names Weizhao Ouyang
2021-09-21  6:45 ` [PATCH v2 1/2] mm/debug: sync up MR_CONTIG_RANGE and MR_LONGTERM_PIN Weizhao Ouyang
2021-09-22  4:48   ` John Hubbard
2021-09-21  6:45 ` [PATCH v2 2/2] mm/debug: sync up latest migrate_reason to migrate_reason_names Weizhao Ouyang
2021-09-21  7:07   ` Huang, Ying
2021-09-21  7:07     ` Huang, Ying
2021-09-21  7:31     ` Weizhao Ouyang
2021-09-21 14:06       ` Huang, Ying
2021-09-21 14:06         ` Huang, Ying
2021-09-21 18:00         ` John Hubbard
2021-09-21 21:53           ` John Hubbard [this message]
2021-09-22  2:07           ` Huang, Ying
2021-09-22  2:07             ` Huang, Ying
2021-09-22  4:49   ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=375b4cb9-b031-964f-7e37-f5639254742e@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=o451686892@gmail.com \
    --cc=osalvador@suse.de \
    --cc=pasha.tatashin@soleen.com \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=yang.shi@linux.alibaba.com \
    --cc=ying.huang@intel.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.