From: Cameron Gutman <aicommander@gmail.com>
To: benjamin.tissoires@redhat.com, aduggan@synaptics.com,
nick@shmanahar.org, cheiny@synaptics.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Synaptics RMI4 touchpad regression in 4.11-rc1
Date: Sat, 11 Mar 2017 17:55:58 -0800 [thread overview]
Message-ID: <375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com> (raw)
Hi,
Beginning in 4.11-rc1, it looks like RMI4 is binding to my XPS 13 9443's
Synaptics touchpad and dropping some errors into dmesg. Here are the
messages that seem RMI-related:
rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version
rmi4_f34: probe of rmi4-00.fn34 failed with error -22
rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3038-001, fw id: 1832324
input: Synaptics TM3038-001 as /devices/pci0000:00/INT3433:00/i2c-7/i2c-DLL0665:01/0018:06CB:76AD.0001/input/input19
hid-rmi 0018:06CB:76AD.0001: input,hidraw0: I2C HID v1.00 Mouse [DLL0665:01 06CB:76AD] on i2c-DLL0665:01
Since "Unrecognized bootloader version" isn't a really helpful message, I
applied the attached patch to print the bootloader version which gave
me the following:
rmi4_f34 rmi4-00.fn34: rmi_f34v7_probe: Unrecognized bootloader version: 16
I don't really know what to make of that. It seem very different than the
values the existing code expects.
Compared to hid-multitouch, the RMI stack seems to have completely broken
palm rejection and introduced some random jumpiness during fine pointing
motions. I don't know if these issues are caused by the above errors or
are a separate issue.
The affected machine is an XPS 13 9443 running Fedora 25 with 4.11-rc1
and libinput 1.6.3-3.fc25 (latest in F25).
Let me know any additional info you'd like.
Regards,
Cameron
----
diff --git a/drivers/input/rmi4/rmi_f34v7.c b/drivers/input/rmi4/rmi_f34v7.c
index 56c6c39..b458cb3 100644
--- a/drivers/input/rmi4/rmi_f34v7.c
+++ b/drivers/input/rmi4/rmi_f34v7.c
@@ -1369,8 +1369,8 @@ int rmi_f34v7_probe(struct f34_data *f34)
} else if (f34->bootloader_id[1] == 7) {
f34->bl_version = 7;
} else {
- dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version\n",
- __func__);
+ dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version: %u\n",
+ __func__, f34->bootloader_id[1]);
return -EINVAL;
}
next reply other threads:[~2017-03-12 1:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 1:55 Cameron Gutman [this message]
2017-03-12 2:10 ` Synaptics RMI4 touchpad regression in 4.11-rc1 Cameron Gutman
2017-03-13 9:11 ` Thorsten Leemhuis
2017-03-13 13:13 ` Benjamin Tissoires
2017-03-13 13:15 ` Benjamin Tissoires
2017-03-14 1:35 ` Andrew Duggan
2017-03-14 5:10 ` Cameron Gutman
2017-03-14 8:14 ` Thorsten Leemhuis
2017-03-15 1:20 ` Andrew Duggan
2017-03-15 1:20 ` Andrew Duggan
2017-03-14 19:53 ` Nick Dyer
2017-03-15 1:19 ` Andrew Duggan
2017-03-15 1:19 ` Andrew Duggan
2017-03-17 16:57 ` Benjamin Tissoires
2017-03-17 19:23 ` Andrew Duggan
2017-03-20 5:00 ` Peter Hutterer
2017-03-29 1:50 ` Andrew Duggan
2017-03-29 6:03 ` Peter Hutterer
2017-03-29 8:50 ` Benjamin Tissoires
2017-03-30 0:23 ` Andrew Duggan
2017-03-31 8:57 ` Benjamin Tissoires
2017-03-31 22:23 ` Andrew Duggan
2017-11-20 14:03 ` Mantas Mikulėnas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com \
--to=aicommander@gmail.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cheiny@synaptics.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.