From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FCD4C433F5 for ; Tue, 9 Nov 2021 08:27:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5463A611C1 for ; Tue, 9 Nov 2021 08:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5463A611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SIofnkionoN+1CbALTLVH0TaQD3NJZ6zGM3qkhag8EI=; b=f7A7VWB+Jc3Lz0MX2VG3Lzag0q v/q0BzehgdOPR6dcjYbScVn+LO76GqE37bP/ExHVxKj0l9c/1JxkWRHULPuHY5SKXwQYXC59O+g2H f67ZfOsg+btEt2pf5FwB2uTBtgGBpT8leWIMaUn1k93dmrcx7HjEwl0HFQJK2Bu3X0IBGEQ5czQ++ tM5YbcDVC51O4HB0pMgwFS8ZsMdAltjpBeDsMDwL5N6weqU3oownx0F6npxDT85ryX/jflom4DbGp h+YKBaK7gnfJw0F3oimDfjLiZZSGiwbE1nkiRCzLUlfKmdjOw5L7pvJeYXMz3ZB5hD83ZBCB1iIB3 PYJG4lIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkMSf-000zl7-0U; Tue, 09 Nov 2021 08:26:33 +0000 Received: from ssl.serverraum.org ([176.9.125.105]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkMQK-000z8k-0Y; Tue, 09 Nov 2021 08:24:09 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 2E68222234; Tue, 9 Nov 2021 09:24:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1636446242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=brDcFVORL8BBgZ7AAF+s0KLF9AdXafCjOd3awOS8PG8=; b=RdsTDCOV1N9cd9SVdge7DmheEkjElP8quK8y+C+LvxKTsoW4ZQIh/7vQdZutCOvpapWdbU puUClFXhzEpCbyxTrIBZCEL+zXW10b+z4JqxDTGEV2F0j1le8fbbPsEsFsI0Bf9kgz7UIt vVYt38ZZdIFehPl2IJQ/qjVPD62tGG8= MIME-Version: 1.0 Date: Tue, 09 Nov 2021 09:24:02 +0100 From: Michael Walle To: Tudor Ambarus Subject: Re: [PATCH v3 04/25] mtd: spi-nor: Get rid of nor->page_size In-Reply-To: <20211029172633.886453-5-tudor.ambarus@microchip.com> References: <20211029172633.886453-1-tudor.ambarus@microchip.com> <20211029172633.886453-5-tudor.ambarus@microchip.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <37626e9222304eb463808a58199f0cfe@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_002408_268353_0466B00A X-CRM114-Status: UNSURE ( 7.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: macromorgan@hotmail.com, vigneshr@ti.com, jaimeliao@mxic.com.tw, richard@nod.at, esben@geanix.com, linux@rasmusvillemoes.dk, knaerzche@gmail.com, nicolas.ferre@microchip.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, code@reto-schneider.ch, miquel.raynal@bootlin.com, heiko.thiery@gmail.com, sr@denx.de, p.yadav@ti.com, mail@david-bauer.net, zhengxunli@mxic.com.tw Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Am 2021-10-29 19:26, schrieb Tudor Ambarus: > nor->page_size duplicated what nor->params->page_size indicates > for no good reason. page_size is a flash parameter of fixed value > and it is better suited to be found in nor->params->page_size. > > Signed-off-by: Tudor Ambarus > Reviewed-by: Pratyush Yadav IIRC this patch already had my: Reviewed-by: Michael Walle ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07886C433EF for ; Tue, 9 Nov 2021 08:27:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6D3A6115A for ; Tue, 9 Nov 2021 08:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6D3A6115A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QryWY3EQaJ0hHD8+4tTupe7TsTza3tTzpBYH5ijzm94=; b=x0P41sWvx9HCP1NbV5nGMPNd6P RurPBiDDtE4DLnWWZagjf5x9bqnKza/m+/Uv4rdTO6CRDReJulGvmJmFpNrmL0xpCK08jreyDweAT uLUf9LHXR1kzYTnIRGKibpPiy5TBNRFHKWYsazeQ4AznPIEeX+rm1GSjE/rm4f+rFK4219w/GtvTs 3dIVhnTgpg5bAsVUQJjeRY1Pva6adb+mvdjs4GvfODzssdB9aGsjA2CsuHaLclmIGbEr5iqX0Vof4 9dWV2A7kvgRYsIASG3mObmpfhPlkUQoc4KfzQ3hTokz+V6S4R3moodWDhYpp9j+sSIL2MM5sgN6j6 co+f03kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkMRo-000zXV-7Q; Tue, 09 Nov 2021 08:25:40 +0000 Received: from ssl.serverraum.org ([176.9.125.105]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkMQK-000z8k-0Y; Tue, 09 Nov 2021 08:24:09 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 2E68222234; Tue, 9 Nov 2021 09:24:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1636446242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=brDcFVORL8BBgZ7AAF+s0KLF9AdXafCjOd3awOS8PG8=; b=RdsTDCOV1N9cd9SVdge7DmheEkjElP8quK8y+C+LvxKTsoW4ZQIh/7vQdZutCOvpapWdbU puUClFXhzEpCbyxTrIBZCEL+zXW10b+z4JqxDTGEV2F0j1le8fbbPsEsFsI0Bf9kgz7UIt vVYt38ZZdIFehPl2IJQ/qjVPD62tGG8= MIME-Version: 1.0 Date: Tue, 09 Nov 2021 09:24:02 +0100 From: Michael Walle To: Tudor Ambarus Subject: Re: [PATCH v3 04/25] mtd: spi-nor: Get rid of nor->page_size In-Reply-To: <20211029172633.886453-5-tudor.ambarus@microchip.com> References: <20211029172633.886453-1-tudor.ambarus@microchip.com> <20211029172633.886453-5-tudor.ambarus@microchip.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <37626e9222304eb463808a58199f0cfe@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_002408_268353_0466B00A X-CRM114-Status: UNSURE ( 7.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: macromorgan@hotmail.com, vigneshr@ti.com, jaimeliao@mxic.com.tw, richard@nod.at, esben@geanix.com, linux@rasmusvillemoes.dk, knaerzche@gmail.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, code@reto-schneider.ch, miquel.raynal@bootlin.com, heiko.thiery@gmail.com, sr@denx.de, figgyc@figgyc.uk, p.yadav@ti.com, mail@david-bauer.net, zhengxunli@mxic.com.tw Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 2021-10-29 19:26, schrieb Tudor Ambarus: > nor->page_size duplicated what nor->params->page_size indicates > for no good reason. page_size is a flash parameter of fixed value > and it is better suited to be found in nor->params->page_size. > > Signed-off-by: Tudor Ambarus > Reviewed-by: Pratyush Yadav IIRC this patch already had my: Reviewed-by: Michael Walle _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel