From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver Date: Fri, 24 Jan 2020 07:28:52 +0300 Message-ID: <37669247-daaf-c6cb-0ef2-464e61db9838@gmail.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-6-git-send-email-spujar@nvidia.com> <5ed7482e-e874-9e11-c84e-7418e4b5162e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 24.01.2020 06:39, Sameer Pujar пишет: >>> +static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, >>> +                                  struct snd_ctl_elem_value *uctl) >>> +{ >>> +     struct snd_soc_component *cmpnt = >>> snd_soc_dapm_kcontrol_component(kctl); >>> +     struct tegra_ahub *ahub = snd_soc_component_get_drvdata(cmpnt); >>> +     struct snd_soc_dapm_context *dapm = >>> snd_soc_dapm_kcontrol_dapm(kctl); >>> +     struct soc_enum *e = (struct soc_enum *)kctl->private_value; >>> +     struct snd_soc_dapm_update update[TEGRA_XBAR_UPDATE_MAX_REG] = >>> { }; >> Shouldn't this be {0} to make array zero'ed? > > Isn't it the same with empty braces? Looks like is should be the same because turns out GCC has an extension for that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D0FC2D0CE for ; Fri, 24 Jan 2020 04:28:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC3022075D for ; Fri, 24 Jan 2020 04:28:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b7VL69Al" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730434AbgAXE25 (ORCPT ); Thu, 23 Jan 2020 23:28:57 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:37398 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729760AbgAXE25 (ORCPT ); Thu, 23 Jan 2020 23:28:57 -0500 Received: by mail-lf1-f68.google.com with SMTP id b15so301339lfc.4; Thu, 23 Jan 2020 20:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VLtJqd9n8iEGWWWwFYJk44IhKuekuFlbjkOOSjbK4Ug=; b=b7VL69Al4Q3TfIx5Glo4Lk/mg/RMvnYyJKH/l2Yzy5Oex07mnDpixdToqeCBQaoAWK B9nzH8IJcDmQd26XXA66TJkZfV7/u9aW1PcLZlg43tTjKlDt7O6av3JfuZa8oW+kOZbT PiSjuNcQh+X8/rsAroz+7FMrjT+mrpQBUdUGUxR4QvetWX9Z5OW+6b0vIZoky9V0BvZh 14IHMkUS21cds/eS9GcYG3UndNtA+LoWyAnB9lw4IHvNJDW188GKTHaJ58/0Z8bY4J0L 7o1xo3iI45c56/LRLxwcXsTcoo1Ys0YXF9MmCgeQ7+KWP+9bvL8b0DK0NiUxUKPRubbG 5ONw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VLtJqd9n8iEGWWWwFYJk44IhKuekuFlbjkOOSjbK4Ug=; b=Q7B39cVfS0vwCx3Zntnn9BBFMyxR1B1juIpJ4xUzEfbZ563cPVsZVGPsBU2zhWIjAR sXQ0yGC5fGKz+R1Q1wvpCQFOix7NqoGwUaJ2WQYzYx+zYuoJ4+Q8GTBGCjHzer3cJA22 Nk484F0dnOSnTYvdMLSid/CA/li+FYyXtxGad+9r21ev5Y5en6p7ivvm6lS+ZOeVd8Oy +RdQc3ndutZVb3URswFPv+fziYtfwhCqTK1UG6zNmBG+5xUeZB4NqXaXSIzuj/9VfzMh lTXEN32eplOKZ1efFIA7oXSK212Sp/Dl4m697HfSbzyLvA0FDCLpvkN8YNrEuB0JrAEj ZbEw== X-Gm-Message-State: APjAAAVI2J4CO2RC+RXU+5Ci8wrvzKB9onVUVsdAmrlxpRn214QkFQZa kbB+dWRpMKhw5nweZ8S/gkA= X-Google-Smtp-Source: APXvYqyRExhBqqvbAcTEoPhTfbxzuj7kgwI599mLqXvMCeAtJ/7luyFkKBpeGBOzIDDLGas1DcH8rw== X-Received: by 2002:a05:6512:3ac:: with SMTP id v12mr496446lfp.205.1579840134560; Thu, 23 Jan 2020 20:28:54 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id e20sm2302728ljl.59.2020.01.23.20.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 20:28:54 -0800 (PST) Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-6-git-send-email-spujar@nvidia.com> <5ed7482e-e874-9e11-c84e-7418e4b5162e@gmail.com> From: Dmitry Osipenko Message-ID: <37669247-daaf-c6cb-0ef2-464e61db9838@gmail.com> Date: Fri, 24 Jan 2020 07:28:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 24.01.2020 06:39, Sameer Pujar пишет: >>> +static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, >>> +                                  struct snd_ctl_elem_value *uctl) >>> +{ >>> +     struct snd_soc_component *cmpnt = >>> snd_soc_dapm_kcontrol_component(kctl); >>> +     struct tegra_ahub *ahub = snd_soc_component_get_drvdata(cmpnt); >>> +     struct snd_soc_dapm_context *dapm = >>> snd_soc_dapm_kcontrol_dapm(kctl); >>> +     struct soc_enum *e = (struct soc_enum *)kctl->private_value; >>> +     struct snd_soc_dapm_update update[TEGRA_XBAR_UPDATE_MAX_REG] = >>> { }; >> Shouldn't this be {0} to make array zero'ed? > > Isn't it the same with empty braces? Looks like is should be the same because turns out GCC has an extension for that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F6FC2D0CE for ; Fri, 24 Jan 2020 04:29:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5D132071A for ; Fri, 24 Jan 2020 04:29:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="r836QliY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b7VL69Al" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5D132071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1BA39166B; Fri, 24 Jan 2020 05:29:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1BA39166B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579840193; bh=smQfODvTpLoo2t2yrgpaE3XV2DHm8BXcs1EBN1nWUqw=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r836QliY/XYO3YHMTeh76lSePDDP2KVI3IMPe2cjnDLelJhyrxqWxxo4c7+Cx7Xal VMhVIY0nJp24ayM8LJ4yPD1ypCbRVHffqbOo5GVu1ZV5JQtQLwomAHY3rDIxx6wbB/ qFcqyWhontx6hrc/cm3zsr8BVcQJaNaXI98KkciA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 895C8F801D8; Fri, 24 Jan 2020 05:29:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C0EA2F8020C; Fri, 24 Jan 2020 05:28:58 +0100 (CET) Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9CEF9F800BA for ; Fri, 24 Jan 2020 05:28:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9CEF9F800BA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b7VL69Al" Received: by mail-lf1-x143.google.com with SMTP id n25so309056lfl.0 for ; Thu, 23 Jan 2020 20:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VLtJqd9n8iEGWWWwFYJk44IhKuekuFlbjkOOSjbK4Ug=; b=b7VL69Al4Q3TfIx5Glo4Lk/mg/RMvnYyJKH/l2Yzy5Oex07mnDpixdToqeCBQaoAWK B9nzH8IJcDmQd26XXA66TJkZfV7/u9aW1PcLZlg43tTjKlDt7O6av3JfuZa8oW+kOZbT PiSjuNcQh+X8/rsAroz+7FMrjT+mrpQBUdUGUxR4QvetWX9Z5OW+6b0vIZoky9V0BvZh 14IHMkUS21cds/eS9GcYG3UndNtA+LoWyAnB9lw4IHvNJDW188GKTHaJ58/0Z8bY4J0L 7o1xo3iI45c56/LRLxwcXsTcoo1Ys0YXF9MmCgeQ7+KWP+9bvL8b0DK0NiUxUKPRubbG 5ONw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VLtJqd9n8iEGWWWwFYJk44IhKuekuFlbjkOOSjbK4Ug=; b=dLEaouaIiN/IwN2qTiOoR7wORTyp/Tgwa2yGIuBLssDx9D9JmQiYRoL7uu6mp1tgRe AjbtE1FFREnVtURgc4dNJfd1jugg02c/nJAkzaOB7cmw3WcqbB+K8YN0dpuBP+2S+3e0 IVsD9QHCIOB0rGxNnF5pN5YteTpT60BWylwAt8oXB558Xn88l8KuEog1NgsFXBC8dG/S XRAat0AisJ1foe6ubVRFWgWZQbFjCmn29zk06tn1yrsrdDKDjzgwBqODdy7i8c9kG3Ym 1xoCTuKEzMB39IOVSSuCoLLQNy1BSmrhtFqnSvGMd7/rgyrgB4mh5PAINmc3r9IGYer4 wBUg== X-Gm-Message-State: APjAAAXQiYst1JGRF118uCOS7xGuI0XU9JJSr/P9ieD3B9+KyJbqSf00 8hE/Go66WJhwuTC9GhZRi48= X-Google-Smtp-Source: APXvYqyRExhBqqvbAcTEoPhTfbxzuj7kgwI599mLqXvMCeAtJ/7luyFkKBpeGBOzIDDLGas1DcH8rw== X-Received: by 2002:a05:6512:3ac:: with SMTP id v12mr496446lfp.205.1579840134560; Thu, 23 Jan 2020 20:28:54 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id e20sm2302728ljl.59.2020.01.23.20.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 20:28:54 -0800 (PST) To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-6-git-send-email-spujar@nvidia.com> <5ed7482e-e874-9e11-c84e-7418e4b5162e@gmail.com> From: Dmitry Osipenko Message-ID: <37669247-daaf-c6cb-0ef2-464e61db9838@gmail.com> Date: Fri, 24 Jan 2020 07:28:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MjQuMDEuMjAyMCAwNjozOSwgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6Cj4+PiArc3RhdGljIGlu dCB0ZWdyYV9haHViX3B1dF92YWx1ZV9lbnVtKHN0cnVjdCBzbmRfa2NvbnRyb2wgKmtjdGwsCj4+ PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHN0cnVjdCBzbmRfY3RsX2VsZW1fdmFsdWUgKnVjdGwpCj4+PiArewo+Pj4g K8KgwqDCoMKgIHN0cnVjdCBzbmRfc29jX2NvbXBvbmVudCAqY21wbnQgPQo+Pj4gc25kX3NvY19k YXBtX2tjb250cm9sX2NvbXBvbmVudChrY3RsKTsKPj4+ICvCoMKgwqDCoCBzdHJ1Y3QgdGVncmFf YWh1YiAqYWh1YiA9IHNuZF9zb2NfY29tcG9uZW50X2dldF9kcnZkYXRhKGNtcG50KTsKPj4+ICvC oMKgwqDCoCBzdHJ1Y3Qgc25kX3NvY19kYXBtX2NvbnRleHQgKmRhcG0gPQo+Pj4gc25kX3NvY19k YXBtX2tjb250cm9sX2RhcG0oa2N0bCk7Cj4+PiArwqDCoMKgwqAgc3RydWN0IHNvY19lbnVtICpl ID0gKHN0cnVjdCBzb2NfZW51bSAqKWtjdGwtPnByaXZhdGVfdmFsdWU7Cj4+PiArwqDCoMKgwqAg c3RydWN0IHNuZF9zb2NfZGFwbV91cGRhdGUgdXBkYXRlW1RFR1JBX1hCQVJfVVBEQVRFX01BWF9S RUddID0KPj4+IHsgfTsKPj4gU2hvdWxkbid0IHRoaXMgYmUgezB9IHRvIG1ha2UgYXJyYXkgemVy bydlZD8KPiAKPiBJc24ndCBpdCB0aGUgc2FtZSB3aXRoIGVtcHR5IGJyYWNlcz8KCkxvb2tzIGxp a2UgaXMgc2hvdWxkIGJlIHRoZSBzYW1lIGJlY2F1c2UgdHVybnMgb3V0IEdDQyBoYXMgYW4gZXh0 ZW5zaW9uCmZvciB0aGF0LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5v cmcKaHR0cHM6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNh LWRldmVsCg==