From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE Date: Sun, 28 May 2017 16:20:03 +0200 Message-ID: <376de2ec-c557-8541-9480-66472bd153a5@linaro.org> References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Linus Walleij Cc: Mark Rutland , "open list:RALINK MIPS ARCHITECTURE" , Baruch Siach , Heiko Stuebner , Neil Armstrong , Santosh Shilimkar , Liviu Dudau , "moderated list:ARM/OXNAS platform support" , Patrice Chotard , Eric Anholt , Thierry Reding , Ingo Molnar , "open list:ARM/STI ARCHITECTURE" , Alexandre Courbot , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Florian Fainelli , "moderated list:H8/300 ARCHITECTURE" , Alexander Shiyan , open list:ARM/Rockchip So List-Id: linux-tegra@vger.kernel.org T24gMjgvMDUvMjAxNyAxNTo0OCwgTGludXMgV2FsbGVpaiB3cm90ZToKPiBPbiBTYXQsIE1heSAy NywgMjAxNyBhdCAxMTo1OCBBTSwgRGFuaWVsIExlemNhbm8KPiA8ZGFuaWVsLmxlemNhbm9AbGlu YXJvLm9yZz4gd3JvdGU6Cj4gCj4+IFRoZSBDTE9DS1NPVUNFX09GX0RFQ0xBUkUgbWFjcm8gaXMg dXNlZCB3aWRlbHkgZm9yIHRoZSB0aW1lcnMgdG8gZGVjbGFyZSB0aGUKPj4gY2xvY2tzb3VyY2Ug YXQgZWFybHkgc3RhZ2UuIEhvd2V2ZXIsIHRoaXMgbWFjcm8gaXMgYWxzbyB1c2VkIHRvIGluaXRp YWxpemUKPj4gdGhlIGNsb2NrZXZlbnQgaWYgYW55LCBvciB0aGUgY2xvY2tldmVudCBvbmx5Lgo+ Pgo+PiBJdCB3YXMgb3JpZ2luYWxseSBzdWdnZXN0ZWQgdG8gZGVjbGFyZSBhbm90aGVyIG1hY3Jv IHRvIGluaXRpYWxpemUgYQo+PiBjbG9ja2V2ZW50LCBzbyBpbiBvcmRlciB0byBzZXBhcmF0ZSB0 aGUgdHdvIGVudGl0aWVzIGV2ZW4gdGhleSBiZWxvbmcgdG8gdGhlCj4+IHNhbWUgSVAuIFRoaXMg d2FzIG5vdCBhY2NlcHRlZCBiZWNhdXNlIG9mIHRoZSBpbXBhY3Qgb24gdGhlIERUIHdoZXJlIHNw bGl0dGluZwo+PiBhIGNsb2Nrc291cmNlL2Nsb2NrZXZlbnQgZGVmaW5pdGlvbiBkb2VzIG5vdCBt YWtlIHNlbnNlIGFzIGl0IGlzIGEgTGludXgKPj4gY29uY2VwdCBub3QgYSBoYXJkd2FyZSBkZXNj cmlwdGlvbi4KPj4KPj4gT24gdGhlIG90aGVyIHNpZGUsIHRoZSBjbG9ja3NvdXJjZSBoYXMgbm90 IGludGVycnVwdCBkZWNsYXJlZCB3aGlsZSB0aGUKPj4gY2xvY2tldmVudCBoYXMsIHNvIGl0IGlz IGVhc3kgZnJvbSB0aGUgZHJpdmVyIHRvIGtub3cgaWYgdGhlIGRlc2NyaXB0aW9uIGlzCj4+IGZv ciBhIGNsb2NrZXZlbnQgb3IgYSBjbG9ja3NvdXJjZSwgSU9XIGl0IGNvdWxkIGJlIGltcGxlbWVu dGVkIGF0IHRoZSBkcml2ZXIKPj4gbGV2ZWwuCj4+Cj4+IFNvIGluc3RlYWQgb2YgZGVhbGluZyB3 aXRoIGEgbmFtZWQgY2xvY2tzb3VyY2UgbWFjcm8sIGxldCdzIHVzZSBhIG1vcmUgZ2VuZXJpYwo+ PiBvbmU6IFRJTUVSX09GX0RFQ0xBUkUuCj4+Cj4+IFRoZSBwYXRjaCBoYXMgbm90IGZ1bmN0aW9u YWwgY2hhbmdlcy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIExlemNhbm8gPGRhbmllbC5s ZXpjYW5vQGxpbmFyby5vcmc+Jwo+IAo+IFRoaXMgbWFrZXMgdGhlIG1hY3JvIG1ha2Ugc2Vuc2Ug YW5kIEkgaGFkIHRoaXMgaWRlYSBvbmUgdGltZSB0b28uCj4gQXdlc29tZS4KPiBSZXZpZXdlZC1i eTogTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgpUaGFua3MgTGludXMg Zm9yIHJldmlld2luZyB0aGUgc2VyaWVzLgoKICAtLSBEYW5pZWwKCi0tIAogPGh0dHA6Ly93d3cu bGluYXJvLm9yZy8+IExpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0g U29DcwoKRm9sbG93IExpbmFybzogIDxodHRwOi8vd3d3LmZhY2Vib29rLmNvbS9wYWdlcy9MaW5h cm8+IEZhY2Vib29rIHwKPGh0dHA6Ly90d2l0dGVyLmNvbS8jIS9saW5hcm9vcmc+IFR3aXR0ZXIg fAo8aHR0cDovL3d3dy5saW5hcm8ub3JnL2xpbmFyby1ibG9nLz4gQmxvZwoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXNucHMtYXJjIG1haWxp bmcgbGlzdApsaW51eC1zbnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtc25wcy1hcmM= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 28 May 2017 16:20:25 +0200 (CEST) Received: from mail-wm0-x22e.google.com ([IPv6:2a00:1450:400c:c09::22e]:36363 "EHLO mail-wm0-x22e.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993913AbdE1OURKlAHB (ORCPT ); Sun, 28 May 2017 16:20:17 +0200 Received: by mail-wm0-x22e.google.com with SMTP id 7so27642579wmo.1 for ; Sun, 28 May 2017 07:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0CysKYRzxbmKXESMb/CwE5c8iUi7OocNNIr72tREMEw=; b=QWjMs5PJ454PFzELtga+RnIoopp+zB0E1tDRFih8IKvaphr8xI6NpMstQNFAhHHSL0 PS3gwE4GKy9kuHxYB9Z1FJ/zKx1BCuORRP8tIChSkBgekXKtM/52FPrXTR5V9nAf9G7B 4LrmuMxJSeRsNFBcNCx9Zbedy+XAkVgZy2MuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0CysKYRzxbmKXESMb/CwE5c8iUi7OocNNIr72tREMEw=; b=H6+5ke/dBa8+GJpgmzenisaOmKPxJLalp+EYZAe3lYfC8iqA3if7UOKybryC2oUDAc /ti9O537Nh3indRF0FtSNV0BlE9ZAmw3B7UqsZaXqaH5G6LhCw+NSuqcVlR/kj7Au/DC MnXwpxoSgvWd+fJPx2M1aGf3VAVC+//z7wDsUNJgNVhQPQHiBUrA8GTebIwfLjiDsbWF c9AbYvR1onSM2yIBnSKjn359Py/BPj1wg7dv72LjRd4YjLQGFc0ZY9ahv31pFdsONQOf 4o/zMDpp0reZjb964bem+jeJLD/v5xpx9HzOmS80COpiySXnSTVk6GkeuuSiaMPFYwMq Vkzg== X-Gm-Message-State: AODbwcAVIbagbGnI65JDQPoBYOPYhAPwI+DUq2EyJ7s5eVzF4TIablKV SfMRkhHnhOFuVkzX X-Received: by 10.28.133.78 with SMTP id h75mr20557961wmd.81.1495981211735; Sun, 28 May 2017 07:20:11 -0700 (PDT) Received: from [192.168.0.40] (sju31-1-78-210-255-2.fbx.proxad.net. [78.210.255.2]) by smtp.googlemail.com with ESMTPSA id c8sm6662527wmd.5.2017.05.28.07.20.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 May 2017 07:20:09 -0700 (PDT) Subject: Re: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE To: Linus Walleij Cc: Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Russell King , Michal Simek , John Crispin , Ralf Baechle , Ley Foon Tan , Vineet Gupta , Mark Rutland , Marc Zyngier , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Florian Fainelli , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Stephen Warren , Lee Jones , Eric Anholt , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Alexander Shiyan , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Yoshinori Sato , Carlo Caione , Kevin Hilman , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Matthias Brugger , Heiko Stuebner , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Thierry Reding , Alexandre Courbot , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Joachim Eastwood , Vladimir Zapolskiy , Sylvain Lemieux , Barry Song , Baruch Siach , Santosh Shilimkar , Neil Armstrong , Tony Prisk , John Stultz , Stephen Boyd , Anna-Maria Gleixner , Richard Cochran , Ingo Molnar , Noam Camus , Arnd Bergmann , "open list:RALINK MIPS ARCHITECTURE" , "moderated list:NIOS2 ARCHITECTURE" , "open list:SYNOPSYS ARC ARCHITECTURE" , "open list:ARM/STI ARCHITECTURE" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , "moderated list:H8/300 ARCHITECTURE" , "open list:ARM/Amlogic Meson SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/Rockchip SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/OXNAS platform support" References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> From: Daniel Lezcano Message-ID: <376de2ec-c557-8541-9480-66472bd153a5@linaro.org> Date: Sun, 28 May 2017 16:20:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 58038 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: daniel.lezcano@linaro.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 28/05/2017 15:48, Linus Walleij wrote: > On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano > wrote: > >> The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the >> clocksource at early stage. However, this macro is also used to initialize >> the clockevent if any, or the clockevent only. >> >> It was originally suggested to declare another macro to initialize a >> clockevent, so in order to separate the two entities even they belong to the >> same IP. This was not accepted because of the impact on the DT where splitting >> a clocksource/clockevent definition does not make sense as it is a Linux >> concept not a hardware description. >> >> On the other side, the clocksource has not interrupt declared while the >> clockevent has, so it is easy from the driver to know if the description is >> for a clockevent or a clocksource, IOW it could be implemented at the driver >> level. >> >> So instead of dealing with a named clocksource macro, let's use a more generic >> one: TIMER_OF_DECLARE. >> >> The patch has not functional changes. >> >> Signed-off-by: Daniel Lezcano ' > > This makes the macro make sense and I had this idea one time too. > Awesome. > Reviewed-by: Linus Walleij Thanks Linus for reviewing the series. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Sun, 28 May 2017 16:20:03 +0200 Subject: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE In-Reply-To: References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> List-ID: Message-ID: <376de2ec-c557-8541-9480-66472bd153a5@linaro.org> To: linux-snps-arc@lists.infradead.org On 28/05/2017 15:48, Linus Walleij wrote: > On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano > wrote: > >> The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the >> clocksource at early stage. However, this macro is also used to initialize >> the clockevent if any, or the clockevent only. >> >> It was originally suggested to declare another macro to initialize a >> clockevent, so in order to separate the two entities even they belong to the >> same IP. This was not accepted because of the impact on the DT where splitting >> a clocksource/clockevent definition does not make sense as it is a Linux >> concept not a hardware description. >> >> On the other side, the clocksource has not interrupt declared while the >> clockevent has, so it is easy from the driver to know if the description is >> for a clockevent or a clocksource, IOW it could be implemented at the driver >> level. >> >> So instead of dealing with a named clocksource macro, let's use a more generic >> one: TIMER_OF_DECLARE. >> >> The patch has not functional changes. >> >> Signed-off-by: Daniel Lezcano ' > > This makes the macro make sense and I had this idea one time too. > Awesome. > Reviewed-by: Linus Walleij Thanks Linus for reviewing the series. -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Sun, 28 May 2017 16:20:03 +0200 Subject: [PATCH 2/7] clocksource: Rename CLOCKSOURCE_OF_DECLARE In-Reply-To: References: <1495879129-28109-1-git-send-email-daniel.lezcano@linaro.org> <1495879129-28109-2-git-send-email-daniel.lezcano@linaro.org> Message-ID: <376de2ec-c557-8541-9480-66472bd153a5@linaro.org> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 28/05/2017 15:48, Linus Walleij wrote: > On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano > wrote: > >> The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the >> clocksource at early stage. However, this macro is also used to initialize >> the clockevent if any, or the clockevent only. >> >> It was originally suggested to declare another macro to initialize a >> clockevent, so in order to separate the two entities even they belong to the >> same IP. This was not accepted because of the impact on the DT where splitting >> a clocksource/clockevent definition does not make sense as it is a Linux >> concept not a hardware description. >> >> On the other side, the clocksource has not interrupt declared while the >> clockevent has, so it is easy from the driver to know if the description is >> for a clockevent or a clocksource, IOW it could be implemented at the driver >> level. >> >> So instead of dealing with a named clocksource macro, let's use a more generic >> one: TIMER_OF_DECLARE. >> >> The patch has not functional changes. >> >> Signed-off-by: Daniel Lezcano ' > > This makes the macro make sense and I had this idea one time too. > Awesome. > Reviewed-by: Linus Walleij Thanks Linus for reviewing the series. -- Daniel -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog