From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 10/16] x86/PV: split out dealing with CRn from privileged instruction handling Date: Thu, 29 Sep 2016 21:01:45 +0100 Message-ID: <3770e473-dbf3-ebf6-5736-24ae8c5e7468@citrix.com> References: <57EB94940200007800113179@prv-mh.provo.novell.com> <57EB980202000078001131D3@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bphX9-0005E3-JE for xen-devel@lists.xenproject.org; Thu, 29 Sep 2016 20:02:19 +0000 In-Reply-To: <57EB980202000078001131D3@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org T24gMjgvMDkvMTYgMDk6MTQsIEphbiBCZXVsaWNoIHdyb3RlOgo+IFRoaXMgaXMgaW4gcHJlcGFy YXRpb24gZm9yIHVzaW5nIHRoZSBnZW5lcmljIGVtdWxhdG9yIGhlcmUuCj4KPiBTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+Cj4KPiAtLS0gYS94ZW4vYXJjaC94 ODYvdHJhcHMuYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5jCj4gQEAgLTIyNTUsNiArMjI1 NSwxMDcgQEAgdW5zaWduZWQgbG9uZyBndWVzdF90b19ob3N0X2dwcl9zd2l0Y2godQo+ICAKPiAg dm9pZCAoKnB2X3Bvc3Rfb3V0Yl9ob29rKSh1bnNpZ25lZCBpbnQgcG9ydCwgdTggdmFsdWUpOwo+ ICAKPiArc3RhdGljIGludCBwcml2X29wX3JlYWRfY3IodW5zaWduZWQgaW50IHJlZywgdW5zaWdu ZWQgbG9uZyAqdmFsLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgeDg2X2Vt dWxhdGVfY3R4dCAqY3R4dCkKPiArewo+ICsgICAgY29uc3Qgc3RydWN0IHZjcHUgKmN1cnIgPSBj dXJyZW50Owo+ICsKPiArICAgIHN3aXRjaCAoIHJlZyApCj4gKyAgICB7Cj4gKyAgICBjYXNlIDA6 IC8qIFJlYWQgQ1IwICovCj4gKyAgICAgICAgKnZhbCA9IChyZWFkX2NyMCgpICYgflg4Nl9DUjBf VFMpIHwgY3Vyci0+YXJjaC5wdl92Y3B1LmN0cmxyZWdbMF07Cj4gKyAgICAgICAgcmV0dXJuIFg4 NkVNVUxfT0tBWTsKPiArCj4gKyAgICBjYXNlIDI6IC8qIFJlYWQgQ1IyICovCj4gKyAgICBjYXNl IDQ6IC8qIFJlYWQgQ1I0ICovCj4gKyAgICAgICAgKnZhbCA9IGN1cnItPmFyY2gucHZfdmNwdS5j dHJscmVnW3JlZ107Cj4gKyAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsKPiArCj4gKyAgICBj YXNlIDM6IC8qIFJlYWQgQ1IzICovCj4gKyAgICB7Cj4gKyAgICAgICAgY29uc3Qgc3RydWN0IGRv bWFpbiAqY3VycmQgPSBjdXJyLT5kb21haW47Cj4gKyAgICAgICAgdW5zaWduZWQgbG9uZyBtZm47 CgpBbnkgY2hhbmNlIG9mIHN3aXRjaGluZyB0aGlzIHRvIG1mbl90IHdoaWxlIHlvdSBhcmUgbW92 aW5nIGl0PwoKPiArCj4gKyAgICAgICAgaWYgKCAhaXNfcHZfMzJiaXRfZG9tYWluKGN1cnJkKSAp Cj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBtZm4gPSBwYWdldGFibGVfZ2V0X3BmbihjdXJy LT5hcmNoLmd1ZXN0X3RhYmxlKTsKPiArICAgICAgICAgICAgKnZhbCA9IHhlbl9wZm5fdG9fY3Iz KG1mbl90b19nbWZuKGN1cnJkLCBtZm4pKTsKPiArICAgICAgICB9Cj4gKyAgICAgICAgZWxzZQo+ ICsgICAgICAgIHsKPiArICAgICAgICAgICAgbDRfcGdlbnRyeV90ICpwbDRlID0KPiArICAgICAg ICAgICAgICAgIG1hcF9kb21haW5fcGFnZShfbWZuKHBhZ2V0YWJsZV9nZXRfcGZuKGN1cnItPmFy Y2guZ3Vlc3RfdGFibGUpKSk7Cj4gKwo+ICsgICAgICAgICAgICBtZm4gPSBsNGVfZ2V0X3Bmbigq cGw0ZSk7Cj4gKyAgICAgICAgICAgIHVubWFwX2RvbWFpbl9wYWdlKHBsNGUpOwo+ICsgICAgICAg ICAgICAqdmFsID0gY29tcGF0X3Bmbl90b19jcjMobWZuX3RvX2dtZm4oY3VycmQsIG1mbikpOwo+ ICsgICAgICAgIH0KPiArICAgICAgICAvKiBQVHMgc2hvdWxkIG5vdCBiZSBzaGFyZWQgKi8KPiAr ICAgICAgICBCVUdfT04ocGFnZV9nZXRfb3duZXIobWZuX3RvX3BhZ2UobWZuKSkgPT0gZG9tX2Nv dyk7Cj4gKyAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsKPiArICAgIH0KPiArICAgIH0KPiAr Cj4gKyAgICByZXR1cm4gWDg2RU1VTF9VTkhBTkRMRUFCTEU7Cj4gK30KPiArCj4gK3N0YXRpYyBp bnQgcHJpdl9vcF93cml0ZV9jcih1bnNpZ25lZCBpbnQgcmVnLCB1bnNpZ25lZCBsb25nIHZhbCwK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB4ODZfZW11bGF0ZV9jdHh0ICpj dHh0KQo+ICt7Cj4gKyAgICBzdHJ1Y3QgdmNwdSAqY3VyciA9IGN1cnJlbnQ7Cj4gKwo+ICsgICAg c3dpdGNoICggcmVnICkKPiArICAgIHsKPiArICAgIGNhc2UgMDogLyogV3JpdGUgQ1IwICovCj4g KyAgICAgICAgaWYgKCAodmFsIF4gcmVhZF9jcjAoKSkgJiB+WDg2X0NSMF9UUyApCj4gKyAgICAg ICAgewo+ICsgICAgICAgICAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywKPiArICAgICAgICAg ICAgICAgICAgICAiQXR0ZW1wdCB0byBjaGFuZ2UgdW5tb2RpZmlhYmxlIENSMCBmbGFnc1xuIik7 Cj4gKyAgICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgIH0KPiArICAgICAgICBkb19mcHVfdGFz a3N3aXRjaCghISh2YWwgJiBYODZfQ1IwX1RTKSk7Cj4gKyAgICAgICAgcmV0dXJuIFg4NkVNVUxf T0tBWTsKPiArCj4gKyAgICBjYXNlIDI6IC8qIFdyaXRlIENSMiAqLwo+ICsgICAgICAgIGN1cnIt PmFyY2gucHZfdmNwdS5jdHJscmVnWzJdID0gdmFsOwo+ICsgICAgICAgIGFyY2hfc2V0X2NyMihj dXJyLCB2YWwpOwo+ICsgICAgICAgIHJldHVybiBYODZFTVVMX09LQVk7Cj4gKwo+ICsgICAgY2Fz ZSAzOiAvKiBXcml0ZSBDUjMgKi8KPiArICAgIHsKPiArICAgICAgICBzdHJ1Y3QgZG9tYWluICpj dXJyZCA9IGN1cnItPmRvbWFpbjsKPiArICAgICAgICB1bnNpZ25lZCBsb25nIGdmbjsKClNpbWls YXJseSwgZ2ZuX3QgPwoKUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBz Oi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK