From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933236AbdEROz0 (ORCPT ); Thu, 18 May 2017 10:55:26 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:56425 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933085AbdEROzW (ORCPT ); Thu, 18 May 2017 10:55:22 -0400 From: Laurent Pinchart To: Archit Taneja Cc: Eric Anholt , Rob Herring , dri-devel , Thierry Reding , Mark Rutland , Andrzej Hajda , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/4] dt-bindings: Document the Raspberry Pi Touchscreen nodes. Date: Thu, 18 May 2017 17:55:25 +0300 Message-ID: <3771766.1sVmoPRjsn@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: References: <20170511235625.22427-1-eric@anholt.net> <87shk4iqr7.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Archit, On Thursday 18 May 2017 13:56:19 Archit Taneja wrote: > On 05/17/2017 12:16 AM, Eric Anholt wrote: [snip] > > In terms of physical connections: > > [15-pin "DSI" connector on 2835] > > > > | I2C | DSI > > > > / \ SPI | > > > > [TS] [Atmel]------[TC358762] > > > > \ | > > > > \PWM | > > > > \ | DPI > > > > [some backlight]------[some unknown panel] > > > > The binding I'm trying to create is to expose what's necessary for a > > driver that talks I2C to the Atmel, which then controls the PWM and does > > the command sequence over SPI to the Toshiba that sets up its end of the > > DSI link. > > The bridge (Atmel + TC358762 combination) here looks like it's primarily > an i2c device (i.e, the control bus is i2c). Therefore, the drm-bridge > driver here should be an i2c driver instead of a mipi_dsi_driver. Glad to see we agree, that's what I've proposed in a separate answer :-) I'd go one step further though, there should be no DRM bridge, just a DRM panel. > We have the facility to create a mipi DSI device without the need to have > a corresponding node in DT. The ADV7533 and TC358767 drivers are examples > of that. > > The following is what the binding could look like, it's same as what Rob > also mentioned previously in the thread. > > Thanks, > Archit > > dsi1: dsi@7e700000 { > #address-cells = <1>; > #size-cells = <0>; > <...> > > /* The SoC's DSI input/output port */ > ports { > #address-cells = <1>; > #size-cells = <0>; > > /* port@0 if needed */ > > port@1 { > dsi_out_port: endpoint { > reg = <1>; > remote-endpoint = <&bridge_dsi_port>; > }; > }; > }; > }; > > i2c_dsi: i2c { > compatible = "i2c-gpio"; > #address-cells = <1>; > #size-cells = <0>; > gpios = <&gpio 28 0 > &gpio 29 0>; > > /* the Atmel + TC35872 bridge */ > pitouchscreen_bridge: bridge@45 { This should thus be lcd@45. > compatible = "raspberrypi,touchscreen-bridge"; And this raspberrypi,7inch-touchscreen-panel. Shame we haven't standardized the vendor name prefix to rpi :-/ > reg = <0x45>; > > ports { > #address-cells = <1>; > #size-cells = <0>; > > port@0 { > reg = <0>; > bridge_dsi_port: endpoint { This should be named panel_dsi_port. > remote-endpoint = <&dsi_out_port>; > }; > }; > port@1 { > reg = <1>; > bridge_dpi_port: endpoint { > remote-endpoint = <&pitouchscreen_panel_port>; > }; > }; The second port is thus not needed. > }; So we can simplify this to port { panel_dsi_port: endpoint { remote-endpoint = <&dsi_out_port>; }; }; (no need for a ports node when there's a single port) > }; > }; > > lcd { > compatible = "raspberrypi,7inch-touchscreen-panel"; > ports { > #address-cells = <1>; > #size-cells = <0>; > port@0 { > reg = <0>; > pitouchscreen_panel_port: endpoint { > remote-endpoint = <&bridge_dpi_port>; > }; > }; > }; > }; And this node can go away. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/4] dt-bindings: Document the Raspberry Pi Touchscreen nodes. Date: Thu, 18 May 2017 17:55:25 +0300 Message-ID: <3771766.1sVmoPRjsn@avalon> References: <20170511235625.22427-1-eric@anholt.net> <87shk4iqr7.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dri-devel , Rob Herring List-Id: devicetree@vger.kernel.org SGkgQXJjaGl0LAoKT24gVGh1cnNkYXkgMTggTWF5IDIwMTcgMTM6NTY6MTkgQXJjaGl0IFRhbmVq YSB3cm90ZToKPiBPbiAwNS8xNy8yMDE3IDEyOjE2IEFNLCBFcmljIEFuaG9sdCB3cm90ZToKCltz bmlwXQoKPiA+IEluIHRlcm1zIG9mIHBoeXNpY2FsIGNvbm5lY3Rpb25zOgo+ID4gICAgWzE1LXBp biAiRFNJIiBjb25uZWN0b3Igb24gMjgzNV0KPiA+ICAgIAo+ID4gICAgIHwgSTJDICAgICAgICAg ICAgICAgfCBEU0kKPiA+ICAgIAo+ID4gICAgLyBcICAgICAgICBTUEkgICAgICAgfAo+ID4gCj4g PiBbVFNdICBbQXRtZWxdLS0tLS0tW1RDMzU4NzYyXQo+ID4gCj4gPiAgICAgICAgXCAgICAgICAg ICAgICAgICB8Cj4gPiAgICAgICAgCj4gPiAgICAgICAgIFxQV00gICAgICAgICAgICB8Cj4gPiAg ICAgICAgIAo+ID4gICAgICAgICAgXCAgICAgICAgICAgICAgfCBEUEkKPiA+IAo+ID4gW3NvbWUg YmFja2xpZ2h0XS0tLS0tLVtzb21lIHVua25vd24gcGFuZWxdCj4gPiAKPiA+IFRoZSBiaW5kaW5n IEknbSB0cnlpbmcgdG8gY3JlYXRlIGlzIHRvIGV4cG9zZSB3aGF0J3MgbmVjZXNzYXJ5IGZvciBh Cj4gPiBkcml2ZXIgdGhhdCB0YWxrcyBJMkMgdG8gdGhlIEF0bWVsLCB3aGljaCB0aGVuIGNvbnRy b2xzIHRoZSBQV00gYW5kIGRvZXMKPiA+IHRoZSBjb21tYW5kIHNlcXVlbmNlIG92ZXIgU1BJIHRv IHRoZSBUb3NoaWJhIHRoYXQgc2V0cyB1cCBpdHMgZW5kIG9mIHRoZQo+ID4gRFNJIGxpbmsuCj4g Cj4gVGhlIGJyaWRnZSAoQXRtZWwgKyBUQzM1ODc2MiBjb21iaW5hdGlvbikgaGVyZSBsb29rcyBs aWtlIGl0J3MgcHJpbWFyaWx5Cj4gYW4gaTJjIGRldmljZSAoaS5lLCB0aGUgY29udHJvbCBidXMg aXMgaTJjKS4gVGhlcmVmb3JlLCB0aGUgZHJtLWJyaWRnZQo+IGRyaXZlciBoZXJlIHNob3VsZCBi ZSBhbiBpMmMgZHJpdmVyIGluc3RlYWQgb2YgYSBtaXBpX2RzaV9kcml2ZXIuCgpHbGFkIHRvIHNl ZSB3ZSBhZ3JlZSwgdGhhdCdzIHdoYXQgSSd2ZSBwcm9wb3NlZCBpbiBhIHNlcGFyYXRlIGFuc3dl ciA6LSkgSSdkIApnbyBvbmUgc3RlcCBmdXJ0aGVyIHRob3VnaCwgdGhlcmUgc2hvdWxkIGJlIG5v IERSTSBicmlkZ2UsIGp1c3QgYSBEUk0gcGFuZWwuCgo+IFdlIGhhdmUgdGhlIGZhY2lsaXR5IHRv IGNyZWF0ZSBhIG1pcGkgRFNJIGRldmljZSB3aXRob3V0IHRoZSBuZWVkIHRvIGhhdmUKPiBhIGNv cnJlc3BvbmRpbmcgbm9kZSBpbiBEVC4gVGhlIEFEVjc1MzMgYW5kIFRDMzU4NzY3IGRyaXZlcnMg YXJlIGV4YW1wbGVzCj4gb2YgdGhhdC4KPiAKPiBUaGUgZm9sbG93aW5nIGlzIHdoYXQgdGhlIGJp bmRpbmcgY291bGQgbG9vayBsaWtlLCBpdCdzIHNhbWUgYXMgd2hhdCBSb2IKPiBhbHNvIG1lbnRp b25lZCBwcmV2aW91c2x5IGluIHRoZSB0aHJlYWQuCj4gCj4gVGhhbmtzLAo+IEFyY2hpdAo+IAo+ IGRzaTE6IGRzaUA3ZTcwMDAwMCB7Cj4gCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+IAkjc2l6ZS1j ZWxscyA9IDwwPjsKPiAJPC4uLj4KPiAKPiAJLyogVGhlIFNvQydzIERTSSBpbnB1dC9vdXRwdXQg cG9ydCAqLwo+IAlwb3J0cyB7Cj4gCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiAJCSNzaXplLWNl bGxzID0gPDA+Owo+IAo+IAkJLyogcG9ydEAwIGlmIG5lZWRlZCAqLwo+IAo+IAkJcG9ydEAxIHsK PiAJCQlkc2lfb3V0X3BvcnQ6IGVuZHBvaW50IHsKPiAJCQkJcmVnID0gPDE+Owo+IAkJCQlyZW1v dGUtZW5kcG9pbnQgPSA8JmJyaWRnZV9kc2lfcG9ydD47Cj4gCQkJfTsKPiAJCX07Cj4gCX07Cj4g fTsKPiAKPiBpMmNfZHNpOiBpMmMgewo+IAljb21wYXRpYmxlID0gImkyYy1ncGlvIjsKPiAJI2Fk ZHJlc3MtY2VsbHMgPSA8MT47Cj4gCSNzaXplLWNlbGxzID0gPDA+Owo+IAlncGlvcyA9IDwmZ3Bp byAyOCAwCj4gCQkgJmdwaW8gMjkgMD47Cj4gCj4gCS8qIHRoZSBBdG1lbCArIFRDMzU4NzIgYnJp ZGdlICovCj4gCXBpdG91Y2hzY3JlZW5fYnJpZGdlOiBicmlkZ2VANDUgewoKVGhpcyBzaG91bGQg dGh1cyBiZSBsY2RANDUuCgo+IAkJY29tcGF0aWJsZSA9ICJyYXNwYmVycnlwaSx0b3VjaHNjcmVl bi1icmlkZ2UiOwoKQW5kIHRoaXMgcmFzcGJlcnJ5cGksN2luY2gtdG91Y2hzY3JlZW4tcGFuZWwu IFNoYW1lIHdlIGhhdmVuJ3Qgc3RhbmRhcmRpemVkIAp0aGUgdmVuZG9yIG5hbWUgcHJlZml4IHRv IHJwaSA6LS8KCj4gCQlyZWcgPSA8MHg0NT47Cj4gCj4gCQlwb3J0cyB7Cj4gCQkJI2FkZHJlc3Mt Y2VsbHMgPSA8MT47Cj4gCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gCj4gCQkJcG9ydEAwIHsKPiAJ CQkJcmVnID0gPDA+Owo+IAkJCQlicmlkZ2VfZHNpX3BvcnQ6IGVuZHBvaW50IHsKClRoaXMgc2hv dWxkIGJlIG5hbWVkIHBhbmVsX2RzaV9wb3J0LgoKPiAJCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwm ZHNpX291dF9wb3J0PjsKPiAJCQkJfTsKPiAJCQl9Owo+IAkJCXBvcnRAMSB7Cj4gCQkJCXJlZyA9 IDwxPjsKPiAJCQkJYnJpZGdlX2RwaV9wb3J0OiBlbmRwb2ludCB7Cj4gCQkJCQlyZW1vdGUtZW5k cG9pbnQgPSAKPCZwaXRvdWNoc2NyZWVuX3BhbmVsX3BvcnQ+Owo+IAkJCQl9Owo+IAkJCX07CgpU aGUgc2Vjb25kIHBvcnQgaXMgdGh1cyBub3QgbmVlZGVkLgoKPiAJCX07CgpTbyB3ZSBjYW4gc2lt cGxpZnkgdGhpcyB0bwoKCQlwb3J0IHsKCQkJcGFuZWxfZHNpX3BvcnQ6IGVuZHBvaW50IHsKCQkJ CXJlbW90ZS1lbmRwb2ludCA9IDwmZHNpX291dF9wb3J0PjsKCQkJfTsKCQl9OwoKKG5vIG5lZWQg Zm9yIGEgcG9ydHMgbm9kZSB3aGVuIHRoZXJlJ3MgYSBzaW5nbGUgcG9ydCkKCj4gCX07Cj4gfTsK PiAKPiBsY2Qgewo+IAljb21wYXRpYmxlID0gInJhc3BiZXJyeXBpLDdpbmNoLXRvdWNoc2NyZWVu LXBhbmVsIjsKPiAJcG9ydHMgewo+IAkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gCQkjc2l6ZS1j ZWxscyA9IDwwPjsKPiAJCXBvcnRAMCB7Cj4gCQkJcmVnID0gPDA+Owo+IAkJCXBpdG91Y2hzY3Jl ZW5fcGFuZWxfcG9ydDogZW5kcG9pbnQgewo+IAkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmJyaWRn ZV9kcGlfcG9ydD47Cj4gCQkJfTsKPiAJCX07Cj4gCX07Cj4gfTsKCkFuZCB0aGlzIG5vZGUgY2Fu IGdvIGF3YXkuCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=