From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Villemoes Date: Thu, 9 Jul 2020 21:50:03 +0200 Subject: [PATCH 1/4] fs/squashfs: new filesystem In-Reply-To: <20200709175148.17193-2-joaomarcos.costa@bootlin.com> References: <20200709175148.17193-1-joaomarcos.costa@bootlin.com> <20200709175148.17193-2-joaomarcos.costa@bootlin.com> Message-ID: <377389bc-a9ad-5271-ec1e-3df3c4053ca2@prevas.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/07/2020 19.51, Joao Marcos Costa wrote: > Add support for SquashFS filesystem. Right now, it does not support > compression but support for zlib will be added in a follow-up commit. Cool, thanks for proposing this. While I'm not really in a position to review these, just one comment below. > > +config SPL_FS_SQUASHFS > + bool "Support SquashFS filesystems" > + select FS_SQUASHFS Is there any reason U-Boot proper must support squashfs if the SPL does? This isn't quite specific to this patch; I see a number of 'config SPL_FOO' that either depends on or selects FOO (e.g. SPL_FS_FAT), and I wonder why. Rasmus