From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Stefan Weil" <sw@weilnetz.de>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
luoyonggang@gmail.com, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 5/7] dockerfiles/debian-win64-cross: Download WHPX MinGW headers
Date: Tue, 1 Sep 2020 18:31:44 +0200 [thread overview]
Message-ID: <37748f4a-c362-017e-c2f3-98e282c45eb5@redhat.com> (raw)
In-Reply-To: <20200901162508.GV345480@redhat.com>
On 01/09/2020 18.25, Daniel P. Berrangé wrote:
> On Sun, Aug 23, 2020 at 01:17:55PM +0200, Thomas Huth wrote:
>> To compile-test the WHPX accelerator, we need to download these system
>> headers first (they are unfortunately not part of any released and
>> packaged MinGW toolchain yet).
>>
>> Idea taken from another patch by Stefan Weil.
>>
>> Message-Id: <20200804170055.2851-12-thuth@redhat.com>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/docker/dockerfiles/debian-win64-cross.docker | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>
>>
>> diff --git a/tests/docker/dockerfiles/debian-win64-cross.docker b/tests/docker/dockerfiles/debian-win64-cross.docker
>> index 2fc9cfcbc6..4cc4a3f365 100644
>> --- a/tests/docker/dockerfiles/debian-win64-cross.docker
>> +++ b/tests/docker/dockerfiles/debian-win64-cross.docker
>> @@ -32,7 +32,14 @@ RUN apt-get update && \
>> mxe-$TARGET-w64-mingw32.shared-sdl2 \
>> mxe-$TARGET-w64-mingw32.shared-sdl2-mixer \
>> mxe-$TARGET-w64-mingw32.shared-sdl2-gfx \
>> - mxe-$TARGET-w64-mingw32.shared-zlib
>> + mxe-$TARGET-w64-mingw32.shared-zlib \
>> + curl && \
>> + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/WinHvEmulation.h \
>> + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvemulation.h?format=raw" && \
>> + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/WinHvPlatform.h \
>> + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvplatform.h?format=raw" && \
>> + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/winhvplatformdefs.h \
>> + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvplatformdefs.h?format=raw"
>
> My only concern here is whether sourceforge.net URLs are reliable enough
> for CI, or whether we should instead be mirroring the w64 repo on
> git.qemu.org ?
>
> I guess this will be a short term issue until a new mingw release is made
> and arrives i nthe distros, so we can try with the curl approach for
> now and change if it causes problems
That's my assumption, too. And since the containers are only rebuild
when something changed (as far as I understood), the download should
only occur quite rarely, so there is hopefully really not a big
dependency here.
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Thanks!
Thomas
next prev parent reply other threads:[~2020-09-01 16:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 11:17 [PATCH v2 0/7] Run cross-compilation build tests in the gitlab-CI Thomas Huth
2020-08-23 11:17 ` [PATCH v2 1/7] configure: Add system = 'linux' for meson when cross-compiling Thomas Huth
2020-09-01 16:18 ` Daniel P. Berrangé
2020-08-23 11:17 ` [PATCH v2 2/7] tests/docker: Install python3-setuptools in the debian9-mxe containers Thomas Huth
2020-09-01 16:19 ` Daniel P. Berrangé
2020-08-23 11:17 ` [PATCH v2 3/7] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
2020-09-01 16:21 ` Daniel P. Berrangé
2020-08-23 11:17 ` [PATCH v2 4/7] tests/Makefile: test-replication " Thomas Huth
2020-09-01 16:22 ` Daniel P. Berrangé
2020-08-23 11:17 ` [PATCH v2 5/7] dockerfiles/debian-win64-cross: Download WHPX MinGW headers Thomas Huth
2020-09-01 16:25 ` Daniel P. Berrangé
2020-09-01 16:31 ` Thomas Huth [this message]
2020-08-23 11:17 ` [PATCH v2 6/7] configure: Allow automatic WHPX detection Thomas Huth
2020-09-01 16:25 ` Daniel P. Berrangé
2020-08-23 11:17 ` [PATCH v2 7/7] gitlab-ci: Add cross-compiling build tests Thomas Huth
2020-09-01 16:27 ` Daniel P. Berrangé
2020-09-01 16:36 ` Thomas Huth
2020-08-25 7:59 ` [PATCH v2 0/7] Run cross-compilation build tests in the gitlab-CI Paolo Bonzini
2020-09-01 16:29 ` Daniel P. Berrangé
2020-09-01 16:38 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37748f4a-c362-017e-c2f3-98e282c45eb5@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.