From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751207AbcGAUCn (ORCPT ); Fri, 1 Jul 2016 16:02:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:32291 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbcGAUCl (ORCPT ); Fri, 1 Jul 2016 16:02:41 -0400 X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: Thiago Jung Bauermann To: Dave Young Cc: kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Eric Biederman Subject: Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer. Date: Fri, 01 Jul 2016 17:02:23 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-91-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20160701183602.GA4553@dhcp-128-65.nay.redhat.com> References: <1466538521-31216-1-git-send-email-bauerman@linux.vnet.ibm.com> <3713936.n8FBhAAd79@hactar> <20160701183602.GA4553@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16070120-1523-0000-0000-0000020004AD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16070120-1524-0000-0000-000026E7EF5F Message-Id: <3789971.1TYeJNg8TK@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-01_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607010199 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 01 Juli 2016, 14:36:02 schrieb Dave Young: > On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > > Am Donnerstag, 30 Juni 2016, 17:43:57 schrieb Dave Young: > > > On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > > > > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > I understand that this is all somewhat subjective, so if you still > > disagree with my points I can provide a patch set implementing the > > change above. > I still feel it should be changed if more callbacks being introduced, > though you can regard it is internal api, like above comment we do not > need to assign them seperately, the member values can be assigned > from the beginning. Ok, I'll implement the changes and submit a v4. Thanks for your review. []'s Thiago Jung Bauermann IBM Linux Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bJ4eM-0001Li-66 for kexec@lists.infradead.org; Fri, 01 Jul 2016 20:02:54 +0000 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u61K02di025058 for ; Fri, 1 Jul 2016 16:02:32 -0400 Received: from e24smtp03.br.ibm.com (e24smtp03.br.ibm.com [32.104.18.24]) by mx0a-001b2d01.pphosted.com with ESMTP id 23wj3maj2q-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 01 Jul 2016 16:02:32 -0400 Received: from localhost by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Jul 2016 17:02:29 -0300 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 03F29352005C for ; Fri, 1 Jul 2016 16:02:09 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay03.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u61K2Qg615204620 for ; Fri, 1 Jul 2016 17:02:26 -0300 Received: from d24av05.br.ibm.com (localhost [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u61K2PLT026912 for ; Fri, 1 Jul 2016 17:02:25 -0300 From: Thiago Jung Bauermann Subject: Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer. Date: Fri, 01 Jul 2016 17:02:23 -0300 In-Reply-To: <20160701183602.GA4553@dhcp-128-65.nay.redhat.com> References: <1466538521-31216-1-git-send-email-bauerman@linux.vnet.ibm.com> <3713936.n8FBhAAd79@hactar> <20160701183602.GA4553@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Message-Id: <3789971.1TYeJNg8TK@hactar> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Dave Young Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Biederman Am Freitag, 01 Juli 2016, 14:36:02 schrieb Dave Young: > On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > > Am Donnerstag, 30 Juni 2016, 17:43:57 schrieb Dave Young: > > > On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > > > > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > I understand that this is all somewhat subjective, so if you still > > disagree with my points I can provide a patch set implementing the > > change above. > I still feel it should be changed if more callbacks being introduced, > though you can regard it is internal api, like above comment we do not > need to assign them seperately, the member values can be assigned > from the beginning. Ok, I'll implement the changes and submit a v4. Thanks for your review. []'s Thiago Jung Bauermann IBM Linux Technology Center _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec