From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] build: create relative symlinks for PMDs in
	libdir
Date: Mon, 17 Sep 2018 13:38:21 +0200
Message-ID: <3796332.J9Jhy0mxQi@xps>
References: <20180912172134.21099-1-bluca@debian.org>
 <20180913091135.GA20960@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 tredaelli@redhat.com
To: Luca Boccassi <bluca@debian.org>
Return-path: <dev-bounces@dpdk.org>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 519DC5B16
 for <dev@dpdk.org>; Mon, 17 Sep 2018 13:38:25 +0200 (CEST)
In-Reply-To: <20180913091135.GA20960@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/09/2018 11:11, Bruce Richardson:
> On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote:
> > Add -r option to ln, otherwise the link will be absolute and contain
> > the build path and break packaging among other things:
> > 
> > lrwxrwxrwx 1 bluca bluca     99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
> >   -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
> >      drivers/librte_mempool_dpaa.so.1.1
> > 
> > With -r:
> > 
> > lrwxrwxrwx 1 bluca bluca     35 Sep 12 18:13 librte_pmd_zlib.so.1.1
> >   -> dpdk/drivers/librte_pmd_zlib.so.1.1
> > 
> > Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  buildtools/symlink-drivers-solibs.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh
> > index 803dfec491..9826c6ae37 100644
> > --- a/buildtools/symlink-drivers-solibs.sh
> > +++ b/buildtools/symlink-drivers-solibs.sh
> > @@ -9,4 +9,4 @@
> >  # parameters to script are paths relative to install prefix:
> >  # 1. directory containing driver files e.g. lib64/dpdk/drivers
> >  # 2. directory for installed regular libs e.g. lib64
> > -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> > +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks