All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liang, Kan" <kan.liang@intel.com>
To: Ben Hutchings <ben@decadent.org.uk>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"bwh@kernel.org" <bwh@kernel.org>,
	"decot@googlers.com" <decot@googlers.com>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
	"andi@firstfloor.org" <andi@firstfloor.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"Nelson, Shannon" <shannon.nelson@intel.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@intel.com>,
	"Skidmore, Donald C" <donald.c.skidmore@intel.com>,
	"Williams, Mitch A" <mitch.a.williams@intel.com>,
	"ogerlitz@mellanox.com" <ogerlitz@mellanox.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"jiri@mellanox.com" <jiri@mellanox.com>,
	"sfeldma@gmail.com" <sfeldma@gmail.com>,
	"gospo@cumulusnetworks.com" <gospo@cumulusnetworks.com>,
	"sasha.levin@oracle.com" <sasha.levin@oracle.com>,
	"dsahern@gmail.com" <dsahern@gmail.com>,
	"tj@kernel.org" <tj@kernel.org>,
	"cascardo@redhat.com" <cascardo@redhat.com>,
	"corbet@lwn.net" <corbet@lwn
Subject: RE: [PATCH V3 1/6] net/ethtool: introduce a new ioctl for per queue setting
Date: Mon, 18 Jan 2016 02:25:10 +0000	[thread overview]
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077058775A4@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1452996017.2519.29.camel@decadent.org.uk>

> 
> On Thu, 2016-01-14 at 09:08 -0500, kan.liang@intel.com wrote:
> [...]
> > --- a/include/uapi/linux/ethtool.h
> > +++ b/include/uapi/linux/ethtool.h
> > @@ -1144,6 +1144,21 @@ enum ethtool_sfeatures_retval_bits {
> >  #define ETHTOOL_F_WISH          (1 << ETHTOOL_F_WISH__BIT)
> >  #define ETHTOOL_F_COMPAT        (1 << ETHTOOL_F_COMPAT__BIT)
> >
> > +#define MAX_NUM_QUEUE		4096
> > +
> > +/**
> > + * struct ethtool_per_queue_op - apply sub command to the queues in
> mask.
> > + * @cmd: ETHTOOL_PERQUEUE
> > + * @sub_command: the sub command which apply to each queues
> > + * @queue_mask: Bitmap of the queues which sub command apply to
> > + * @data: A complete command structure following for each of the
> > +queues addressed  */ struct ethtool_per_queue_op {
> > +	__u32	cmd;
> > +	__u32	sub_command;
> > +	unsigned long
> queue_mask[BITS_TO_LONGS(MAX_NUM_QUEUE)];
> [...]
> 
> I thought we already agreed that this won't work for 32-bit userland on a
> big-endian 64-bit kernel?

I found David Decotigny's patch. https://lkml.org/lkml/2015/12/14/728
But it looks like it is not merged yet. 
Any idea when it will be merged to net-next or net?
So I can build my patch on top of his patch.

Thanks,
Kan

> 
> Ben.
> 
> --
> Ben Hutchings
> Theory and practice are closer in theory than in practice.
>                                 - John Levine, moderator of comp.compilers

  reply	other threads:[~2016-01-18  2:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 14:08 [PATCH V3 1/6] net/ethtool: introduce a new ioctl for per queue setting kan.liang
2016-01-14 14:08 ` [PATCH V3 2/6] net/ethtool: support get coalesce per queue kan.liang
2016-01-17  2:06   ` Ben Hutchings
2016-01-14 14:08 ` [PATCH V3 3/6] net/ethtool: support set " kan.liang
2016-01-17  2:13   ` Ben Hutchings
2016-01-14 14:08 ` [PATCH V3 4/6] i40e: queue-specific settings for interrupt moderation kan.liang
2016-01-14 22:41   ` Nelson, Shannon
2016-01-14 14:08 ` [PATCH V3 5/6] i40e/ethtool: support coalesce getting by queue kan.liang
2016-01-14 14:08 ` [PATCH V3 6/6] i40e/ethtool: support coalesce setting " kan.liang
2016-01-17  2:00 ` [PATCH V3 1/6] net/ethtool: introduce a new ioctl for per queue setting Ben Hutchings
2016-01-18  2:25   ` Liang, Kan [this message]
2016-01-19 19:30     ` David Decotigny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37D7C6CF3E00A74B8858931C1DB2F077058775A4@SHSMSX103.ccr.corp.intel.com \
    --to=kan.liang@intel.com \
    --cc=alexander.duyck@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=ben@decadent.org.uk \
    --cc=bwh@kernel.org \
    --cc=carolyn.wyborny@intel.com \
    --cc=cascardo@redhat.com \
    --cc=corbet@lwn \
    --cc=davem@davemloft.net \
    --cc=decot@googlers.com \
    --cc=donald.c.skidmore@intel.com \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jiri@mellanox.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=sasha.levin@oracle.com \
    --cc=sfeldma@gmail.com \
    --cc=shannon.nelson@intel.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.