From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964775AbeAXPrf convert rfc822-to-8bit (ORCPT ); Wed, 24 Jan 2018 10:47:35 -0500 Received: from mga04.intel.com ([192.55.52.120]:51594 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934225AbeAXPrb (ORCPT ); Wed, 24 Jan 2018 10:47:31 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,408,1511856000"; d="scan'208";a="22247189" From: "Liang, Kan" To: Peter Zijlstra CC: Andi Kleen , Stephane Eranian , "tglx@linutronix.de" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "acme@kernel.org" Subject: RE: [PATCH V5 4/8] perf/x86/intel/uncore: add new data structures for free running counters Thread-Topic: [PATCH V5 4/8] perf/x86/intel/uncore: add new data structures for free running counters Thread-Index: AQHTjjLMO5E6Fi0JBEaHVwBOA31k86N5HycAgACap6CAAPCdgIAApDaA//+iMICAAI7aIP//eyCAgACGgND//6MogAACbqKAANlSuBAACoFSgAAcQDgw Date: Wed, 24 Jan 2018 15:46:49 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077538041CE@SHSMSX103.ccr.corp.intel.com> References: <37D7C6CF3E00A74B8858931C1DB2F07753801FEF@SHSMSX103.ccr.corp.intel.com> <20180119130731.GQ2228@hirez.programming.kicks-ass.net> <37D7C6CF3E00A74B8858931C1DB2F077538025E7@SHSMSX103.ccr.corp.intel.com> <20180119171929.GZ2228@hirez.programming.kicks-ass.net> <37D7C6CF3E00A74B8858931C1DB2F077538026F3@SHSMSX103.ccr.corp.intel.com> <37D7C6CF3E00A74B8858931C1DB2F07753802712@SHSMSX103.ccr.corp.intel.com> <20180119202417.GK7844@tassilo.jf.intel.com> <20180119213355.GE2269@hirez.programming.kicks-ass.net> <37D7C6CF3E00A74B8858931C1DB2F07753803C1E@SHSMSX103.ccr.corp.intel.com> <20180124101721.GQ2228@hirez.programming.kicks-ass.net> In-Reply-To: <20180124101721.GQ2228@hirez.programming.kicks-ass.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjA2ZjZiNjAtOTBlZC00MjRkLWI1MTctZTE3ODViZGJmOWM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlNhbWJRNUg1VXRBcDdWZ3NuNk91NnJhK1pBUVBNRCtvSVBnQWFlTmt5M1k9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, Jan 23, 2018 at 10:00:58PM +0000, Liang, Kan wrote: > > > On Fri, Jan 19, 2018 at 12:24:17PM -0800, Andi Kleen wrote: > > > > > Oh, think a bit more. > > > > > I think we cannot do the same thing as we did for CPU PMU's fixed > > > counters. > > > > > > > > > > The counters here are free running counters. They cannot be > start/stop. > > > > > > > > Yes free running counter have completely different semantics. They > > > > need a separate event code. > > > > > > The only thing that matters is if they count the same thing or not. > > > > > > > Hi Peter, > > > > There is NO event available on the GPs, that is exactly the same as > > the free-running counters. > > > > For example, the BW free-running counters count the requests associated > > with writes and completions. > > The most similar events on the GPs are DATA_REQ_{OF,BY}_CPU.* events. > > Except that some of their sub-events count requests which not completions. > > There are also other minor differences. > > So we don't have alternative events for the free-running counters. > > I think we have to use 0xff. > > OK, but explicitly mention this as the reason for having to invent event > codes. Them being fixed purpose or free running isn't a valid reason for > that. Sure, I will add it in V6. Thanks, Kan