From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V2] xen/hvm: fix hypervisor crash with hvm_save_one() Date: Wed, 3 May 2017 12:20:15 +0300 Message-ID: <37a1b145-80c5-01b2-eae9-1ce9b92812c8@bitdefender.com> References: <1493738507-23431-1-git-send-email-rcojocaru@bitdefender.com> <20170502160248.GD90479@deinos.phlegethon.org> <0ba510e0-e589-68df-46d3-965a208d8596@citrix.com> <5909956E02000078001561D5@prv-mh.provo.novell.com> <20170503091508.GA84068@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170503091508.GA84068@deinos.phlegethon.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Tim Deegan , Jan Beulich Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, Andrew Cooper , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gMDUvMDMvMTcgMTI6MTUsIFRpbSBEZWVnYW4gd3JvdGU6Cj4gQXQgMDA6MzEgLTA2MDAgb24g MDMgTWF5ICgxNDkzNzcxNTAyKSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+IEhtbSwgd2l0aCBib3Ro IG9mIHlvdSBiZWluZyBvZiB0aGF0IG9waW5pb24sIEkndmUgdGFrZW4gYW5vdGhlcgo+PiBsb29r LiBJIHRoaW5rIEkgc2VlIG5vdyB3aHkgeW91IHRoaW5rIHRoYXQgd2F5ICh0aGlzIGJlaW5nIGRh dGEKPj4gZnJvbSBhbiBpbnRlcm5hbCBwcm9kdWNlciwgb3ZlcmZsb3cvdW5kZXJmbG93IGFyZSBu b3QgYSBwcmltYXJ5Cj4+IGNvbmNlcm4pLCBzbyBJJ2xsIHdpdGhkcmF3IG15IG9iamVjdGlvbiB0 byB0aGUgb3JpZ2luYWwgcGF0Y2ggKGkuZS4KPj4gSSBhZ3JlZSB0YWtpbmcgaXQgd2l0aCB0aGUg djIgZGVzY3JpcHRpb24pLiBIb3dldmVyLCBhbiBhbHRlcm5hdGl2ZQo+PiB3b3VsZCBiZQo+Pgo+ PiAtLS0gdW5zdGFibGUub3JpZy94ZW4vY29tbW9uL2h2bS9zYXZlLmMKPj4gKysrIHVuc3RhYmxl L3hlbi9jb21tb24vaHZtL3NhdmUuYwo+PiBAQCAtNzksMTQgKzc5LDE1IEBAIHNpemVfdCBodm1f c2F2ZV9zaXplKHN0cnVjdCBkb21haW4gKmQpCj4+ICBpbnQgaHZtX3NhdmVfb25lKHN0cnVjdCBk b21haW4gKmQsIHVpbnQxNl90IHR5cGVjb2RlLCB1aW50MTZfdCBpbnN0YW5jZSwgCj4+ICAgICAg ICAgICAgICAgICAgIFhFTl9HVUVTVF9IQU5ETEVfNjQodWludDgpIGhhbmRsZSkKPj4gIHsKPj4g LSAgICBpbnQgcnYgPSAwOwo+PiArICAgIGludCBydiA9IC1FTk9FTlQ7Cj4+ICAgICAgc2l6ZV90 IHN6ID0gMDsKPj4gICAgICBzdHJ1Y3QgdmNwdSAqdjsKPj4gICAgICBodm1fZG9tYWluX2NvbnRl eHRfdCBjdHh0ID0geyAwLCB9Owo+PiArICAgIGNvbnN0IHN0cnVjdCBodm1fc2F2ZV9kZXNjcmlw dG9yICpkZXNjOwo+PiAgCj4+ICAgICAgaWYgKCBkLT5pc19keWluZyAKPj4gICAgICAgICAgIHx8 IHR5cGVjb2RlID4gSFZNX1NBVkVfQ09ERV9NQVggCj4+IC0gICAgICAgICB8fCBodm1fc3JfaGFu ZGxlcnNbdHlwZWNvZGVdLnNpemUgPCBzaXplb2Yoc3RydWN0IGh2bV9zYXZlX2Rlc2NyaXB0b3Ip Cj4+ICsgICAgICAgICB8fCBodm1fc3JfaGFuZGxlcnNbdHlwZWNvZGVdLnNpemUgPCBzaXplb2Yo KmRlc2MpCj4+ICAgICAgICAgICB8fCBodm1fc3JfaGFuZGxlcnNbdHlwZWNvZGVdLnNhdmUgPT0g TlVMTCApCj4+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+PiAgCj4+IEBAIC0xMDcsMTIgKzEw OCwxMCBAQCBpbnQgaHZtX3NhdmVfb25lKHN0cnVjdCBkb21haW4gKmQsIHVpbnQxCj4+ICAgICAg ICAgICAgICAgICBkLT5kb21haW5faWQsIHR5cGVjb2RlKTsKPj4gICAgICAgICAgcnYgPSAtRUZB VUxUOwo+PiAgICAgIH0KPj4gLSAgICBlbHNlCj4+ICsgICAgZWxzZSBpZiAoIGN0eHQuY3VyID4g c2l6ZW9mKCpkZXNjKSApCj4+ICAgICAgewo+PiAgICAgICAgICB1aW50MzJfdCBvZmY7Cj4+IC0g ICAgICAgIGNvbnN0IHN0cnVjdCBodm1fc2F2ZV9kZXNjcmlwdG9yICpkZXNjOwo+PiAgCj4+IC0g ICAgICAgIHJ2ID0gLUVOT0VOVDsKPj4gICAgICAgICAgZm9yICggb2ZmID0gMDsgb2ZmIDwgKGN0 eHQuY3VyIC0gc2l6ZW9mKCpkZXNjKSk7IG9mZiArPSBkZXNjLT5sZW5ndGggKQo+PiAgICAgICAg ICB7Cj4+ICAgICAgICAgICAgICBkZXNjID0gKHZvaWQgKikoY3R4dC5kYXRhICsgb2ZmKTsKPj4g QEAgLTEyMiw3ICsxMjEsOCBAQCBpbnQgaHZtX3NhdmVfb25lKHN0cnVjdCBkb21haW4gKmQsIHVp bnQxCj4+ICAgICAgICAgICAgICB7Cj4+ICAgICAgICAgICAgICAgICAgdWludDMyX3QgY29weV9s ZW5ndGggPSBkZXNjLT5sZW5ndGg7Cj4+ICAKPj4gLSAgICAgICAgICAgICAgICBpZiAoIG9mZiAr IGNvcHlfbGVuZ3RoID4gY3R4dC5jdXIgKQo+PiArICAgICAgICAgICAgICAgIGlmICggY3R4dC5j dXIgPCBjb3B5X2xlbmd0aCB8fAo+PiArICAgICAgICAgICAgICAgICAgICAgb2ZmID4gY3R4dC5j dXIgLSBjb3B5X2xlbmd0aCApCj4+ICAgICAgICAgICAgICAgICAgICAgIGNvcHlfbGVuZ3RoID0g Y3R4dC5jdXIgLSBvZmY7Cj4+ICAgICAgICAgICAgICAgICAgcnYgPSAwOwo+PiAgICAgICAgICAg ICAgICAgIGlmICggY29weV90b19ndWVzdChoYW5kbGUsIGN0eHQuZGF0YSArIG9mZiwgY29weV9s ZW5ndGgpICkKPj4KPj4gdGFraW5nIGNhcmUgb2Ygb3ZlcmZsb3cvdW5kZXJmbG93IChub3cgY29u c2lzdGVudGx5KSBhcyB3ZWxsLCBwbHVzCj4+IGF2b2lkaW5nIHRoZSAoaW1vIHVnbHkpIGdvdG8g d2l0aG91dCBtYWtpbmcgdGhlIGNvZGUgaGFyZGVyIHRvCj4+IHJlYWQuIFRob3VnaHRzPwo+IAo+ IEFueSBvZiB0aGVzZSB0aHJlZSBwYXRjaGVzIGlzIGZpbmUgYnkgbWUuCgpJIGZlZWwgdGhlIHNh bWUuIElmIEFuZHJldyBwcmVmZXJzIHRoaXMgdmVyc2lvbiBJJ20gaGFwcHkgdG8gdGVzdCBpdCwK b3RoZXJ3aXNlIHJlLXNlbmRpbmcgdGhlIGZpcnN0IHBhdGNoIHdpdGggdGhlIGNvcnJlY3RlZCBk ZXNjcmlwdGlvbiBpcwp0aGUgZmFzdGVzdCBwYXRoLgoKClRoYW5rcywKUmF6dmFuCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4t ZGV2ZWwK