From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA992C4BA0A for ; Tue, 25 Feb 2020 23:53:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0BBD2075D for ; Tue, 25 Feb 2020 23:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729631AbgBYXxJ (ORCPT ); Tue, 25 Feb 2020 18:53:09 -0500 Received: from mail.willitsonline.com ([216.7.65.54]:51378 "EHLO mail.willitsonline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729182AbgBYXxJ (ORCPT ); Tue, 25 Feb 2020 18:53:09 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.willitsonline.com (Postfix) with ESMTP id B93B7111E08 for ; Tue, 25 Feb 2020 15:46:50 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at iredmail2.willitsonline.com Received: from mail.willitsonline.com ([127.0.0.1]) by localhost (iredmail2.willitsonline.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bmK5K-ZCg5s5 for ; Tue, 25 Feb 2020 15:46:50 -0800 (PST) Received: from _ (localhost.localdomain [127.0.0.1]) (Authenticated sender: bluerocksaddles@willitsonline.com) by mail.willitsonline.com (Postfix) with ESMTPSA id E6052111D61; Tue, 25 Feb 2020 15:46:35 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 25 Feb 2020 15:46:35 -0800 From: bluerocksaddles@willitsonline.com To: Ulf Hansson Cc: Bjorn Helgaas , "Michael ." , Dominik Brodowski , Linux PCI , Linux Kernel Mailing List , Trevor Jacobs , Kris Cleveland , Morgan Klym , Philip Langdale , Pierre Ossman , Maxim Levitsky , linux-mmc@vger.kernel.org Subject: Re: PCI device function not being enumerated [Was: PCMCIA not working on Panasonic Toughbook CF-29] In-Reply-To: References: <20191029170250.GA43972@google.com> <20200222165617.GA207731@google.com> Message-ID: <37a39a53a54ca4ae09b4cfa9d999a47e@willitsonline.com> X-Sender: bluerocksaddles@willitsonline.com User-Agent: Roundcube Webmail Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn, If you folks need a test unit or five, let me know. I can donate any Mark CF-29 to the project. (MK 2 or 3 will duplicate the "problem".) They are non-pae 386. Jeff On 2020-02-25 07:03, Ulf Hansson wrote: > On Sat, 22 Feb 2020 at 17:56, Bjorn Helgaas wrote: >> >> On Tue, Oct 29, 2019 at 12:02:50PM -0500, Bjorn Helgaas wrote: >> > [+cc Ulf, Philip, Pierre, Maxim, linux-mmc; see [1] for beginning of >> > thread, [2] for problem report and the patch Michael tested] >> > >> > On Tue, Oct 29, 2019 at 07:58:27PM +1100, Michael . wrote: >> > > Bjorn and Dominik. >> > > I am happy to let you know the patch did the trick, it compiled well >> > > on 5.4-rc4 and my friends in the CC list have tested the modified >> > > kernel and confirmed that both slots are now working as they should. >> > > As a group of dedicated Toughbook users and Linux users please accept >> > > our thanks your efforts and assistance is greatly appreciated. >> > > >> > > Now that we know this patch works what kernel do you think it will be >> > > released in? Will it make 5.4 or will it be put into 5.5 development >> > > for further testing? >> > >> > That patch was not intended to be a fix; it was just to test my guess >> > that the quirk might be related. >> > >> > Removing the quirk solved the problem *you're* seeing, but the quirk >> > was added in the first place to solve some other problem, and if we >> > simply remove the quirk, we may reintroduce the original problem. >> > >> > So we have to look at the history and figure out some way to solve >> > both problems. I cc'd some people who might have insight. Here are >> > some commits that look relevant: >> > >> > 5ae70296c85f ("mmc: Disabler for Ricoh MMC controller") >> > 03cd8f7ebe0c ("ricoh_mmc: port from driver to pci quirk") >> > >> > >> > [1] https://lore.kernel.org/r/CAFjuqNi+knSb9WVQOahCVFyxsiqoGgwoM7Z1aqDBebNzp_-jYw@mail.gmail.com/ >> > [2] https://lore.kernel.org/r/20191021160952.GA229204@google.com/ >> >> I guess this problem is still unfixed? I hate the fact that we broke >> something that used to work. >> >> Maybe we need some sort of DMI check in ricoh_mmc_fixup_rl5c476() so >> we skip it for Toughbooks? Or maybe we limit the quirk to the >> machines where it was originally needed? > > Both options seems reasonable to me. Do you have time to put together a > patch? > > Kind regards > Uffe