All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH] media: vivid: drop CONFIG_FB dependency
Date: Thu, 29 Jul 2021 12:32:42 +0100	[thread overview]
Message-ID: <37aaf1b0-bb5a-a3df-054d-9aeea1f32a44@collabora.com> (raw)
In-Reply-To: <bf74a4670438864ca2e6bde47121554490350729.1627557341.git.guillaume.tucker@collabora.com>

On 29/07/2021 12:16, Guillaume Tucker wrote:
> +ifeq ($(CONFIG_FB),y)
> +  vivid-objs += vivid-osd.o
> +endif

Just realised CONFIG_FB is tristate, so I guess it should be:

ifneq ($(CONFIG_FB),)
  vivid-objs += vivid-osd.o
endif


Best wishes,
Guillaume

  reply	other threads:[~2021-07-29 11:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 11:16 [PATCH] media: vivid: drop CONFIG_FB dependency Guillaume Tucker
2021-07-29 11:32 ` Guillaume Tucker [this message]
2021-07-29 18:53   ` Guillaume Tucker
2021-07-30 13:32 ` kernel test robot
2021-07-30 13:32   ` kernel test robot
2021-07-30 14:26   ` Guillaume Tucker
2021-07-30 14:26     ` Guillaume Tucker
2021-08-04 14:18     ` Hans Verkuil
2021-08-04 14:18       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37aaf1b0-bb5a-a3df-054d-9aeea1f32a44@collabora.com \
    --to=guillaume.tucker@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.