From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C80FDC43381 for ; Tue, 12 Mar 2019 12:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A167F206DF for ; Tue, 12 Mar 2019 12:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbfCLMMy (ORCPT ); Tue, 12 Mar 2019 08:12:54 -0400 Received: from www62.your-server.de ([213.133.104.62]:47496 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbfCLMMx (ORCPT ); Tue, 12 Mar 2019 08:12:53 -0400 Received: from [78.46.172.2] (helo=sslproxy05.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1h3gH6-0000MC-50; Tue, 12 Mar 2019 13:12:52 +0100 Received: from [178.197.248.21] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1h3gH5-000DjL-TZ; Tue, 12 Mar 2019 13:12:51 +0100 Subject: Re: Patch "sk_msg: Always cancel strp work before freeing the psock" has been added to the 4.20-stable tree To: Greg KH , Jakub Sitnicki Cc: stable@vger.kernel.org, Sasha Levin References: <20190311191742.5406D2087F@mail.kernel.org> <87a7i08m61.fsf@cloudflare.com> <20190312120516.GA30474@kroah.com> From: Daniel Borkmann Message-ID: <37adecd1-76d3-3181-6999-9f0831558b5b@iogearbox.net> Date: Tue, 12 Mar 2019 13:12:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190312120516.GA30474@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25386/Tue Mar 12 09:15:09 2019) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 03/12/2019 01:05 PM, Greg KH wrote: > On Tue, Mar 12, 2019 at 10:41:26AM +0100, Jakub Sitnicki wrote: >> Hi, >> >> On Mon, Mar 11, 2019 at 08:17 PM CET, Sasha Levin wrote: >>> This is a note to let you know that I've just added the patch titled >>> >>> sk_msg: Always cancel strp work before freeing the psock >>> >>> to the 4.20-stable tree which can be found at: >>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >>> >>> The filename of the patch is: >>> sk_msg-always-cancel-strp-work-before-freeing-the-ps.patch >>> and it can be found in the queue-4.20 subdirectory. >>> >>> If you, or anyone else, feels it should not be added to the stable tree, >>> please let know about it. >> >> There is a follow-up fix for this change - e8e3437762ad ("bpf: Stop the >> psock parser before canceling its work") in bpf tree: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=e8e3437762ad938880dd48a3c52d702e7cf3c124 >> >> I think this patch should not go to into stable without the follow-up >> fix. Otherwise kselftests for bpf will be noisy due to kernel warnings. > > Thanks, I've dropped this now. We can add this back when the original > patch hits Linus's tree. This is already in Linus tree here, so we should be able to proceed with queueing both of them: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e8e3437762ad938880dd48a3c52d702e7cf3c124 Thanks, Daniel