All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Mark Brown <broonie@kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: imx: mx51-ecspi: Fix low-speed CONFIGREG delay calculation
Date: Wed, 21 Jul 2021 22:18:35 +0200	[thread overview]
Message-ID: <37b0f7eb-39fd-9e15-20e3-becfcfd4b5f4@denx.de> (raw)
In-Reply-To: <20210719211221.GA35544@sirena.org.uk>

On 7/19/21 11:12 PM, Mark Brown wrote:
> On Mon, Jul 19, 2021 at 03:38:55PM +0200, Marek Vasut wrote:
>> On 7/19/21 10:20 AM, Uwe Kleine-König wrote:
> 
>>> Can it happen that all transfer's spped_hz are zero?
> 
>> I don't think so, what kind of spi_message would that be ?
> 
>> And even if it was zero, the delay would be 2000000/~0U , so zero as well,
>> which I suppose is the best we can do in such a case.
> 
> I can see that happening for a controller that didn't set any speed
> information with a driver that also didn't set any speed information,
> everything is just hoping that the default is fine but only the hardware
> is actually setting something.  I've not gone and checked if anything
> ever insists there absolutely must be something specified in software.

So, should I send a V2 here with any changes or is this one OK as-is ?

  reply	other threads:[~2021-07-21 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-18 21:11 [PATCH] spi: imx: mx51-ecspi: Fix low-speed CONFIGREG delay calculation Marek Vasut
2021-07-19  8:20 ` Uwe Kleine-König
2021-07-19 13:38   ` Marek Vasut
2021-07-19 21:12     ` Mark Brown
2021-07-21 20:18       ` Marek Vasut [this message]
2021-07-26  1:46         ` Mark Brown
2021-07-26  6:25           ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37b0f7eb-39fd-9e15-20e3-becfcfd4b5f4@denx.de \
    --to=marex@denx.de \
    --cc=broonie@kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.