All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sandeep Maheswaram <quic_c_sanm@quicinc.com>,
	Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
	quic_kriskura@quicinc.com, quic_vpulyala@quicinc.com
Subject: Re: [PATCH v13 1/6] dt-bindings: usb: dwc3: Add wakeup-source property support
Date: Tue, 12 Apr 2022 14:02:17 +0200	[thread overview]
Message-ID: <37b21c24-22e0-2de2-697f-d22ff92b90c2@linaro.org> (raw)
In-Reply-To: <1649704614-31518-2-git-send-email-quic_c_sanm@quicinc.com>

On 11/04/2022 21:16, Sandeep Maheswaram wrote:
> Added support for wakeup-source property. This property can be
> used to check and power down the phy during system suspend if
> wake up is not supported.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index f4471f8..4d4de2f 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -341,6 +341,11 @@ properties:
>        This port is used with the 'usb-role-switch' property  to connect the
>        dwc3 to type C connector.
>  
> +  wakeup-source:
> +    $ref: /schemas/types.yaml#/definitions/flag

I would prefer to use shorter "type: boolean", but in any case:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> +    description:
> +      Enable USB remote wakeup.


Best regards,
Krzysztof

  reply	other threads:[~2022-04-12 12:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 19:16 [PATCH v13 0/6] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2022-04-11 19:16 ` [PATCH v13 1/6] dt-bindings: usb: dwc3: Add wakeup-source property support Sandeep Maheswaram
2022-04-12 12:02   ` Krzysztof Kozlowski [this message]
2022-04-11 19:16 ` [PATCH v13 2/6] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2022-04-11 20:54   ` Matthias Kaehlcke
2022-04-12  4:46     ` Sandeep Maheswaram (Temp)
2022-04-12  5:00       ` Pavan Kondeti
2022-04-12  6:38         ` Sandeep Maheswaram (Temp)
2022-04-12  6:49           ` Pavan Kondeti
2022-04-12 19:05           ` Matthias Kaehlcke
2022-04-13  9:08             ` Sandeep Maheswaram (Temp)
2022-04-13 15:56               ` Matthias Kaehlcke
2022-04-14  5:57                 ` Sandeep Maheswaram (Temp)
2022-04-16  0:30                   ` Matthias Kaehlcke
2022-04-19 10:22                     ` Sandeep Maheswaram (Temp) (QUIC)
2022-04-11 19:16 ` [PATCH v13 3/6] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2022-04-11 19:16 ` [PATCH v13 4/6] usb: dwc3: qcom: Configure wakeup interrupts during suspend Sandeep Maheswaram
2022-04-11 19:16 ` [PATCH v13 5/6] usb: dwc3: qcom: Keep power domain on to retain controller status Sandeep Maheswaram
2022-04-11 21:13   ` Matthias Kaehlcke
2022-04-12  4:50     ` Sandeep Maheswaram (Temp)
2022-04-11 19:16 ` [PATCH v13 6/6] arm64: dts: qcom: sc7280: Add wakeup-source property for USB node Sandeep Maheswaram
2022-04-21 14:27   ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37b21c24-22e0-2de2-697f-d22ff92b90c2@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mka@chromium.org \
    --cc=quic_c_sanm@quicinc.com \
    --cc=quic_kriskura@quicinc.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=quic_vpulyala@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.