From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754809AbdIRQEo (ORCPT ); Mon, 18 Sep 2017 12:04:44 -0400 Received: from ale.deltatee.com ([207.54.116.67]:51252 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbdIRQEn (ORCPT ); Mon, 18 Sep 2017 12:04:43 -0400 To: Christophe JAILLET , mporter@kernel.crashing.org, alexandre.bounine@idt.com, lstoakes@gmail.com, akpm@linux-foundation.org, jesper.nilsson@axis.com, christian.koenig@amd.com Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Logan Gunthorpe Message-ID: <37c07c2e-e6ed-96fa-8cdd-68bfe598eda3@deltatee.com> Date: Mon, 18 Sep 2017 10:04:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, christian.koenig@amd.com, jesper.nilsson@axis.com, akpm@linux-foundation.org, lstoakes@gmail.com, alexandre.bounine@idt.com, mporter@kernel.crashing.org, christophe.jaillet@wanadoo.fr X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()' X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, I don't have any relation to the rapidio code short of making a small change to an API it used. But I reviewed both patches and they look correct to me. Reviewed-by: Logan Gunthorpe Logan On 17/09/17 04:33 PM, Christophe JAILLET wrote: > These 2 patches are really close and are both related to error handling > in 'rio_dma_transfer()'. > The first one fixes some resources leak in case of error. > The 2nd one fixes a test so that the corresponding error can be handled > correctly. > > I've splitted this into 2 paches because the first one looks trivial to me. > But the 2nd one should require more attention, IMO. The existing error > handling was dead code because 'dma_map_sg()' can not return -EFAULT. So > this error handling code has never been executed/tested and I can't test it > myself. > > Christophe JAILLET (2): > rapidio: Fix resources leak in error handling path in > 'rio_dma_transfer()' > rapidio: Fix an error handling in 'rio_dma_transfer()' > > drivers/rapidio/devices/rio_mport_cdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Date: Mon, 18 Sep 2017 16:04:34 +0000 Subject: Re: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()' Message-Id: <37c07c2e-e6ed-96fa-8cdd-68bfe598eda3@deltatee.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET , mporter@kernel.crashing.org, alexandre.bounine@idt.com, lstoakes@gmail.com, akpm@linux-foundation.org, jesper.nilsson@axis.com, christian.koenig@amd.com Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Hey, I don't have any relation to the rapidio code short of making a small change to an API it used. But I reviewed both patches and they look correct to me. Reviewed-by: Logan Gunthorpe Logan On 17/09/17 04:33 PM, Christophe JAILLET wrote: > These 2 patches are really close and are both related to error handling > in 'rio_dma_transfer()'. > The first one fixes some resources leak in case of error. > The 2nd one fixes a test so that the corresponding error can be handled > correctly. > > I've splitted this into 2 paches because the first one looks trivial to me. > But the 2nd one should require more attention, IMO. The existing error > handling was dead code because 'dma_map_sg()' can not return -EFAULT. So > this error handling code has never been executed/tested and I can't test it > myself. > > Christophe JAILLET (2): > rapidio: Fix resources leak in error handling path in > 'rio_dma_transfer()' > rapidio: Fix an error handling in 'rio_dma_transfer()' > > drivers/rapidio/devices/rio_mport_cdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >