From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF6F3C433F5 for ; Tue, 5 Oct 2021 17:17:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAB1361184 for ; Tue, 5 Oct 2021 17:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236796AbhJERTN (ORCPT ); Tue, 5 Oct 2021 13:19:13 -0400 Received: from mail-vi1eur05on2096.outbound.protection.outlook.com ([40.107.21.96]:49761 "EHLO EUR05-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234938AbhJERTI (ORCPT ); Tue, 5 Oct 2021 13:19:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ekj9iRf4gSxOWKLsg3YU06Idr7e0rJY9ROqGH++eihLGNOoQdlT/zgkj9Cs4dlshtY5iqYhPPRUK1ZxXSCT2ZrqW6BXD3qqSF6e/qHWvFI+Idw0JsSNoPqozt/6e4vwMd9op0VMIi8v6w96uSWxmwMmWV0eotdmRxcPWTS72A55xRVTxk55qmWqjeJA7GGzEg19xxFzv1svm0uaf4ghHsHaYpdm90CYhCOllsdigOhNlT0ZaJUO2Z1XxIc7m1V2q9dDelFo/B5pm8nh9doEACR+yV+ju8y0NCm6oq2QMIpc1drSeD3Iw+A4VxTib0lWzusoFafiGOENnoKh2dKYetQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1gL9pa/96GcysYb4dnL81fj0rY0i8LVeYSxLGeVDaE=; b=T+YgIGfT/3VDU3QSfQzBL43FA5qZbiFnDYb1G/2CDEH9at1DjIbGlCBZ6x7p5Q4n6U9vQccy6JrdzqKSytjrHxkaO5twysTH3KfW4XM+HdMv7MGVdlj7Hik+uPFz3FvFBJfBGb/BmTkqcT/Nkkz1jExmX4cjQEfjvf3+ivJc3BLiejvxwPqT1bvVtrgtsleDYnZKP6OOplVsAPZ9sq7hEM2xfk8yJEg8A3Cnw5rPHVJ8J4nHKpWseBdtOxIqTHtDb/RRqIoB2hsyNTy9zd9b1ZObklvEJwCMvRT+tYtLU+tD4SxGFN3LjvK524S9W802SY4e9o42Iw5ulYAeCkXcVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1gL9pa/96GcysYb4dnL81fj0rY0i8LVeYSxLGeVDaE=; b=EzA96OSOViZPXZevJ481D773I423SYKblfq+5cG6XkW51B3JjPaEbSYZY4zF6YhVtL03KZrHi4yir/wbbtuEZ0OTrWs7VsBmZ5FBQJ4njoY7N9MyJsHQEJAJgenoUj+/g2kSbyyLJL9UIyv09oQ8k0Z5LzWmWDoS73OhGc6PlkU= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=kontron.de; Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) by AM0PR10MB2579.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct 2021 17:17:15 +0000 Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::216b:62be:3272:2560]) by AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::216b:62be:3272:2560%6]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 17:17:15 +0000 Message-ID: <37c1845d-9323-3187-ed0b-b9795758649d@kontron.de> Date: Tue, 5 Oct 2021 19:17:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 5/8] arm64: dts: imx8mm-kontron: Fix CAN SPI clock frequency Content-Language: en-US To: Shawn Guo , Frieder Schrempf Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-6-frieder@fris.de> <20211005071230.GC20743@dragon> From: Frieder Schrempf In-Reply-To: <20211005071230.GC20743@dragon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P250CA0011.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::16) To AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) MIME-Version: 1.0 Received: from [192.168.10.40] (88.130.78.70) by AS8P250CA0011.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 17:17:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6a492e3-d98c-4e25-f84f-08d98823f9f0 X-MS-TrafficTypeDiagnostic: AM0PR10MB2579: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kv2N4fvr9RM8fOBvrIJFZn6PHMIc+uJfuDP+yS164Si/4So35ncDGwpNegC62fGAM6kvPAnZz/tH9ZJ3ngiCr8qJW76mcLppEw+GsytDbUo+rSKwTRpZvSrD5JU51uJ1ZVlLD8KzETyd9anU0lBMhU8C3eMnKUUHvS7Iec46bGaPiNhrZ6So9+4KeMeD8TdqSnEjmDGLWJ7xWWRMPrRkCBUY844mzfFkraNVa6k5o/87yQsCIzEk8K7IVdjv8x7sI/0zWZpDXAvsHDdnI4KHEDpL1A3JoyyXltejSvvkWXeGEpjajiO/xmLZ27XV5xCIcuFaHT1sc6ULYl480+hJEuRaZR1OvkMXqK6n7qKrqerQAirCOt1CBACjVaKc2OTfuGKyn2iEAZg9XDgksGIc6hWkLQMw16M4tVdypTMF/U/+CWp4MA+NlcYu2UMHdo3+j2jKla0+Vox5v2bGbrgyiOCO9GXMt7THtJUdMiXcXOQXFpu4RhRZ/lOTkLzRK1lHvlQvTFQ6YvPvGOiP7BqCykjiDNANgWsLRsIEUY0maZo4afaDC8pJCvVy1AKURJDRK/u8c6gD4WbffMAGvRxr2sPFbWGLy1tuaOf/J2b5tNjol6v2yKfJDoQVq0MR7O+rEh/aJHa1DZQnx6x/ltF8adf6jVVvsfTWKg8QNZfTRRM/8N5WNEtvqw2vTBmWWa+5iHQ+cCndg3JSQYsljlwJ1ocE+5UDL0OeNhIoV/vd9mIn+PLyKu3svWV+To7frsFw8UwSPd4M3ewi+gjdhDwm1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(66556008)(26005)(2906002)(508600001)(66946007)(53546011)(86362001)(7416002)(8936002)(8676002)(186003)(5660300002)(38100700002)(83380400001)(4326008)(316002)(110136005)(16576012)(6486002)(54906003)(36756003)(31686004)(956004)(44832011)(2616005)(31696002)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2kyMXVBUDdmbnhPNnJ3bTFsWEpRU1JnUEZqa1B6KzFmdjRycFgxZTNpQ0lO?= =?utf-8?B?MlhxS2VkTFRyR3REdDE3bjQrQmU5MUxmckFUdkVTejE4MWFTNW0vMHF6bXo0?= =?utf-8?B?TVhrQTJuL2d4RXBtYmVnOThyRXVUYTJxbjNHZFVES3VQVlRleXl6UzBFdlJS?= =?utf-8?B?dU1CUmkrcjREOXdKQW1XWFdRWUpidlJnSURmTzJPLzRyN3hJbmNrZ0VvcXQw?= =?utf-8?B?T2dKWG5NeVN2c3ZFSklEZzdTRzVxUERqcXhvZmRqbUxnSkVsVnNJVElqcW51?= =?utf-8?B?TXJtWkFnMEd4dUFkbzNxdVgwQytuTXByR2lMQzFRMWM2THZVQUZIOEUzdjJI?= =?utf-8?B?MU03eGlSemYvdE96dUNuSTducWRoekdXakRiQXVETG9aUVBUOWthZ3FTWEds?= =?utf-8?B?allSbkxlN0FoS200Umw0VmsyNlJzK3g1M0VhRUh3Njgzb3c1b21scThZbHpI?= =?utf-8?B?UzVEZDhzT2w2WnBNVTNmemRJTzFadWdGNVJxRE9Fcm5jdnIvOEFYcDZwOWVN?= =?utf-8?B?WTg1UXMwUXFCaElUeGpYeFhYV0hZS1ZNazl5cC9DOXFuQnAxSWQxcW03akc2?= =?utf-8?B?MHk1M0ZPMmQrSHkzdDNLcWRnYWY4Wk4ySVV4UnhXWmNHSWNTNFdxamJ2N2wv?= =?utf-8?B?ekJVUFVORUdJQ3dZdkh0ZjZqcnJ6S0E5WG1ZLzRXNFRId24zalozNjgxTE5H?= =?utf-8?B?UTJqMFpCYjZvWC9tWUxZUkNFNFpCaGMvQm1YVFNYUGZpNnUyR1ZGQXlwdkVq?= =?utf-8?B?L0xXNFdxcWd2OW9mbmRvY2YvVlZnY2kxWFFMVkhXbDlQOUUvbTRqYkhJWFV6?= =?utf-8?B?RUsyc05td3dvN1BpeUNQNVRnRUhpdVZYNGxQTkQ4Z1RyWHRRK2xFK005UGtN?= =?utf-8?B?cjRaNmxDeGd1OU9Nb0ZhVTN1VGJJTnVtSGtLSjkxV25OSEcrcVNFSHFVek1x?= =?utf-8?B?aEJ5V2xrdVJXSmc0bmdMT0cwcUhDSjl0REk5eVNBWFdNSHB4UTlZUzd4L3Zh?= =?utf-8?B?R05rOGQ0VklDWC9McVRPa0FNT0w2NmJVVU9hN0NGbk55UG1GTmxNakhtUTVF?= =?utf-8?B?WldvYkUvR2NMVWlxME5OTkE3S1EyalBabEl2RGd1VTN5M3Zkc1BqbFlDUTJT?= =?utf-8?B?V0h2ZXFLSmZVNy9xdDJPbE5kQmxSYnZ6NUVUUWpDaUY5OVlhT3BWMk52NEww?= =?utf-8?B?RTF4UTJpM2IrNnZNbVJ2SnlGUVNpUXpIOWVmbWJPSHI5K0lhOW5VSDBIS0FI?= =?utf-8?B?Y2pnQjN6akJUV05YRytBTnVXYVFRNGlmVUtHNW40enZOUTYwUDhDY0dOSWtv?= =?utf-8?B?RzhwK1lDODZYVGpVd2YxcUN6STRmUnM3Q3NodWYrd1k4d2srQWFTZzF5bHVz?= =?utf-8?B?ZjIwRS9FcDE4b2tFOWFaS1d4YXVHOUozR3hJdnJLaVA5QTBLSTZsaVF3NjVY?= =?utf-8?B?dm12Z2VZSmdVc0JNOU5TUWdYWGFuL2hsN0dDNVFBQjBGV1JLKzNJQ1QrbFVm?= =?utf-8?B?ZWpPQmlHeGkrQXJsUkxHSVI5d3FNcktGVzJJOEFKUmxCK3ZJdm4vcGs4dXEy?= =?utf-8?B?NStoTXJ6V3RZTFBoajQ5eU9lSDduTFNsMUtzVjFCYUxUcHRYVkZScVRSbU1q?= =?utf-8?B?R0trbkh6bG0yQjh5Z05nN2hNVGtpcm94UDIrMm9CY3Y5ZFcvQlRDc1RHQVhv?= =?utf-8?B?QzhtT1NMTXJMb1k0bjg0cDV4UTdSYThyZDdpMTVTL29ka1NrOEhLb0ZkOWVw?= =?utf-8?Q?vTuQn0cgP/mGbHEaCS2lfwD9hwUgnRGVN6PJXfy?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: f6a492e3-d98c-4e25-f84f-08d98823f9f0 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 17:17:14.9407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OqRt88s7/9lIkuccR0D+KEmKYGc5gixtaYxUSJqkGlR1pMdVJjLJaQMYzqNcCVGTOrdURR/U7fwAEF6XJBSYv/mpGOIK0hmckvPkLOLG4mQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2579 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.10.21 09:12, Shawn Guo wrote: > On Thu, Sep 30, 2021 at 05:56:28PM +0200, Frieder Schrempf wrote: >> From: Frieder Schrempf >> >> The MCP2515 can be used with an SPI clock of up to 10 MHz. Set the >> limit accordingly to prevent any performance issues caused by the >> really low clock speed of 100 kHz. > > Could you share some testing result of this change? Without this change, receiving CAN messages on the board beyond a certain bitrate will cause overrun errors (see 'ip -det -stat link show can0'). With this fix, receiving messages on the bus works without any overrun errors for bitrates up to 1 MBit. > >> >> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") > > It's really an optimization rather than fix, isn't it? It removes the arbitrarily low limit on the SPI frequency, that was caused by a typo in the original dts. As the usage of the CAN bus is seriously affected by this I would consider it a fix. But if you think otherwise, feel free to remove the Fixes tag. > > Shawn > >> Cc: stable@vger.kernel.org >> Signed-off-by: Frieder Schrempf >> --- >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> index f2c8ccefd1bf..dbf11e03ecce 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> @@ -98,7 +98,7 @@ can0: can@0 { >> clocks = <&osc_can>; >> interrupt-parent = <&gpio4>; >> interrupts = <28 IRQ_TYPE_EDGE_FALLING>; >> - spi-max-frequency = <100000>; >> + spi-max-frequency = <10000000>; >> vdd-supply = <®_vdd_3v3>; >> xceiver-supply = <®_vdd_5v>; >> }; >> -- >> 2.33.0 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C0FC433F5 for ; Tue, 5 Oct 2021 17:19:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2E9C61381 for ; Tue, 5 Oct 2021 17:19:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2E9C61381 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From: References:Cc:To:Subject:Date:Message-ID:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1flTwJ/IBN3ickNz8G3Qq5YO0XHDXc+u+TCib3mLn+A=; b=yduPzTHjY1xo0cbPvAXdxQUEld tc0XT5Btv438Di7aOUryWx6IwxUGuJhUkcGL5NzSMICI2UypGunFBiqMUzrUh4JFu7ItRR/jbvMlf GtukuIJqgPpx/ld+8vNnTk/P8iGyAn5IBNZLeYx7L1zeeuYUENuIWh5/4fME3fbRSESkXQE+ybdEX KS7Y2nkQlOh2PyZmjdhR17gW9O1zg9uL1qiZl1Co4HUdY9W3Eer5Itn6QTRVv2EDAUpCw/APtr48p G0A1I0MEFWmUTlgSbD03ZOskv7Itn/TeBkGCLfHq6ILu9tyfyOsAEMJ3ezVVmRUQSAY/5kilObIn1 PkYn3pjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXo4A-00BPWY-IM; Tue, 05 Oct 2021 17:17:22 +0000 Received: from mail-vi1eur05on2112.outbound.protection.outlook.com ([40.107.21.112] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXo46-00BPVm-KW for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 17:17:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ekj9iRf4gSxOWKLsg3YU06Idr7e0rJY9ROqGH++eihLGNOoQdlT/zgkj9Cs4dlshtY5iqYhPPRUK1ZxXSCT2ZrqW6BXD3qqSF6e/qHWvFI+Idw0JsSNoPqozt/6e4vwMd9op0VMIi8v6w96uSWxmwMmWV0eotdmRxcPWTS72A55xRVTxk55qmWqjeJA7GGzEg19xxFzv1svm0uaf4ghHsHaYpdm90CYhCOllsdigOhNlT0ZaJUO2Z1XxIc7m1V2q9dDelFo/B5pm8nh9doEACR+yV+ju8y0NCm6oq2QMIpc1drSeD3Iw+A4VxTib0lWzusoFafiGOENnoKh2dKYetQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1gL9pa/96GcysYb4dnL81fj0rY0i8LVeYSxLGeVDaE=; b=T+YgIGfT/3VDU3QSfQzBL43FA5qZbiFnDYb1G/2CDEH9at1DjIbGlCBZ6x7p5Q4n6U9vQccy6JrdzqKSytjrHxkaO5twysTH3KfW4XM+HdMv7MGVdlj7Hik+uPFz3FvFBJfBGb/BmTkqcT/Nkkz1jExmX4cjQEfjvf3+ivJc3BLiejvxwPqT1bvVtrgtsleDYnZKP6OOplVsAPZ9sq7hEM2xfk8yJEg8A3Cnw5rPHVJ8J4nHKpWseBdtOxIqTHtDb/RRqIoB2hsyNTy9zd9b1ZObklvEJwCMvRT+tYtLU+tD4SxGFN3LjvK524S9W802SY4e9o42Iw5ulYAeCkXcVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1gL9pa/96GcysYb4dnL81fj0rY0i8LVeYSxLGeVDaE=; b=EzA96OSOViZPXZevJ481D773I423SYKblfq+5cG6XkW51B3JjPaEbSYZY4zF6YhVtL03KZrHi4yir/wbbtuEZ0OTrWs7VsBmZ5FBQJ4njoY7N9MyJsHQEJAJgenoUj+/g2kSbyyLJL9UIyv09oQ8k0Z5LzWmWDoS73OhGc6PlkU= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=kontron.de; Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) by AM0PR10MB2579.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct 2021 17:17:15 +0000 Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::216b:62be:3272:2560]) by AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::216b:62be:3272:2560%6]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 17:17:15 +0000 Message-ID: <37c1845d-9323-3187-ed0b-b9795758649d@kontron.de> Date: Tue, 5 Oct 2021 19:17:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 5/8] arm64: dts: imx8mm-kontron: Fix CAN SPI clock frequency Content-Language: en-US To: Shawn Guo , Frieder Schrempf Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-6-frieder@fris.de> <20211005071230.GC20743@dragon> From: Frieder Schrempf In-Reply-To: <20211005071230.GC20743@dragon> X-ClientProxiedBy: AS8P250CA0011.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::16) To AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) MIME-Version: 1.0 Received: from [192.168.10.40] (88.130.78.70) by AS8P250CA0011.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 17:17:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6a492e3-d98c-4e25-f84f-08d98823f9f0 X-MS-TrafficTypeDiagnostic: AM0PR10MB2579: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kv2N4fvr9RM8fOBvrIJFZn6PHMIc+uJfuDP+yS164Si/4So35ncDGwpNegC62fGAM6kvPAnZz/tH9ZJ3ngiCr8qJW76mcLppEw+GsytDbUo+rSKwTRpZvSrD5JU51uJ1ZVlLD8KzETyd9anU0lBMhU8C3eMnKUUHvS7Iec46bGaPiNhrZ6So9+4KeMeD8TdqSnEjmDGLWJ7xWWRMPrRkCBUY844mzfFkraNVa6k5o/87yQsCIzEk8K7IVdjv8x7sI/0zWZpDXAvsHDdnI4KHEDpL1A3JoyyXltejSvvkWXeGEpjajiO/xmLZ27XV5xCIcuFaHT1sc6ULYl480+hJEuRaZR1OvkMXqK6n7qKrqerQAirCOt1CBACjVaKc2OTfuGKyn2iEAZg9XDgksGIc6hWkLQMw16M4tVdypTMF/U/+CWp4MA+NlcYu2UMHdo3+j2jKla0+Vox5v2bGbrgyiOCO9GXMt7THtJUdMiXcXOQXFpu4RhRZ/lOTkLzRK1lHvlQvTFQ6YvPvGOiP7BqCykjiDNANgWsLRsIEUY0maZo4afaDC8pJCvVy1AKURJDRK/u8c6gD4WbffMAGvRxr2sPFbWGLy1tuaOf/J2b5tNjol6v2yKfJDoQVq0MR7O+rEh/aJHa1DZQnx6x/ltF8adf6jVVvsfTWKg8QNZfTRRM/8N5WNEtvqw2vTBmWWa+5iHQ+cCndg3JSQYsljlwJ1ocE+5UDL0OeNhIoV/vd9mIn+PLyKu3svWV+To7frsFw8UwSPd4M3ewi+gjdhDwm1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(66556008)(26005)(2906002)(508600001)(66946007)(53546011)(86362001)(7416002)(8936002)(8676002)(186003)(5660300002)(38100700002)(83380400001)(4326008)(316002)(110136005)(16576012)(6486002)(54906003)(36756003)(31686004)(956004)(44832011)(2616005)(31696002)(32563001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2kyMXVBUDdmbnhPNnJ3bTFsWEpRU1JnUEZqa1B6KzFmdjRycFgxZTNpQ0lO?= =?utf-8?B?MlhxS2VkTFRyR3REdDE3bjQrQmU5MUxmckFUdkVTejE4MWFTNW0vMHF6bXo0?= =?utf-8?B?TVhrQTJuL2d4RXBtYmVnOThyRXVUYTJxbjNHZFVES3VQVlRleXl6UzBFdlJS?= =?utf-8?B?dU1CUmkrcjREOXdKQW1XWFdRWUpidlJnSURmTzJPLzRyN3hJbmNrZ0VvcXQw?= =?utf-8?B?T2dKWG5NeVN2c3ZFSklEZzdTRzVxUERqcXhvZmRqbUxnSkVsVnNJVElqcW51?= =?utf-8?B?TXJtWkFnMEd4dUFkbzNxdVgwQytuTXByR2lMQzFRMWM2THZVQUZIOEUzdjJI?= =?utf-8?B?MU03eGlSemYvdE96dUNuSTducWRoekdXakRiQXVETG9aUVBUOWthZ3FTWEds?= =?utf-8?B?allSbkxlN0FoS200Umw0VmsyNlJzK3g1M0VhRUh3Njgzb3c1b21scThZbHpI?= =?utf-8?B?UzVEZDhzT2w2WnBNVTNmemRJTzFadWdGNVJxRE9Fcm5jdnIvOEFYcDZwOWVN?= =?utf-8?B?WTg1UXMwUXFCaElUeGpYeFhYV0hZS1ZNazl5cC9DOXFuQnAxSWQxcW03akc2?= =?utf-8?B?MHk1M0ZPMmQrSHkzdDNLcWRnYWY4Wk4ySVV4UnhXWmNHSWNTNFdxamJ2N2wv?= =?utf-8?B?ekJVUFVORUdJQ3dZdkh0ZjZqcnJ6S0E5WG1ZLzRXNFRId24zalozNjgxTE5H?= =?utf-8?B?UTJqMFpCYjZvWC9tWUxZUkNFNFpCaGMvQm1YVFNYUGZpNnUyR1ZGQXlwdkVq?= =?utf-8?B?L0xXNFdxcWd2OW9mbmRvY2YvVlZnY2kxWFFMVkhXbDlQOUUvbTRqYkhJWFV6?= =?utf-8?B?RUsyc05td3dvN1BpeUNQNVRnRUhpdVZYNGxQTkQ4Z1RyWHRRK2xFK005UGtN?= =?utf-8?B?cjRaNmxDeGd1OU9Nb0ZhVTN1VGJJTnVtSGtLSjkxV25OSEcrcVNFSHFVek1x?= =?utf-8?B?aEJ5V2xrdVJXSmc0bmdMT0cwcUhDSjl0REk5eVNBWFdNSHB4UTlZUzd4L3Zh?= =?utf-8?B?R05rOGQ0VklDWC9McVRPa0FNT0w2NmJVVU9hN0NGbk55UG1GTmxNakhtUTVF?= =?utf-8?B?WldvYkUvR2NMVWlxME5OTkE3S1EyalBabEl2RGd1VTN5M3Zkc1BqbFlDUTJT?= =?utf-8?B?V0h2ZXFLSmZVNy9xdDJPbE5kQmxSYnZ6NUVUUWpDaUY5OVlhT3BWMk52NEww?= =?utf-8?B?RTF4UTJpM2IrNnZNbVJ2SnlGUVNpUXpIOWVmbWJPSHI5K0lhOW5VSDBIS0FI?= =?utf-8?B?Y2pnQjN6akJUV05YRytBTnVXYVFRNGlmVUtHNW40enZOUTYwUDhDY0dOSWtv?= =?utf-8?B?RzhwK1lDODZYVGpVd2YxcUN6STRmUnM3Q3NodWYrd1k4d2srQWFTZzF5bHVz?= =?utf-8?B?ZjIwRS9FcDE4b2tFOWFaS1d4YXVHOUozR3hJdnJLaVA5QTBLSTZsaVF3NjVY?= =?utf-8?B?dm12Z2VZSmdVc0JNOU5TUWdYWGFuL2hsN0dDNVFBQjBGV1JLKzNJQ1QrbFVm?= =?utf-8?B?ZWpPQmlHeGkrQXJsUkxHSVI5d3FNcktGVzJJOEFKUmxCK3ZJdm4vcGs4dXEy?= =?utf-8?B?NStoTXJ6V3RZTFBoajQ5eU9lSDduTFNsMUtzVjFCYUxUcHRYVkZScVRSbU1q?= =?utf-8?B?R0trbkh6bG0yQjh5Z05nN2hNVGtpcm94UDIrMm9CY3Y5ZFcvQlRDc1RHQVhv?= =?utf-8?B?QzhtT1NMTXJMb1k0bjg0cDV4UTdSYThyZDdpMTVTL29ka1NrOEhLb0ZkOWVw?= =?utf-8?Q?vTuQn0cgP/mGbHEaCS2lfwD9hwUgnRGVN6PJXfy?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: f6a492e3-d98c-4e25-f84f-08d98823f9f0 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 17:17:14.9407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OqRt88s7/9lIkuccR0D+KEmKYGc5gixtaYxUSJqkGlR1pMdVJjLJaQMYzqNcCVGTOrdURR/U7fwAEF6XJBSYv/mpGOIK0hmckvPkLOLG4mQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2579 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_101718_716178_2C65EF70 X-CRM114-Status: GOOD ( 20.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05.10.21 09:12, Shawn Guo wrote: > On Thu, Sep 30, 2021 at 05:56:28PM +0200, Frieder Schrempf wrote: >> From: Frieder Schrempf >> >> The MCP2515 can be used with an SPI clock of up to 10 MHz. Set the >> limit accordingly to prevent any performance issues caused by the >> really low clock speed of 100 kHz. > > Could you share some testing result of this change? Without this change, receiving CAN messages on the board beyond a certain bitrate will cause overrun errors (see 'ip -det -stat link show can0'). With this fix, receiving messages on the bus works without any overrun errors for bitrates up to 1 MBit. > >> >> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") > > It's really an optimization rather than fix, isn't it? It removes the arbitrarily low limit on the SPI frequency, that was caused by a typo in the original dts. As the usage of the CAN bus is seriously affected by this I would consider it a fix. But if you think otherwise, feel free to remove the Fixes tag. > > Shawn > >> Cc: stable@vger.kernel.org >> Signed-off-by: Frieder Schrempf >> --- >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> index f2c8ccefd1bf..dbf11e03ecce 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> @@ -98,7 +98,7 @@ can0: can@0 { >> clocks = <&osc_can>; >> interrupt-parent = <&gpio4>; >> interrupts = <28 IRQ_TYPE_EDGE_FALLING>; >> - spi-max-frequency = <100000>; >> + spi-max-frequency = <10000000>; >> vdd-supply = <®_vdd_3v3>; >> xceiver-supply = <®_vdd_5v>; >> }; >> -- >> 2.33.0 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel