* [PATCH] kselftest/cgroup: fix a signedness bug
@ 2018-06-07 8:30 ` dan.carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2018-06-07 8:30 UTC (permalink / raw)
To: kernel-janitors
"len" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
index b69bdeb4b9fe..1e9e3c470561 100644
--- a/tools/testing/selftests/cgroup/cgroup_util.c
+++ b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
return len;
}
-static ssize_t write_text(const char *path, char *buf, size_t len)
+static ssize_t write_text(const char *path, char *buf, ssize_t len)
{
int fd;
@@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
int cg_write(const char *cgroup, const char *control, char *buf)
{
char path[PATH_MAX];
- size_t len = strlen(buf);
+ ssize_t len = strlen(buf);
snprintf(path, sizeof(path), "%s/%s", cgroup, control);
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] kselftest/cgroup: fix a signedness bug
@ 2018-06-07 8:30 ` dan.carpenter
0 siblings, 0 replies; 9+ messages in thread
From: dan.carpenter @ 2018-06-07 8:30 UTC (permalink / raw)
"len" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
index b69bdeb4b9fe..1e9e3c470561 100644
--- a/tools/testing/selftests/cgroup/cgroup_util.c
+++ b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
return len;
}
-static ssize_t write_text(const char *path, char *buf, size_t len)
+static ssize_t write_text(const char *path, char *buf, ssize_t len)
{
int fd;
@@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
int cg_write(const char *cgroup, const char *control, char *buf)
{
char path[PATH_MAX];
- size_t len = strlen(buf);
+ ssize_t len = strlen(buf);
snprintf(path, sizeof(path), "%s/%s", cgroup, control);
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] kselftest/cgroup: fix a signedness bug
@ 2018-06-07 8:30 ` dan.carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2018-06-07 8:30 UTC (permalink / raw)
"len" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
index b69bdeb4b9fe..1e9e3c470561 100644
--- a/tools/testing/selftests/cgroup/cgroup_util.c
+++ b/tools/testing/selftests/cgroup/cgroup_util.c
@@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
return len;
}
-static ssize_t write_text(const char *path, char *buf, size_t len)
+static ssize_t write_text(const char *path, char *buf, ssize_t len)
{
int fd;
@@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
int cg_write(const char *cgroup, const char *control, char *buf)
{
char path[PATH_MAX];
- size_t len = strlen(buf);
+ ssize_t len = strlen(buf);
snprintf(path, sizeof(path), "%s/%s", cgroup, control);
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] kselftest/cgroup: fix a signedness bug
2018-06-07 8:30 ` dan.carpenter
(?)
@ 2018-06-07 12:52 ` guro
-1 siblings, 0 replies; 9+ messages in thread
From: Roman Gushchin @ 2018-06-07 12:52 UTC (permalink / raw)
To: kernel-janitors
On Thu, Jun 07, 2018 at 11:30:02AM +0300, Dan Carpenter wrote:
> "len" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
> index b69bdeb4b9fe..1e9e3c470561 100644
> --- a/tools/testing/selftests/cgroup/cgroup_util.c
> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
> @@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
> return len;
> }
>
> -static ssize_t write_text(const char *path, char *buf, size_t len)
> +static ssize_t write_text(const char *path, char *buf, ssize_t len)
> {
> int fd;
>
> @@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
> int cg_write(const char *cgroup, const char *control, char *buf)
> {
> char path[PATH_MAX];
> - size_t len = strlen(buf);
> + ssize_t len = strlen(buf);
>
> snprintf(path, sizeof(path), "%s/%s", cgroup, control);
>
Looks good to me!
Thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] kselftest/cgroup: fix a signedness bug
@ 2018-06-07 12:52 ` guro
0 siblings, 0 replies; 9+ messages in thread
From: guro @ 2018-06-07 12:52 UTC (permalink / raw)
On Thu, Jun 07, 2018 at 11:30:02AM +0300, Dan Carpenter wrote:
> "len" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
> index b69bdeb4b9fe..1e9e3c470561 100644
> --- a/tools/testing/selftests/cgroup/cgroup_util.c
> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
> @@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
> return len;
> }
>
> -static ssize_t write_text(const char *path, char *buf, size_t len)
> +static ssize_t write_text(const char *path, char *buf, ssize_t len)
> {
> int fd;
>
> @@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
> int cg_write(const char *cgroup, const char *control, char *buf)
> {
> char path[PATH_MAX];
> - size_t len = strlen(buf);
> + ssize_t len = strlen(buf);
>
> snprintf(path, sizeof(path), "%s/%s", cgroup, control);
>
Looks good to me!
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] kselftest/cgroup: fix a signedness bug
@ 2018-06-07 12:52 ` guro
0 siblings, 0 replies; 9+ messages in thread
From: Roman Gushchin @ 2018-06-07 12:52 UTC (permalink / raw)
On Thu, Jun 07, 2018@11:30:02AM +0300, Dan Carpenter wrote:
> "len" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
> index b69bdeb4b9fe..1e9e3c470561 100644
> --- a/tools/testing/selftests/cgroup/cgroup_util.c
> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
> @@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
> return len;
> }
>
> -static ssize_t write_text(const char *path, char *buf, size_t len)
> +static ssize_t write_text(const char *path, char *buf, ssize_t len)
> {
> int fd;
>
> @@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
> int cg_write(const char *cgroup, const char *control, char *buf)
> {
> char path[PATH_MAX];
> - size_t len = strlen(buf);
> + ssize_t len = strlen(buf);
>
> snprintf(path, sizeof(path), "%s/%s", cgroup, control);
>
Looks good to me!
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kselftest/cgroup: fix a signedness bug
2018-06-07 12:52 ` guro
(?)
@ 2018-06-07 19:46 ` shuah
-1 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2018-06-07 19:46 UTC (permalink / raw)
To: kernel-janitors
On 06/07/2018 06:52 AM, Roman Gushchin wrote:
> On Thu, Jun 07, 2018 at 11:30:02AM +0300, Dan Carpenter wrote:
>> "len" needs to be signed for the error handling to work.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
>> index b69bdeb4b9fe..1e9e3c470561 100644
>> --- a/tools/testing/selftests/cgroup/cgroup_util.c
>> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
>> @@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
>> return len;
>> }
>>
>> -static ssize_t write_text(const char *path, char *buf, size_t len)
>> +static ssize_t write_text(const char *path, char *buf, ssize_t len)
>> {
>> int fd;
>>
>> @@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
>> int cg_write(const char *cgroup, const char *control, char *buf)
>> {
>> char path[PATH_MAX];
>> - size_t len = strlen(buf);
>> + ssize_t len = strlen(buf);
>>
>> snprintf(path, sizeof(path), "%s/%s", cgroup, control);
>>
>
> Looks good to me!
>
> Thanks!
>
Thanks. Is it now in linux-kselftest next. I will send this up next week
for second update for 4.18-rc1
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] kselftest/cgroup: fix a signedness bug
@ 2018-06-07 19:46 ` shuah
0 siblings, 0 replies; 9+ messages in thread
From: shuah @ 2018-06-07 19:46 UTC (permalink / raw)
On 06/07/2018 06:52 AM, Roman Gushchin wrote:
> On Thu, Jun 07, 2018 at 11:30:02AM +0300, Dan Carpenter wrote:
>> "len" needs to be signed for the error handling to work.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>>
>> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
>> index b69bdeb4b9fe..1e9e3c470561 100644
>> --- a/tools/testing/selftests/cgroup/cgroup_util.c
>> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
>> @@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
>> return len;
>> }
>>
>> -static ssize_t write_text(const char *path, char *buf, size_t len)
>> +static ssize_t write_text(const char *path, char *buf, ssize_t len)
>> {
>> int fd;
>>
>> @@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
>> int cg_write(const char *cgroup, const char *control, char *buf)
>> {
>> char path[PATH_MAX];
>> - size_t len = strlen(buf);
>> + ssize_t len = strlen(buf);
>>
>> snprintf(path, sizeof(path), "%s/%s", cgroup, control);
>>
>
> Looks good to me!
>
> Thanks!
>
Thanks. Is it now in linux-kselftest next. I will send this up next week
for second update for 4.18-rc1
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] kselftest/cgroup: fix a signedness bug
@ 2018-06-07 19:46 ` shuah
0 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2018-06-07 19:46 UTC (permalink / raw)
On 06/07/2018 06:52 AM, Roman Gushchin wrote:
> On Thu, Jun 07, 2018@11:30:02AM +0300, Dan Carpenter wrote:
>> "len" needs to be signed for the error handling to work.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>>
>> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
>> index b69bdeb4b9fe..1e9e3c470561 100644
>> --- a/tools/testing/selftests/cgroup/cgroup_util.c
>> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
>> @@ -35,7 +35,7 @@ static ssize_t read_text(const char *path, char *buf, size_t max_len)
>> return len;
>> }
>>
>> -static ssize_t write_text(const char *path, char *buf, size_t len)
>> +static ssize_t write_text(const char *path, char *buf, ssize_t len)
>> {
>> int fd;
>>
>> @@ -140,7 +140,7 @@ long cg_read_key_long(const char *cgroup, const char *control, const char *key)
>> int cg_write(const char *cgroup, const char *control, char *buf)
>> {
>> char path[PATH_MAX];
>> - size_t len = strlen(buf);
>> + ssize_t len = strlen(buf);
>>
>> snprintf(path, sizeof(path), "%s/%s", cgroup, control);
>>
>
> Looks good to me!
>
> Thanks!
>
Thanks. Is it now in linux-kselftest next. I will send this up next week
for second update for 4.18-rc1
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-06-07 19:46 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-07 8:30 [PATCH] kselftest/cgroup: fix a signedness bug Dan Carpenter
2018-06-07 8:30 ` Dan Carpenter
2018-06-07 8:30 ` dan.carpenter
2018-06-07 12:52 ` Roman Gushchin
2018-06-07 12:52 ` Roman Gushchin
2018-06-07 12:52 ` guro
2018-06-07 19:46 ` Shuah Khan
2018-06-07 19:46 ` Shuah Khan
2018-06-07 19:46 ` shuah
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.