From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78369C433ED for ; Mon, 3 May 2021 20:10:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 715AC611AB for ; Mon, 3 May 2021 20:10:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 715AC611AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eldorado.org.br Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldeu8-0003az-HW for qemu-devel@archiver.kernel.org; Mon, 03 May 2021 16:10:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldeqc-0001xH-M8; Mon, 03 May 2021 16:07:18 -0400 Received: from [201.28.113.2] (port=48878 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldeqY-0002OU-53; Mon, 03 May 2021 16:07:17 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Mon, 3 May 2021 17:07:08 -0300 Received: from [127.0.0.1] (unknown [10.10.71.235]) by power9a (Postfix) with ESMTPS id B247380134C; Mon, 3 May 2021 17:07:07 -0300 (-03) Subject: Re: [PATCH v3 2/7] target/ppc: Isolated SPR read/write callbacks To: Richard Henderson , qemu-devel@nongnu.org References: <20210430193533.82136-1-bruno.larsen@eldorado.org.br> <20210430193533.82136-3-bruno.larsen@eldorado.org.br> From: Bruno Piazera Larsen Message-ID: <37ce51b1-df0c-6848-ba53-34f47954c7c2@eldorado.org.br> Date: Mon, 3 May 2021 17:07:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------D9592B947D17DFDD73769C74" Content-Language: en-US X-OriginalArrivalTime: 03 May 2021 20:07:08.0093 (UTC) FILETIME=[E51CEED0:01D74057] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=bruno.larsen@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, luis.pires@eldorado.org.br, lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------D9592B947D17DFDD73769C74 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 30/04/2021 21:55, Richard Henderson wrote: > On 4/30/21 12:35 PM, Bruno Larsen (billionai) wrote: >> Moved all SPR read/write callback, and some related functions, to a >> new file specific for it. These callbacks are TCG only, so separating >> them is required to support the build flag disable-tcg. >> >> Making the spr_noaccess function not static, and moving the define to >> internal.h is required, otherwise the project doesn't build > > Why is that?  You're moving the code to a different file, but then > including that file back into the same translation unit.  There should > be no change in which symbols appear in which object file. > > I think that the spr_noaccess move might be required by patch 7, but > that's something different. > ah, yes, forgot to specify why. gen_op_mfspr uses SPR_NOACCESS on line 4284. At some point I thought I tried to include spr_tcg.c.inc before that function and the compilation failed, so I decided to include it where translate_init.c.inc was included. I think it was another function that was declared later, but can't remember which Testing now I verified that I can include it there, so I will do it and delay the move to patch 7, no problem > > r~ -- Bruno Piazera Larsen Instituto de Pesquisas ELDORADO Departamento Computação Embarcada Analista de Software Trainee Aviso Legal - Disclaimer --------------D9592B947D17DFDD73769C74 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 30/04/2021 21:55, Richard Henderson wrote:
On 4/30/21 12:35 PM, Bruno Larsen (billionai) wrote:
Moved all SPR read/write callback, and some related functions, to a
new file specific for it. These callbacks are TCG only, so separating
them is required to support the build flag disable-tcg.

Making the spr_noaccess function not static, and moving the define to
internal.h is required, otherwise the project doesn't build

Why is that?  You're moving the code to a different file, but then including that file back into the same translation unit.  There should be no change in which symbols appear in which object file.

I think that the spr_noaccess move might be required by patch 7, but that's something different.

ah, yes, forgot to specify why. gen_op_mfspr uses SPR_NOACCESS on line 4284. At some point I thought I tried to include spr_tcg.c.inc before that function and the compilation failed, so I decided to include it where translate_init.c.inc was included. I think it was another function that was declared later, but can't remember which

Testing now I verified that I can include it there, so I will do it and delay the move to patch 7, no problem


r~
--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer
--------------D9592B947D17DFDD73769C74--