From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wei.liu2@citrix.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"George Dunlap" <George.Dunlap@eu.citrix.com>,
"Tim Deegan" <tim@xen.org>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"Julien Grall" <julien.grall@arm.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v3 3/3] xen: add CONFIG item for default dom0 memory size
Date: Fri, 18 Jan 2019 14:19:16 +0100 [thread overview]
Message-ID: <37d17bc3-0fe8-44eb-51dd-b2a764c6a323@suse.com> (raw)
In-Reply-To: <e534b651-5d0b-34fb-0f79-9f02ce6d91c4@citrix.com>
On 18/01/2019 14:13, Andrew Cooper wrote:
> On 10/12/2018 11:44, Juergen Gross wrote:
>> With being able to specify a dom0_mem value depending on host memory
>> size on x86 make it easy for distros to specify a default dom0 size by
>> adding a CONFIG_DOM0_MEM item which presets the dom0_mem boot parameter
>> value.
>>
>> It will be used only if no dom0_mem parameter was specified in the
>> boot parameters.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> Why was this patch accepted? We've already got a suitable Kconfig
> option for this, CONFIG_CMDLINE.
Why do we have a config option for the default scheduler?
And something like:
dom0_mem=max:8G dom0_mem=10%
is different from
CONFIG_DOM0_MEM="max:8G" plus dom0_mem=10%
on a host with say 100G of memory: In the first case this would be 8G,
in the second case 10G.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-18 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 11:44 [PATCH v3 0/3] xen/x86: support setting dom0_mem depending on host size Juergen Gross
2018-12-10 11:44 ` [PATCH v3 1/3] xen: modify parse_size_and_unit() to support percentage Juergen Gross
2018-12-10 14:39 ` Jan Beulich
2018-12-10 11:44 ` [PATCH v3 2/3] xen/x86: add dom0 memory sizing variants Juergen Gross
2018-12-10 14:45 ` Jan Beulich
[not found] ` <5C0E7BF80200007800204B94@suse.com>
2018-12-10 14:52 ` Juergen Gross
2018-12-10 11:44 ` [PATCH v3 3/3] xen: add CONFIG item for default dom0 memory size Juergen Gross
2018-12-14 15:32 ` Julien Grall
2019-01-18 13:13 ` Andrew Cooper
2019-01-18 13:19 ` Juergen Gross [this message]
2019-01-18 13:44 ` Andrew Cooper
2019-01-18 14:08 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37d17bc3-0fe8-44eb-51dd-b2a764c6a323@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.