All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Semashev <andrey.semashev@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 2/2] avrcp: Don't attempt to load settings if on volume changed is supported
Date: Fri, 29 May 2020 02:10:48 +0300	[thread overview]
Message-ID: <37d5cdb5-4d05-ce02-ce5a-f53bff81bd31@gmail.com> (raw)
In-Reply-To: <20200528215300.225894-2-luiz.dentz@gmail.com>

On 2020-05-29 00:53, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If only volume changed is supported that means the player cannot really
> indicate track/metadata changes so don't attempt to read them.
> ---
>   profiles/audio/avrcp.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 75811bf98..8b3debe46 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -3814,6 +3814,10 @@ static gboolean avrcp_get_capabilities_resp(struct avctp *conn, uint8_t code,
>   	if (!session->controller || !session->controller->player)
>   		return FALSE;
>   
> +	/* Skip if player status/metadata if only volume changes is supported */
> +	if (events == (1 << AVRCP_EVENT_VOLUME_CHANGED))
> +		return FALSE;
> +
>   	if ((session->controller->features & AVRCP_FEATURE_PLAYER_SETTINGS) &&
>   			!(events & (1 << AVRCP_EVENT_SETTINGS_CHANGED)))
>   		avrcp_list_player_attributes(session);
> 

This patchset works, MTW2 is able to connect and play audio. Many thanks!

  reply	other threads:[~2020-05-28 23:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 21:52 [PATCH v3 1/2] avrcp: Fix always requesting player settings for category 1 Luiz Augusto von Dentz
2020-05-28 21:53 ` [PATCH v3 2/2] avrcp: Don't attempt to load settings if on volume changed is supported Luiz Augusto von Dentz
2020-05-28 23:10   ` Andrey Semashev [this message]
2020-05-29 20:29 ` [PATCH v3 1/2] avrcp: Fix always requesting player settings for category 1 Luiz Augusto von Dentz
2020-05-29 20:56   ` Andrey Semashev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37d5cdb5-4d05-ce02-ce5a-f53bff81bd31@gmail.com \
    --to=andrey.semashev@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.