From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCHv5 06/14] remoteproc/omap: Initialize and assign reserved memory node References: <20200116135332.7819-1-t-kristo@ti.com> <20200116135332.7819-7-t-kristo@ti.com> <249c293c-6a23-165f-1df5-4859ee47658a@ti.com> From: Tero Kristo Message-ID: <37db5d57-b1cd-1cec-2c9b-31c49e3bdc10@ti.com> Date: Thu, 30 Jan 2020 21:18:52 +0200 MIME-Version: 1.0 In-Reply-To: <249c293c-6a23-165f-1df5-4859ee47658a@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: "Andrew F. Davis" , bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, s-anna@ti.com, linux-omap@vger.kernel.org List-ID: On 30/01/2020 20:11, Andrew F. Davis wrote: > On 1/16/20 8:53 AM, Tero Kristo wrote: >> From: Suman Anna >> >> The reserved memory nodes are not assigned to platform devices by >> default in the driver core to avoid the lookup for every platform >> device and incur a penalty as the real users are expected to be >> only a few devices. >> >> OMAP remoteproc devices fall into the above category and the OMAP >> remoteproc driver _requires_ specific CMA pools to be assigned >> for each device at the moment to align on the location of the >> vrings and vring buffers in the RTOS-side firmware images. So, > > > Same comment as before, this is a firmware issue for only some firmwares > that do not handle being assigned vring locations correctly and instead > hard-code them. I believe we discussed this topic in length in previous version but there was no conclusion on it. The commit desc might be a bit misleading, we are not actually forced to use specific CMA buffers, as we use IOMMU to map these to device addresses. For example IPU1/IPU2 use internally exact same memory addresses, iommu is used to map these to specific CMA buffer. CMA buffers are mostly used so that we get aligned large chunk of memory which can be mapped properly with the limited IOMMU OMAP family of chips have. Not sure if there is any sane way to get this done in any other manner. -Tero > > This is not a requirement of the remote processor itself and so it > should not fail to probe if a specific memory carveout isn't given. > > >> use the of_reserved_mem_device_init/release() API appropriately >> to assign the corresponding reserved memory region to the OMAP >> remoteproc device. Note that only one region per device is >> allowed by the framework. >> >> Signed-off-by: Suman Anna >> Signed-off-by: Tero Kristo >> Reviewed-by: Bjorn Andersson >> --- >> v5: no changes >> >> drivers/remoteproc/omap_remoteproc.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c >> index 0846839b2c97..194303b860b2 100644 >> --- a/drivers/remoteproc/omap_remoteproc.c >> +++ b/drivers/remoteproc/omap_remoteproc.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -480,14 +481,22 @@ static int omap_rproc_probe(struct platform_device *pdev) >> if (ret) >> goto free_rproc; >> >> + ret = of_reserved_mem_device_init(&pdev->dev); >> + if (ret) { >> + dev_err(&pdev->dev, "device does not have specific CMA pool\n"); >> + goto free_rproc; >> + } >> + >> platform_set_drvdata(pdev, rproc); >> >> ret = rproc_add(rproc); >> if (ret) >> - goto free_rproc; >> + goto release_mem; >> >> return 0; >> >> +release_mem: >> + of_reserved_mem_device_release(&pdev->dev); >> free_rproc: >> rproc_free(rproc); >> return ret; >> @@ -499,6 +508,7 @@ static int omap_rproc_remove(struct platform_device *pdev) >> >> rproc_del(rproc); >> rproc_free(rproc); >> + of_reserved_mem_device_release(&pdev->dev); >> >> return 0; >> } >> -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79C1C2D0DB for ; Thu, 30 Jan 2020 19:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79020206D3 for ; Thu, 30 Jan 2020 19:18:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="M7iy5tO0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727744AbgA3TS5 (ORCPT ); Thu, 30 Jan 2020 14:18:57 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:41594 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727400AbgA3TS5 (ORCPT ); Thu, 30 Jan 2020 14:18:57 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 00UJIuRr106609; Thu, 30 Jan 2020 13:18:56 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1580411936; bh=wdTBVFk9af+5181QMMgprWeO90o2Vtdv8glzZOzDVhs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=M7iy5tO0rzyJIDugMAF1uSYZ3gyYHiqYHD1rOXpeVu17/FcwJaNLWmIJYUeSJFGPZ pot3krvLQhUxJMPctIC9ZI88ed+/Wx8GAchWtfNB1vksVM0oS79V73yEh2w5m1mPK3 +15OXGt0F1LOC9u5zZ6LQuB4ITkT+huEJ6KmWHMM= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 00UJItwM087385 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Jan 2020 13:18:55 -0600 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 30 Jan 2020 13:18:55 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 30 Jan 2020 13:18:55 -0600 Received: from [127.0.0.1] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 00UJIrq3092024; Thu, 30 Jan 2020 13:18:53 -0600 Subject: Re: [PATCHv5 06/14] remoteproc/omap: Initialize and assign reserved memory node To: "Andrew F. Davis" , , , CC: , , , References: <20200116135332.7819-1-t-kristo@ti.com> <20200116135332.7819-7-t-kristo@ti.com> <249c293c-6a23-165f-1df5-4859ee47658a@ti.com> From: Tero Kristo Message-ID: <37db5d57-b1cd-1cec-2c9b-31c49e3bdc10@ti.com> Date: Thu, 30 Jan 2020 21:18:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <249c293c-6a23-165f-1df5-4859ee47658a@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/2020 20:11, Andrew F. Davis wrote: > On 1/16/20 8:53 AM, Tero Kristo wrote: >> From: Suman Anna >> >> The reserved memory nodes are not assigned to platform devices by >> default in the driver core to avoid the lookup for every platform >> device and incur a penalty as the real users are expected to be >> only a few devices. >> >> OMAP remoteproc devices fall into the above category and the OMAP >> remoteproc driver _requires_ specific CMA pools to be assigned >> for each device at the moment to align on the location of the >> vrings and vring buffers in the RTOS-side firmware images. So, > > > Same comment as before, this is a firmware issue for only some firmwares > that do not handle being assigned vring locations correctly and instead > hard-code them. I believe we discussed this topic in length in previous version but there was no conclusion on it. The commit desc might be a bit misleading, we are not actually forced to use specific CMA buffers, as we use IOMMU to map these to device addresses. For example IPU1/IPU2 use internally exact same memory addresses, iommu is used to map these to specific CMA buffer. CMA buffers are mostly used so that we get aligned large chunk of memory which can be mapped properly with the limited IOMMU OMAP family of chips have. Not sure if there is any sane way to get this done in any other manner. -Tero > > This is not a requirement of the remote processor itself and so it > should not fail to probe if a specific memory carveout isn't given. > > >> use the of_reserved_mem_device_init/release() API appropriately >> to assign the corresponding reserved memory region to the OMAP >> remoteproc device. Note that only one region per device is >> allowed by the framework. >> >> Signed-off-by: Suman Anna >> Signed-off-by: Tero Kristo >> Reviewed-by: Bjorn Andersson >> --- >> v5: no changes >> >> drivers/remoteproc/omap_remoteproc.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c >> index 0846839b2c97..194303b860b2 100644 >> --- a/drivers/remoteproc/omap_remoteproc.c >> +++ b/drivers/remoteproc/omap_remoteproc.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -480,14 +481,22 @@ static int omap_rproc_probe(struct platform_device *pdev) >> if (ret) >> goto free_rproc; >> >> + ret = of_reserved_mem_device_init(&pdev->dev); >> + if (ret) { >> + dev_err(&pdev->dev, "device does not have specific CMA pool\n"); >> + goto free_rproc; >> + } >> + >> platform_set_drvdata(pdev, rproc); >> >> ret = rproc_add(rproc); >> if (ret) >> - goto free_rproc; >> + goto release_mem; >> >> return 0; >> >> +release_mem: >> + of_reserved_mem_device_release(&pdev->dev); >> free_rproc: >> rproc_free(rproc); >> return ret; >> @@ -499,6 +508,7 @@ static int omap_rproc_remove(struct platform_device *pdev) >> >> rproc_del(rproc); >> rproc_free(rproc); >> + of_reserved_mem_device_release(&pdev->dev); >> >> return 0; >> } >> -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki