Re: [PATCH] optoe: driver to read/write SFP/QSFP EEPROMs

From: Randy Dunlap <rdunlap@infradead.org>
To: Don Bollinger <don@thebollingers.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Cc: brandon_chuang@edge-core.com, wally_wang@accton.com,
	roy_lee@edge-core.com, rick_burchett@edge-core.com,
	quentin.chang@quantatw.com, jeffrey.townsend@bitswitch.com,
	scotte@cumulusnetworks.com, roopa@cumulusnetworks.com,
	David Ahern <dsa@cumulusnetworks.com>,
	luke.williams@canonical.com, Guohan Lu <gulv@microsoft.com>,
	Xin Liu <xinxliu@microsoft.com>,
	steve.joiner@finisar.com
Subject: Re: [PATCH] optoe: driver to read/write SFP/QSFP EEPROMs
Date: Sun, 10 Jun 2018 21:56:00 -0700	[thread overview]
Message-ID: <37dfd504-5921-54f2-b90e-a26595fc0a5e@infradead.org> (raw)
In-Reply-To: <20180611042515.ml6zbcmz6dlvjmrp@thebollingers.org>

Hi,

On 06/10/2018 09:25 PM, Don Bollinger wrote:
> diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
> index 68a1ac929917..9a08e12756ee 100644
> --- a/drivers/misc/eeprom/Kconfig
> +++ b/drivers/misc/eeprom/Kconfig
> @@ -111,4 +111,22 @@ config EEPROM_IDT_89HPESX
>  	  This driver can also be built as a module. If so, the module
>  	  will be called idt_89hpesx.
>  
> +config EEPROM_OPTOE
> +	tristate "read/write access to SFP* & QSFP* EEPROMs"
> +	depends on I2C && SYSFS
> +	help
> +	  If you say yes here you get support for read and write access to
> +	  the EEPROM of SFP and QSFP type optical and copper transceivers.
> +	  Includes all devices which conform to the sff-8436 and sff-8472

	  This includes
and then please s/sff/SFF/ (2 places).

> +	  spec including SFP, SFP+, SFP28, SFP-DWDM, QSFP, QSFP+, QSFP28
> +	  or later.  These devices are usually found in network switches.
> +
> +	  This driver only manages read/write access to the EEPROM, all
> +	  other features should be accessed via i2c-dev.
> +
> +	  This driver can also be built as a module. If so, the module
> +	  will be called optoe.
> +
> +	  If unsure, say N.
> +
>  endmenu

thanks,
-- 
~Randy