From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36ACC433EF for ; Tue, 7 Sep 2021 15:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D901360C3E for ; Tue, 7 Sep 2021 15:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345228AbhIGP2w (ORCPT ); Tue, 7 Sep 2021 11:28:52 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:53825 "EHLO lizzard.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344974AbhIGP2u (ORCPT ); Tue, 7 Sep 2021 11:28:50 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 187FRYW0032695 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Sep 2021 17:27:34 +0200 Received: from [167.87.245.242] ([167.87.245.242]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 187FRXYv011004; Tue, 7 Sep 2021 17:27:33 +0200 Subject: Re: [PATCH 3/3] arm64: dts: ti: iot2050: Add support for product generation 2 boards To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bao Cheng Su , Chao Zeng References: <20210907151648.5z4hnlgppurheloz@stroller> From: Jan Kiszka Message-ID: <37f18b9e-f640-2642-2849-ed5b61493bfa@siemens.com> Date: Tue, 7 Sep 2021 17:27:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907151648.5z4hnlgppurheloz@stroller> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.09.21 17:16, Nishanth Menon wrote: > On 16:22-20210907, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Product Generations 1 and 2 differ in the SOC revision which requires >> separate device trees. >> >> Signed-off-by: Jan Kiszka >> --- >> arch/arm64/boot/dts/ti/Makefile | 2 + >> .../dts/ti/k3-am65-iot2050-common-pg1.dtsi | 46 ++++++++++++++++ >> .../dts/ti/k3-am65-iot2050-common-pg2.dtsi | 51 ++++++++++++++++++ >> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 35 +----------- >> ...ts => k3-am6528-iot2050-basic-common.dtsi} | 12 ++--- >> .../dts/ti/k3-am6528-iot2050-basic-pg2.dts | 21 ++++++++ >> .../boot/dts/ti/k3-am6528-iot2050-basic.dts | 53 ++----------------- >> ...=> k3-am6548-iot2050-advanced-common.dtsi} | 8 +-- >> .../dts/ti/k3-am6548-iot2050-advanced-pg2.dts | 26 +++++++++ >> .../dts/ti/k3-am6548-iot2050-advanced.dts | 52 ++---------------- >> 10 files changed, 161 insertions(+), 145 deletions(-) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg1.dtsi >> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg2.dtsi >> copy arch/arm64/boot/dts/ti/{k3-am6528-iot2050-basic.dts => k3-am6528-iot2050-basic-common.dtsi} (80%) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dts >> copy arch/arm64/boot/dts/ti/{k3-am6548-iot2050-advanced.dts => k3-am6548-iot2050-advanced-common.dtsi} (86%) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dts > > > Few things: > > a) Could you split this patch so that the refactoring for SR1 is the > first patch and then introduce the SR2? Can do, sure > b) Please call these as sr (silicon revision) rather than pg. Nope, this is only motivated by the SR1->SR2 switch. The new products are called "PG2", and that is what the DT name must reflect. Took me a while to grasp that as well. > c) usual request: Please add urls for the board Where should they go? I think there is only one reasonable to share: https://new.siemens.com/global/en/products/automation/pc-based/iot-gateways/simatic-iot2050.html If that is a stable link, I can't tell. Thanks Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2874C433EF for ; Tue, 7 Sep 2021 15:29:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAFC4610D0 for ; Tue, 7 Sep 2021 15:29:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AAFC4610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siemens.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=f+fO8P59HiCmhnLZ06ddddR177rknRf99Cs49Fv4mz8=; b=RZkik8NDpILI3eeqlZN0ofKH/2 lMi0WA2vwHthmzolZy6uluic4M9CuOJhMyxok8jCP7qGl8e3OeV9v29wXgWlzo1XIn6o0GE+kEh7i t/xLNPydMJpRx8m6qoOPFYMHxX12T+Wb6huUUQkbi+ghx1Fa8z3PJwagsalCProUFfkpbIR2uZdKS SRHBjVBrD4oxDuJef/g/xBNW5jlmoyzlweF75O+rECh5MI0FCG1aNnCQxT+J/PkrRB8MpKIsl3lgI uHHcMAfI2/LfID7qXY0CXJ+TO5x2YuqrFkWD8EAJPskhbPfZ50kjskoY7Co18l9xhntoJEu3VBUI5 0gNMGnOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNd0g-0043bx-A3; Tue, 07 Sep 2021 15:27:42 +0000 Received: from lizzard.sbs.de ([194.138.37.39]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNd0c-0043b5-Bo for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 15:27:40 +0000 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 187FRYW0032695 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Sep 2021 17:27:34 +0200 Received: from [167.87.245.242] ([167.87.245.242]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 187FRXYv011004; Tue, 7 Sep 2021 17:27:33 +0200 Subject: Re: [PATCH 3/3] arm64: dts: ti: iot2050: Add support for product generation 2 boards To: Nishanth Menon Cc: Tero Kristo , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bao Cheng Su , Chao Zeng References: <20210907151648.5z4hnlgppurheloz@stroller> From: Jan Kiszka Message-ID: <37f18b9e-f640-2642-2849-ed5b61493bfa@siemens.com> Date: Tue, 7 Sep 2021 17:27:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907151648.5z4hnlgppurheloz@stroller> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_082738_761022_AB2BFB06 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07.09.21 17:16, Nishanth Menon wrote: > On 16:22-20210907, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Product Generations 1 and 2 differ in the SOC revision which requires >> separate device trees. >> >> Signed-off-by: Jan Kiszka >> --- >> arch/arm64/boot/dts/ti/Makefile | 2 + >> .../dts/ti/k3-am65-iot2050-common-pg1.dtsi | 46 ++++++++++++++++ >> .../dts/ti/k3-am65-iot2050-common-pg2.dtsi | 51 ++++++++++++++++++ >> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 35 +----------- >> ...ts => k3-am6528-iot2050-basic-common.dtsi} | 12 ++--- >> .../dts/ti/k3-am6528-iot2050-basic-pg2.dts | 21 ++++++++ >> .../boot/dts/ti/k3-am6528-iot2050-basic.dts | 53 ++----------------- >> ...=> k3-am6548-iot2050-advanced-common.dtsi} | 8 +-- >> .../dts/ti/k3-am6548-iot2050-advanced-pg2.dts | 26 +++++++++ >> .../dts/ti/k3-am6548-iot2050-advanced.dts | 52 ++---------------- >> 10 files changed, 161 insertions(+), 145 deletions(-) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg1.dtsi >> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg2.dtsi >> copy arch/arm64/boot/dts/ti/{k3-am6528-iot2050-basic.dts => k3-am6528-iot2050-basic-common.dtsi} (80%) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dts >> copy arch/arm64/boot/dts/ti/{k3-am6548-iot2050-advanced.dts => k3-am6548-iot2050-advanced-common.dtsi} (86%) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dts > > > Few things: > > a) Could you split this patch so that the refactoring for SR1 is the > first patch and then introduce the SR2? Can do, sure > b) Please call these as sr (silicon revision) rather than pg. Nope, this is only motivated by the SR1->SR2 switch. The new products are called "PG2", and that is what the DT name must reflect. Took me a while to grasp that as well. > c) usual request: Please add urls for the board Where should they go? I think there is only one reasonable to share: https://new.siemens.com/global/en/products/automation/pc-based/iot-gateways/simatic-iot2050.html If that is a stable link, I can't tell. Thanks Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel