From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72EDBC433EF for ; Sun, 13 Feb 2022 21:52:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3976583BBB; Sun, 13 Feb 2022 22:52:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1644789153; bh=PxBQEPR2IxnF/1LWyR8P2bzVf7ieprYCgUAlrdm16Og=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FIJCWmnf7lYbyM3IAlifU23ZPe85SICOyVVIpmUZhmm7j4VoGmqY+/6fZttQuFem+ eoSFw01COPcJ3PHCUxHgE3SFnaYn3NS7Bs8nEBgE/8rdhTGoiY0EhABVRNplos3HIp BrM/BrTmssAhF+HGh2lr1GFqsz5KbScnOGbFyJMjbaL95ENIrgb7dQg+EJa88Sl1wO 9aa3g6Y8XNiCfD0WqeUAs4q7Buv7vapOYCbRvSB5LfVMmTITtzetY0eA/q/k5D9sqg uUXQQSo4jUZT9e0LZiGb3/MGDT7LypAi6mwsc2ULAPg7Au2yVDzFWxsTzYOZeSyqYB +eh4h6y/rO6mQ== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 70CEA83B9C; Sun, 13 Feb 2022 22:52:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1644789152; bh=PxBQEPR2IxnF/1LWyR8P2bzVf7ieprYCgUAlrdm16Og=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TkiTo2Q4LA2MoGMCmTDId5REfRTgQgghCRgkxZVzU0YKscs5R7FHfjifVDcuLDjlQ RSl7/ctPQ0RXRz17S4MUaTDhhKXbz2BmiBCf037zOvhgKSbXR+J0T0CzW8kUOVybKO mmD3BSv9w88CsU9XRFUmGT2SHL4RjQ9pqYSb7X9cZnQyce0aeUuWMESvsLFb5Gm8mu qga4WbL6IphLIAt6Dkw7MVLUykAEsh3SvlOJimjlq1s6BxE5kbEKBAWGBNQYOtpGaX hdCNPQpcU9KWzlqGczOySAeRbsir66bVHqLncbxI4zn0Iunq82+WFTJoPaSZ4nMHWb C7mkhO8EvYhnQ== Message-ID: <37f43a37-4286-1a74-b99b-d6dbb489ec99@denx.de> Date: Sun, 13 Feb 2022 22:52:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 1/3] mmc: fsl_esdhc_imx: use VENDORSPEC_FRC_SDCLK_ON when necessary Content-Language: en-US To: haibo.chen@nxp.com, peng.fan@nxp.com, jh80.chung@samsung.com, festevam@gmail.com, sean.anderson@seco.com, u-boot@lists.denx.de, aford173@gmail.com, tharvey@gateworks.com, andrey.zhizhikin@leica-geosystems.com Cc: uboot-imx@nxp.com References: <1644578217-8947-1-git-send-email-haibo.chen@nxp.com> From: Marek Vasut In-Reply-To: <1644578217-8947-1-git-send-email-haibo.chen@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2/11/22 12:16, haibo.chen@nxp.com wrote: Hi, [...] > @@ -897,6 +900,11 @@ static int fsl_esdhc_execute_tuning(struct udevice *dev, uint32_t opcode) > > esdhc_stop_tuning(mmc); > > + /* change to default setting, let host control the card clock */ > + esdhc_clrbits32(®s->vendorspec, VENDORSPEC_FRC_SDCLK_ON); > + if (readx_poll_timeout(esdhc_read32, ®s->prsstat, tmp, tmp & PRSSTAT_SDOFF, 100)) Please propagate the error in both cases: ret = readx_poll..(); if (ret) dev_warn(...); return ret; > + pr_warn("fsl_esdhc_imx: card clock not gate off as expect.\n"); btw. s@gate@gated@ , s@expect@expected@ (past tense) With those small details fixed: Reviewed-by: Marek Vasut