From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 0/6] remove unncessary void cast
Date: Mon, 11 Sep 2017 13:44:28 +0100 [thread overview]
Message-ID: <37f971b8-cae3-f486-a6d4-ff00bfab99a6@intel.com> (raw)
In-Reply-To: <20170823154445.19494-1-stephen@networkplumber.org>
On 8/23/2017 4:44 PM, Stephen Hemminger wrote:
> There are many places that cast away the return value from
> rte_memcpy(). This was a common practice in the Unix BSD days because
> lint would complain about unused return values, but it is not done
> in modern Linux style because it clutters the code.
>
> Maybe it was done for some Coverity warnings. If so, that issue
> should be addressed with Coverity overrides not more code clutter.
>
> Stephen Hemminger (6):
> testpmd: remove unnecessary void casts
> bnx2x: remove unnecssary void cast of rte_memcpy
> sfc: remove unnecessary cast of rte_memcpy
> e1000: remove unnecessary cast of rte_memcpy
> i40e: remove unnecessary cast of rte_memcpy
> ixgbe: remove unnecessary cast of rte_memcpy
My concern is if coverity complains about return value not checked and
someone starts fixing them adding void casts back.
So I will evaluate the patchset for next-net, so that I can run coverity
on them before merged into main tree, and see the result.
next prev parent reply other threads:[~2017-09-11 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:44 [PATCH 0/6] remove unncessary void cast Stephen Hemminger
2017-08-23 15:44 ` [PATCH 1/6] testpmd: remove unnecessary void casts Stephen Hemminger
2017-09-04 11:39 ` Rybalchenko, Kirill
2017-09-07 8:36 ` Wu, Jingjing
2017-09-11 12:44 ` Ferruh Yigit
2017-08-23 15:44 ` [PATCH 2/6] bnx2x: remove unnecssary void cast of rte_memcpy Stephen Hemminger
2017-09-04 11:50 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [PATCH 3/6] sfc: remove unnecessary " Stephen Hemminger
2017-09-04 12:39 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [PATCH 4/6] e1000: " Stephen Hemminger
2017-09-04 12:40 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [PATCH 5/6] i40e: " Stephen Hemminger
2017-09-04 12:45 ` Rybalchenko, Kirill
2017-09-09 3:24 ` Wu, Jingjing
2017-08-23 15:44 ` [PATCH 6/6] ixgbe: " Stephen Hemminger
2017-09-04 12:49 ` Rybalchenko, Kirill
2017-09-11 12:44 ` Ferruh Yigit [this message]
2017-09-11 13:32 ` [PATCH 0/6] remove unncessary void cast Ferruh Yigit
2017-09-11 13:00 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f971b8-cae3-f486-a6d4-ff00bfab99a6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.