Re: [PATCH 0/8] staging: r8188eu: cleanup several warnings

[Michael Straube <straube.linux@gmail.com>]

On 8/11/21 1:50 AM, Phillip Potter wrote:
> This series does a lot of cleanup, and came about due to me noticing
> that the Makefile contains several lines that silence build warnings
> about unused variables, functions and so on.
> 
> It accomplishes does three things therefore:
> (1) Removes the unused functions no longer called by rtw_ioctl, which
>      was deleted in a previous patch (with the exception of the android
>      code, which I will add back in once ndo_siocdevprivate is merged in).
> (2) Cleanup all build warnings resulting from removing the offending
>      Makefile lines.
> (3) Remove the offending Makefile lines so that future build warnings
>      can be caught locally before submission as well.
> 
> Phillip Potter (8):
>    staging: r8188eu: remove unused functions from os_dep/ioctl_linux.c
>    staging: r8188eu: remove unused oid_null_function function
>    staging: r8188eu: remove unused label from recv_indicatepkt_reorder
>    staging: r8188eu: remove rtw_mfree_sta_priv_lock function
>    staging: r8188eu: remove unused variable from rtl8188e_init_dm_priv
>    staging: r8188eu: remove unused variable from rtw_init_drv_sw
>    staging: r8188eu: remove unused variable from rtw_init_recv_timer
>    staging: r8188eu: remove lines from Makefile that silence build
>      warnings
> 
>   drivers/staging/r8188eu/Makefile             |    9 -
>   drivers/staging/r8188eu/core/rtw_recv.c      |    2 -
>   drivers/staging/r8188eu/core/rtw_sta_mgt.c   |    9 -
>   drivers/staging/r8188eu/hal/rtl8188e_dm.c    |    1 -
>   drivers/staging/r8188eu/include/rtw_ioctl.h  |    6 -
>   drivers/staging/r8188eu/os_dep/ioctl_linux.c | 1538 ++----------------
>   drivers/staging/r8188eu/os_dep/os_intfs.c    |    1 -
>   drivers/staging/r8188eu/os_dep/recv_linux.c  |    2 -
>   8 files changed, 127 insertions(+), 1441 deletions(-)
> 

Acked-by: Michael Straube <straube.linux@gmail.com>

Michael