From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521FEC10F12 for ; Mon, 15 Apr 2019 19:16:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18EB22075B for ; Mon, 15 Apr 2019 19:16:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QRmwTDX9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731562AbfDOTQG (ORCPT ); Mon, 15 Apr 2019 15:16:06 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:46736 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730758AbfDOTQE (ORCPT ); Mon, 15 Apr 2019 15:16:04 -0400 Received: by mail-pg1-f196.google.com with SMTP id q1so9030168pgv.13 for ; Mon, 15 Apr 2019 12:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bbPG6y0yhyNolnwdkUwODZhrQQvWo0cVsPRcOWprviE=; b=QRmwTDX9lJkustAvCp02+9Bqjak0UCU/P0w38datxZqj8tMUwqHkAfHssVLB8rID7y v+W1Q6V2xsvI3U1uh1lSYd9b2WburLUNC/WphoVWDWYV85gYRI/cg66+HREpf7eBVPd9 hxf4Lbk8X6Lexi4GacFOwhphX0vyi54Wuz2wzPVhgLe/Vh2fbItaUNyTnsl1Of2lvpf6 IfD8O5faBNUENU2d9w0K6eoajzRdDCyuxD3/FN9fWae4BKXBOj9dWHPEnn2Q52F4SVCx dvIVX3T4p1pbsR+Z9WtC9/cZnKMQaeW3tc1Df9l3zS+tQYPZhlx5Dr7N1SmKV3+9UkjJ w0rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bbPG6y0yhyNolnwdkUwODZhrQQvWo0cVsPRcOWprviE=; b=OZe+5lSLT1rrsE/CRjkWqcD1onZW0wOnkz2JF1JQeB3fDVeyBMTlze6b/2WCs4S7Dh AMesYUoei3+RfV5WKMCz5/3ARxMGs8hc7bAyYwQOZ5cgsiCJzChuZuE+1d3Cw+WQ1SBm t9aWrnzaonKOKvqcOJj36LdRwE1bdnDWSCCDPkb1tqOj7ZuNq4shHatmlJsGvHXyt7PN u8mJG1X8sqqYN5uAu92e3YK2vvYTUZ7iU6lwtKPAYUParJCdQTKjJN3/qse6urwpfl68 BRjL56EmFqF2h89zt9yAzmCkTjOYEhi7zAsXSFXizNNOQEYBHLHt0t9faZ55RBq4Odcs uufA== X-Gm-Message-State: APjAAAXhDbBxgJ7+l/NcoYn8w5UPEW5fRwfzEGhYwMoJ16ADv+LIcGHM Zw1OZZd/FmoC2cVxnUimXvw= X-Google-Smtp-Source: APXvYqyiKbPQjKnztEkEqfYLhG3SY8o6+lHrT1iLTzvkkdKFTXJuUgtPJkvg2pM1lKN02R13u+TT0w== X-Received: by 2002:a62:b418:: with SMTP id h24mr77065674pfn.145.1555355763809; Mon, 15 Apr 2019 12:16:03 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:91ac:460f:1e02:116c? ([2601:282:800:fd80:91ac:460f:1e02:116c]) by smtp.googlemail.com with ESMTPSA id 4sm66938970pfn.159.2019.04.15.12.16.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2019 12:16:02 -0700 (PDT) Subject: Re: [PATCH net] route: Avoid crash from dereferencing NULL rt->from To: Martin Lau Cc: Jonathan Lemon , "netdev@vger.kernel.org" , Eric Dumazet , Kernel Team References: <20190414212129.2306318-1-jonathan.lemon@gmail.com> <20190415161741.wcczleioxzauz266@kafai-mbp.dhcp.thefacebook.com> From: David Ahern Message-ID: <37ff4eb2-d791-a0f8-0196-a99b4f232f63@gmail.com> Date: Mon, 15 Apr 2019 13:16:00 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190415161741.wcczleioxzauz266@kafai-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/15/19 10:17 AM, Martin Lau wrote: > Hi David, is similar check also needed in rt6_do_redirect() and > inet6_rtm_getroute()? good question. I think both could be returning an rt6_info from the exception cache so yes they should have a similar check.