From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D42FC433E0 for ; Wed, 5 Aug 2020 10:02:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FEFE2173E for ; Wed, 5 Aug 2020 10:02:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yq2SoURX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FEFE2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3GFO-0006WC-HW for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 06:02:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3GD6-0003nd-SV for qemu-devel@nongnu.org; Wed, 05 Aug 2020 05:59:48 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26800 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3GD5-0000A0-2f for qemu-devel@nongnu.org; Wed, 05 Aug 2020 05:59:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596621586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mMOC1mp1b+bVlAEISopOoDzEipUTEFg8HJhBxig2vjw=; b=Yq2SoURXDQp/G21qNd8mF7b0uRmhVTOsOTbFXe7CuL4c2nuJ/aXlOpPF2jRhrMwD032Lia T3WW9Ha5bHRf+YWQYm03aUEIufVnc8SVmshSYPkSl38pK7JbIuCGZnIXyAY9spQaYS0y1k KwkFf+9883R2KyyCKFYqxyMxe4f8ghE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-Wmszxz7tMzGIDrgWs7vG3Q-1; Wed, 05 Aug 2020 05:59:44 -0400 X-MC-Unique: Wmszxz7tMzGIDrgWs7vG3Q-1 Received: by mail-wr1-f71.google.com with SMTP id k11so12898690wrv.1 for ; Wed, 05 Aug 2020 02:59:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=mMOC1mp1b+bVlAEISopOoDzEipUTEFg8HJhBxig2vjw=; b=hr1QBG9UuzWD2uihyLk+sZXF3K25DbI8SMry+Thh2zbiRfQ7BujUS4HmZvjYTCOKtJ oozt/VJKjXz0lm3APoNBoFSCFITOFzzErP1JRO1pnWfc3qw+y6T6bwLUi+yulTAbs2R2 pyEUu/EMDbRIjxd5f+Op16MB/PKG+KipoPOnUEBLgjteMFHN3dgCNSUXlDJeTcG0pefd iNmEvKJJJ69cZ+/PK2tCt7RbbZ7EeI5pzL3aiMLp+PRU+CDIOa7AK1q3z5wKOyj3vlTd 715Ls/MG4H0UFd7Lmm5yAF4mnVL1TU+xntSOiiCxVG3eMfmlkep21sgKKvN2RrId7JN6 xTRw== X-Gm-Message-State: AOAM533YEHhYBfW8b0t6ipcJfNDBH1PRkq/5ianQ21RYLycKYvSK9Wa4 3K2Z29knKZ4a8f6cgA6XX7OvgJAn1xJKvW6KEifk225OvXEAyM4XIN/JxmsL2idfmve1//WQGwq T1z1I9rBu3U57XLs= X-Received: by 2002:a1c:96c5:: with SMTP id y188mr2693001wmd.72.1596621583772; Wed, 05 Aug 2020 02:59:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpCk62D96Xq3HLy8mOVi1UvleS6y6jimWwC4BkjkYY2WnX9lpW6hg75VfFieetx12BuHBbsg== X-Received: by 2002:a1c:96c5:: with SMTP id y188mr2692979wmd.72.1596621583557; Wed, 05 Aug 2020 02:59:43 -0700 (PDT) Received: from [192.168.1.43] (214.red-88-21-68.staticip.rima-tde.net. [88.21.68.214]) by smtp.gmail.com with ESMTPSA id d14sm2042774wre.44.2020.08.05.02.59.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 02:59:43 -0700 (PDT) Subject: Re: [PATCH-for-5.1 v2 2/2] stubs: Remove qemu_notify_event() From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: qemu-devel@nongnu.org References: <20200805085526.9787-1-philmd@redhat.com> <20200805085526.9787-3-philmd@redhat.com> <6846f9a0-ba29-059a-e400-603116f5bb69@redhat.com> Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <38110319-24ea-9a1d-0274-f09f5d33527a@redhat.com> Date: Wed, 5 Aug 2020 11:59:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <6846f9a0-ba29-059a-e400-603116f5bb69@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 01:46:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Thomas Huth , Richard Henderson , Pavel Dovgalyuk , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/5/20 11:42 AM, Philippe Mathieu-Daudé wrote: > On 8/5/20 10:55 AM, Philippe Mathieu-Daudé wrote: >> We don't need the qemu_notify_event() stub anymore. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> stubs/cpu-get-icount.c | 2 +- >> stubs/notify-event.c | 6 ------ >> stubs/Makefile.objs | 1 - >> 3 files changed, 1 insertion(+), 8 deletions(-) >> delete mode 100644 stubs/notify-event.c >> >> diff --git a/stubs/cpu-get-icount.c b/stubs/cpu-get-icount.c >> index b35f844638..8962dfd71f 100644 >> --- a/stubs/cpu-get-icount.c >> +++ b/stubs/cpu-get-icount.c >> @@ -17,5 +17,5 @@ int64_t cpu_get_icount_raw(void) >> >> void qemu_timer_notify_cb(void *opaque, QEMUClockType type) >> { >> - qemu_notify_event(); >> + abort(); > > This abort makes iotest 077 fail. > I think I'll simply repost without it. I don't understand what from 077 trigger this callback, but I confirm doing nothing is safe, ... > >> } >> diff --git a/stubs/notify-event.c b/stubs/notify-event.c >> deleted file mode 100644 >> index 827bb52d1a..0000000000 >> --- a/stubs/notify-event.c >> +++ /dev/null >> @@ -1,6 +0,0 @@ >> -#include "qemu/osdep.h" >> -#include "qemu/main-loop.h" >> - >> -void qemu_notify_event(void) >> -{ ... as this is the current behavior. >> -} >> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs >> index d42046afe4..cb374c96db 100644 >> --- a/stubs/Makefile.objs >> +++ b/stubs/Makefile.objs >> @@ -12,7 +12,6 @@ stub-obj-y += isa-bus.o >> stub-obj-$(CONFIG_LINUX_AIO) += linux-aio.o >> stub-obj-$(CONFIG_LINUX_IO_URING) += io_uring.o >> stub-obj-y += monitor-core.o >> -stub-obj-y += notify-event.o >> stub-obj-y += pci-bus.o >> stub-obj-y += qmp_memory_device.o >> stub-obj-y += qtest.o >> >