From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] igb_uio: fix unexpected removal for hot-unplug Date: Thu, 25 Oct 2018 01:14:58 +0200 Message-ID: <3811387.JjXV5aRat7@xps> References: <1534502916-31636-9-git-send-email-jia.guo@intel.com> <33442113-1445-21a4-3c1b-6ddd5e7586d4@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit , stephen@networkplumber.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, shaopeng.he@intel.com, helin.zhang@intel.com To: Jeff Guo Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E9F6C2C6D for ; Thu, 25 Oct 2018 01:14:57 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/10/2018 13:13, Ferruh Yigit: > On 10/19/2018 9:35 AM, Jeff Guo wrote: > > > > On 10/19/2018 12:06 AM, Ferruh Yigit wrote: > >> On 10/18/2018 7:27 AM, Jeff Guo wrote: > >>> When a device is hot-unplugged, pci_remove will be invoked unexpectedly > >>> before pci_release, it will caused kernel hung issue which will throw the > >>> error info of "Trying to free already-free IRQ XXX". And on the other hand, > >>> if pci_remove before pci_release, the interrupt will not got chance to be > >>> disabled. So this patch aim to fix this issue by adding pci_release call > >>> in pci_remove, it will gurranty that all pci clean up will be done before > >>> pci removal. > >>> > >>> Signed-off-by: Jeff Guo > > Acked-by: Ferruh Yigit Applied, thanks