All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kenneth Graunke <kenneth@whitecape.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2
Date: Wed, 11 Sep 2019 08:22:25 -0700	[thread overview]
Message-ID: <3816138.rDuRQ1uMTf@kirito> (raw)
In-Reply-To: <156818885157.30942.4507661070241185214@skylake-alporthouse-com>


[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]

On Wednesday, September 11, 2019 1:00:51 AM PDT Chris Wilson wrote:
> Quoting Chris Wilson (2019-09-11 08:42:22)
> > Quoting Kenneth Graunke (2019-09-11 02:48:01)
> > > This allows userspace to use "legacy" mode for push constants, where
> > > they are committed at 3DPRIMITIVE or flush time, rather than being
> > > committed at 3DSTATE_BINDING_TABLE_POINTERS_XS time.  Gen6-8 and Gen11
> > > both use the "legacy" behavior - only Gen9 works in the "new" way.
> > > 
> > > Conflating push constants with binding tables is painful for userspace,
> > > we would like to be able to avoid doing so.
> > > 
> > > Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> > > Cc: stable@vger.kernel.org
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Pushed. Do you also want to do this for icl?
> -Chris

Thanks!  I don't think it's necessary for ICL, the bit seems to be gone
and it appears to perform the legacy behavior all the time.

--Ken

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-09-11 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11  1:48 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
2019-09-11  2:34 ` ✓ Fi.CI.BAT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
2019-09-11  7:42 ` [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Chris Wilson
2019-09-11  8:00   ` Chris Wilson
2019-09-11 15:22     ` Kenneth Graunke [this message]
2019-09-11  8:35 ` ✓ Fi.CI.IGT: success for drm/i915: Whitelist COMMON_SLICE_CHICKEN2 (rev2) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-09-10 22:42 [PATCH] drm/i915: Whitelist COMMON_SLICE_CHICKEN2 Kenneth Graunke
2019-09-11  7:41 ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3816138.rDuRQ1uMTf@kirito \
    --to=kenneth@whitecape.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.